mbox series

[v2,00/10] add the support of ipsec offload

Message ID 20230926024959.207098-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series add the support of ipsec offload |

Message

Chaoyong He Sept. 26, 2023, 2:49 a.m. UTC 
  This patch series add the support of ipsec offload feature, includes:
* Implement the communication channel between PMD and firmware through
  mailbox.
* Implement the ipsec offload related APIs based the security framework.
* Implement the ipsec packets process logics in the data path.

---
v2:
* Fix one spell error cause check warning.
* Try to fix one compile error in Alpine environment of CI.
---

Chang Miao (2):
  net/nfp: initialize IPsec related content
  net/nfp: create security session

Shihong Wang (8):
  mailmap: update contributor entry
  net/nfp: add TLVs capability parsing
  net/nfp: add mailbox to support IPsec offload
  net/nfp: get security capabilities and session size
  net/nfp: get IPsec Rx/Tx packet statistics
  net/nfp: update security session
  net/nfp: support IPsec Rx and Tx offload
  net/nfp: destroy security session

 .mailmap                           |    2 +
 doc/guides/nics/nfp.rst            |   31 +
 drivers/net/nfp/meson.build        |    4 +-
 drivers/net/nfp/nfd3/nfp_nfd3_dp.c |   24 +
 drivers/net/nfp/nfdk/nfp_nfdk_dp.c |   24 +
 drivers/net/nfp/nfp_common.c       |   48 +
 drivers/net/nfp/nfp_common.h       |   16 +
 drivers/net/nfp/nfp_ctrl.c         |  153 +++
 drivers/net/nfp/nfp_ctrl.h         |  131 +++
 drivers/net/nfp/nfp_ethdev.c       |   21 +
 drivers/net/nfp/nfp_ipsec.c        | 1458 ++++++++++++++++++++++++++++
 drivers/net/nfp/nfp_ipsec.h        |  175 ++++
 drivers/net/nfp/nfp_rxtx.c         |   74 ++
 drivers/net/nfp/nfp_rxtx.h         |   17 +
 14 files changed, 2177 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/nfp/nfp_ctrl.c
 create mode 100644 drivers/net/nfp/nfp_ipsec.c
 create mode 100644 drivers/net/nfp/nfp_ipsec.h

Comments

Ferruh Yigit Sept. 27, 2023, 2:20 p.m. UTC | #1 
On 9/26/2023 3:49 AM, Chaoyong He wrote:
> This patch series add the support of ipsec offload feature, includes:
> * Implement the communication channel between PMD and firmware through
>   mailbox.
> * Implement the ipsec offload related APIs based the security framework.
> * Implement the ipsec packets process logics in the data path.
> 
> ---
> v2:
> * Fix one spell error cause check warning.
> * Try to fix one compile error in Alpine environment of CI.
> ---
> 
> Chang Miao (2):
>   net/nfp: initialize IPsec related content
>   net/nfp: create security session
> 
> Shihong Wang (8):
>   mailmap: update contributor entry
>   net/nfp: add TLVs capability parsing
>   net/nfp: add mailbox to support IPsec offload
>   net/nfp: get security capabilities and session size
>   net/nfp: get IPsec Rx/Tx packet statistics
>   net/nfp: update security session
>   net/nfp: support IPsec Rx and Tx offload
>   net/nfp: destroy security session
> 

Hi Chaoyong,

Patchset looks good, but adding ipsec support to driver seems
significant enough to document in the release notes, what do you think?
Chaoyong He Sept. 28, 2023, 2:05 a.m. UTC | #2 
> On 9/26/2023 3:49 AM, Chaoyong He wrote:
> > This patch series add the support of ipsec offload feature, includes:
> > * Implement the communication channel between PMD and firmware through
> >   mailbox.
> > * Implement the ipsec offload related APIs based the security framework.
> > * Implement the ipsec packets process logics in the data path.
> >
> > ---
> > v2:
> > * Fix one spell error cause check warning.
> > * Try to fix one compile error in Alpine environment of CI.
> > ---
> >
> > Chang Miao (2):
> >   net/nfp: initialize IPsec related content
> >   net/nfp: create security session
> >
> > Shihong Wang (8):
> >   mailmap: update contributor entry
> >   net/nfp: add TLVs capability parsing
> >   net/nfp: add mailbox to support IPsec offload
> >   net/nfp: get security capabilities and session size
> >   net/nfp: get IPsec Rx/Tx packet statistics
> >   net/nfp: update security session
> >   net/nfp: support IPsec Rx and Tx offload
> >   net/nfp: destroy security session
> >
> 
> Hi Chaoyong,
> 
> Patchset looks good, but adding ipsec support to driver seems significant enough
> to document in the release notes, what do you think?

Yeah, I agree. I will try to add that in the next version.
A separate commit for that or squash that into the final commit of this patch series,
which one you think is better?
Ferruh Yigit Sept. 28, 2023, 9:33 a.m. UTC | #3 
On 9/28/2023 3:05 AM, Chaoyong He wrote:
>> On 9/26/2023 3:49 AM, Chaoyong He wrote:
>>> This patch series add the support of ipsec offload feature, includes:
>>> * Implement the communication channel between PMD and firmware through
>>>   mailbox.
>>> * Implement the ipsec offload related APIs based the security framework.
>>> * Implement the ipsec packets process logics in the data path.
>>>
>>> ---
>>> v2:
>>> * Fix one spell error cause check warning.
>>> * Try to fix one compile error in Alpine environment of CI.
>>> ---
>>>
>>> Chang Miao (2):
>>>   net/nfp: initialize IPsec related content
>>>   net/nfp: create security session
>>>
>>> Shihong Wang (8):
>>>   mailmap: update contributor entry
>>>   net/nfp: add TLVs capability parsing
>>>   net/nfp: add mailbox to support IPsec offload
>>>   net/nfp: get security capabilities and session size
>>>   net/nfp: get IPsec Rx/Tx packet statistics
>>>   net/nfp: update security session
>>>   net/nfp: support IPsec Rx and Tx offload
>>>   net/nfp: destroy security session
>>>
>>
>> Hi Chaoyong,
>>
>> Patchset looks good, but adding ipsec support to driver seems significant enough
>> to document in the release notes, what do you think?
> 
> Yeah, I agree. I will try to add that in the next version.
> A separate commit for that or squash that into the final commit of this patch series,
> which one you think is better?
>

Squashing to the most relevant commit it better,
this creates a link between the documentation and the code which is
useful when back tracing a feature in the git history.