mbox series

[0/2] net/mana: 32 bit support

Message ID 20230921083442.2104530-1-weh@microsoft.com (mailing list archive)
Headers
Series net/mana: 32 bit support |

Message

Wei Hu Sept. 21, 2023, 8:34 a.m. UTC 
  This is to combine two patches into a patchset. These two patches can
be compiled independently. But we need both to make mana functional
in 32 bit. 

Review comments received previously were also incorporated.
- change port casting from size_t to uintptr_t
- remove short doorbell for CQ as it is not supported
- add a couple missing ifdefs
- fix the short doorbell threshold counting in wqes

Need to backport these to 22.11.x

Cc: stable@dpdk.org

Wei Hu (2):
  net/mana: enable 32 bit build for mana driver
  net/mana: add 32 bit short doorbell

 drivers/net/mana/gdma.c      | 92 ++++++++++++++++++++++++++++++++++++
 drivers/net/mana/mana.c      |  2 +-
 drivers/net/mana/mana.h      | 26 ++++++++++
 drivers/net/mana/meson.build |  4 +-
 drivers/net/mana/mr.c        | 18 +++----
 drivers/net/mana/rx.c        | 45 ++++++++++++++++++
 drivers/net/mana/tx.c        | 25 ++++++++++
 7 files changed, 200 insertions(+), 12 deletions(-)

Comments

Ferruh Yigit Sept. 21, 2023, 10:58 a.m. UTC | #1 
On 9/21/2023 9:34 AM, Wei Hu wrote:
> This is to combine two patches into a patchset. These two patches can
> be compiled independently. But we need both to make mana functional
> in 32 bit. 
> 
> Review comments received previously were also incorporated.
> - change port casting from size_t to uintptr_t
> - remove short doorbell for CQ as it is not supported
> - add a couple missing ifdefs
> - fix the short doorbell threshold counting in wqes
> 
> Need to backport these to 22.11.x
> 
> Cc: stable@dpdk.org
> 

Will keep the tag and leave the decision to LTS maintainers.

> Wei Hu (2):
>   net/mana: enable 32 bit build for mana driver
>   net/mana: add 32 bit short doorbell
> 

Looks good to me, will wait Long's ack to proceed.