mbox series

[v3,00/27] refact the nfpcore module

Message ID 20230915091551.1459606-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series refact the nfpcore module |

Message

Chaoyong He Sept. 15, 2023, 9:15 a.m. UTC 
  This patch series aims to:
- Make the coding style satisfy with DPDK.
- Sync the logic with kernel driver.
- Make the sub-module more modular.
- Extend the nfp configure BAR from 8 to 24.

---
v3:
* Fix one bug in the BAR find logic.
* Modify more coding style.
v2:
* Fix the compile error in Fodora 37 environment.
---

Chaoyong He (27):
  net/nfp: explicitly compare to null and 0
  net/nfp: unify the indent coding style
  net/nfp: unify the type of integer variable
  net/nfp: remove the unneeded logic
  net/nfp: standard the local variable coding style
  net/nfp: adjust the log statement
  net/nfp: standard the comment style
  net/nfp: using the DPDK memory management API
  net/nfp: standard the blank character
  net/nfp: unify the guide line of header file
  net/nfp: rename some parameter and variable
  net/nfp: refact the hwinfo module
  net/nfp: refact the nffw module
  net/nfp: refact the mip module
  net/nfp: refact the rtsym module
  net/nfp: refact the resource module
  net/nfp: refact the target module
  net/nfp: add a new header file
  net/nfp: refact the nsp module
  net/nfp: refact the mutex module
  net/nfp: rename data field to sync with kernel driver
  net/nfp: add the dev module
  net/nfp: add header file for PCIe module
  net/nfp: refact the cppcore module
  net/nfp: refact the PCIe module
  net/nfp: refact the cppcore and PCIe module
  net/nfp: extend the usage of nfp BAR from 8 to 24

 drivers/net/nfp/flower/nfp_flower.c           |   14 +-
 .../net/nfp/flower/nfp_flower_representor.c   |    6 +-
 drivers/net/nfp/meson.build                   |    3 +-
 drivers/net/nfp/nfd3/nfp_nfd3_dp.c            |    5 +-
 drivers/net/nfp/nfdk/nfp_nfdk_dp.c            |    5 +-
 drivers/net/nfp/nfp_common.c                  |   50 +-
 drivers/net/nfp/nfp_common.h                  |   52 +-
 drivers/net/nfp/nfp_cpp_bridge.c              |    2 +-
 drivers/net/nfp/nfp_ethdev.c                  |  108 +-
 drivers/net/nfp/nfp_ethdev_vf.c               |   17 +-
 drivers/net/nfp/nfp_rxtx.c                    |    5 +-
 drivers/net/nfp/nfp_rxtx.h                    |   12 -
 drivers/net/nfp/nfpcore/nfp6000/nfp6000.h     |   20 -
 drivers/net/nfp/nfpcore/nfp6000_pcie.c        | 1034 ++++++++++++++++
 drivers/net/nfp/nfpcore/nfp6000_pcie.h        |   20 +
 drivers/net/nfp/nfpcore/nfp_cpp.h             |  776 +++---------
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c    |  824 -------------
 drivers/net/nfp/nfpcore/nfp_cppcore.c         | 1088 +++++++++++------
 drivers/net/nfp/nfpcore/nfp_crc.c             |   23 +-
 drivers/net/nfp/nfpcore/nfp_dev.c             |   81 ++
 drivers/net/nfp/nfpcore/nfp_dev.h             |   44 +
 drivers/net/nfp/nfpcore/nfp_hwinfo.c          |  199 ++-
 drivers/net/nfp/nfpcore/nfp_hwinfo.h          |   74 +-
 drivers/net/nfp/nfpcore/nfp_mip.c             |  103 +-
 drivers/net/nfp/nfpcore/nfp_mip.h             |    7 +-
 drivers/net/nfp/nfpcore/nfp_mutex.c           |  383 +++---
 drivers/net/nfp/nfpcore/nfp_mutex.h           |   25 +
 drivers/net/nfp/nfpcore/nfp_nffw.c            |  210 ++--
 drivers/net/nfp/nfpcore/nfp_nffw.h            |   66 +-
 drivers/net/nfp/nfpcore/nfp_nsp.c             |  580 ++++++---
 drivers/net/nfp/nfpcore/nfp_nsp.h             |  336 ++---
 drivers/net/nfp/nfpcore/nfp_nsp_cmds.c        |   27 +-
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c         |  537 ++++----
 drivers/net/nfp/nfpcore/nfp_platform.h        |   42 +
 drivers/net/nfp/nfpcore/nfp_resource.c        |  216 ++--
 drivers/net/nfp/nfpcore/nfp_resource.h        |   36 +-
 drivers/net/nfp/nfpcore/nfp_rtsym.c           |  452 +++++--
 drivers/net/nfp/nfpcore/nfp_rtsym.h           |   67 +-
 drivers/net/nfp/nfpcore/nfp_target.c          |    9 +-
 drivers/net/nfp/nfpcore/nfp_target.h          |  597 +--------
 40 files changed, 4102 insertions(+), 4053 deletions(-)
 create mode 100644 drivers/net/nfp/nfpcore/nfp6000_pcie.c
 create mode 100644 drivers/net/nfp/nfpcore/nfp6000_pcie.h
 delete mode 100644 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
 create mode 100644 drivers/net/nfp/nfpcore/nfp_dev.c
 create mode 100644 drivers/net/nfp/nfpcore/nfp_dev.h
 create mode 100644 drivers/net/nfp/nfpcore/nfp_mutex.h
 create mode 100644 drivers/net/nfp/nfpcore/nfp_platform.h

Comments

Ferruh Yigit Sept. 15, 2023, 1:49 p.m. UTC | #1 
On 9/15/2023 10:15 AM, Chaoyong He wrote:
> This patch series aims to:
> - Make the coding style satisfy with DPDK.
> - Sync the logic with kernel driver.
> - Make the sub-module more modular.
> - Extend the nfp configure BAR from 8 to 24.
> 
> ---
> v3:
> * Fix one bug in the BAR find logic.
> * Modify more coding style.
> v2:
> * Fix the compile error in Fodora 37 environment.
> ---
> 
> Chaoyong He (27):
>   net/nfp: explicitly compare to null and 0
>   net/nfp: unify the indent coding style
>   net/nfp: unify the type of integer variable
>   net/nfp: remove the unneeded logic
>   net/nfp: standard the local variable coding style
>   net/nfp: adjust the log statement
>   net/nfp: standard the comment style
>   net/nfp: using the DPDK memory management API
>   net/nfp: standard the blank character
>   net/nfp: unify the guide line of header file
>   net/nfp: rename some parameter and variable
>   net/nfp: refact the hwinfo module
>   net/nfp: refact the nffw module
>   net/nfp: refact the mip module
>   net/nfp: refact the rtsym module
>   net/nfp: refact the resource module
>   net/nfp: refact the target module
>   net/nfp: add a new header file
>   net/nfp: refact the nsp module
>   net/nfp: refact the mutex module
>   net/nfp: rename data field to sync with kernel driver
>   net/nfp: add the dev module
>   net/nfp: add header file for PCIe module
>   net/nfp: refact the cppcore module
>   net/nfp: refact the PCIe module
>   net/nfp: refact the cppcore and PCIe module
>   net/nfp: extend the usage of nfp BAR from 8 to 24
> 

Hi Chaoyong, Niklas,

I put some comments on patches, mostly minor comments, only critical one
is the decision to use rte memory management widely or not, please check
comments.