mbox series

[v3,00/11] rework thread management

Message ID 20230913114351.1940459-1-thomas@monjalon.net (mailing list archive)
Headers
Series rework thread management |

Message

Thomas Monjalon Sept. 13, 2023, 11:28 a.m. UTC 
  The main effect of this patch series is to
remove calls to pthread functions except for pthread_cancel and locks.

The function rte_thread_create_control() does not take thread attributes
settings anymore as it looks a useless complication of the API.
Then the rte_thread API is made stable,
so we can remove the old deprecated functions
rte_thread_setname() and rte_ctrl_thread_create().

Some new internal functions are added in rte_thread to make sure
all internal thread names are prefixed with "dpdk-".

Few other cleanups are done.

Future work about pthread portability are about:
  - cancel
  - mutex

---

v2 changes:
  - replace (|_) with _? in checkpatch
  - simplify thread name size doc
  - build time check of internal thread name size
  - clean control thread params struct
v3 change:
  - fix build (wrong placement of RTE_BUILD_BUG_ON)
    note for later: never send a patch during a summit!


Thomas Monjalon (11):
  devtools: warn when adding some pthread calls
  eal: rename thread name length definition
  eal: remove attributes from control thread creation
  eal: promote thread API as stable
  eal: force prefix for internal threads
  lib: convert to internal control threads
  drivers: convert to internal control threads
  examples: convert to normal control threads
  test: convert threads creation
  eal: remove deprecated thread functions
  lib: remove pthread.h from includes

 app/test/process.h                            |  10 +-
 app/test/test_lcores.c                        |   9 +-
 app/test/test_link_bonding.c                  |   2 +
 app/test/test_pdump.c                         |   6 +-
 app/test/test_pdump.h                         |   2 +-
 app/test/test_threads.c                       |   2 +-
 devtools/checkpatches.sh                      |  16 +++
 .../prog_guide/env_abstraction_layer.rst      |   2 +-
 doc/guides/rel_notes/deprecation.rst          |   5 -
 doc/guides/rel_notes/release_23_11.rst        |   6 +
 drivers/common/cnxk/roc_dev.c                 |  16 +--
 drivers/common/cnxk/roc_dev_priv.h            |   2 +-
 drivers/common/cnxk/roc_nix_inl_dev.c         |   9 +-
 drivers/common/cnxk/roc_nix_inl_priv.h        |   2 +-
 drivers/common/cnxk/roc_platform.h            |   3 +-
 drivers/common/mlx5/mlx5_common.c             |   1 +
 drivers/common/mlx5/windows/mlx5_win_ext.h    |   2 +
 drivers/dma/skeleton/skeleton_dmadev.c        |   8 +-
 drivers/event/dlb2/pf/base/dlb2_osdep.h       |  14 +-
 drivers/event/dlb2/pf/base/dlb2_resource.c    |  39 +++---
 drivers/event/dlb2/pf/dlb2_main.h             |   1 -
 drivers/net/ark/ark_ethdev.c                  |  11 +-
 drivers/net/ark/ark_pktgen.c                  |   8 +-
 drivers/net/ark/ark_pktgen.h                  |   2 +-
 drivers/net/bnxt/bnxt.h                       |   1 +
 drivers/net/iavf/iavf_vchnl.c                 |   4 +-
 drivers/net/ice/ice_dcf_parent.c              |   7 +-
 drivers/net/ipn3ke/ipn3ke_representor.c       |  17 ++-
 drivers/net/ixgbe/ixgbe_ethdev.c              |   8 +-
 drivers/net/mlx5/mlx5.h                       |   2 +-
 drivers/net/mlx5/mlx5_hws_cnt.c               |  42 +++---
 drivers/net/qede/base/bcm_osal.h              |   1 +
 drivers/net/sfc/sfc_mae.h                     |   2 +-
 drivers/net/sfc/sfc_mae_counter.c             |  11 +-
 drivers/net/txgbe/txgbe_ethdev.c              |   6 +-
 drivers/raw/ifpga/base/opae_osdep.h           |   1 +
 drivers/raw/ifpga/ifpga_rawdev.c              |  19 ++-
 drivers/vdpa/ifc/ifcvf_vdpa.c                 |  86 ++++++------
 drivers/vdpa/mlx5/mlx5_vdpa.c                 |   2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.h                 |  10 +-
 drivers/vdpa/mlx5/mlx5_vdpa_cthread.c         |  70 +++-------
 drivers/vdpa/mlx5/mlx5_vdpa_event.c           |  64 +++------
 drivers/vdpa/sfc/sfc_vdpa.c                   |   1 +
 drivers/vdpa/sfc/sfc_vdpa_ops.c               |  15 +-
 drivers/vdpa/sfc/sfc_vdpa_ops.h               |   3 +-
 examples/vhost/main.c                         |   9 +-
 examples/vhost_blk/vhost_blk.c                |  21 +--
 lib/eal/common/eal_common_options.c           |   1 +
 lib/eal/common/eal_common_proc.c              |  15 +-
 lib/eal/common/eal_common_thread.c            | 131 +++++++-----------
 lib/eal/common/eal_common_trace.c             |   1 +
 lib/eal/common/malloc_mp.c                    |   1 +
 lib/eal/freebsd/eal.c                         |   2 +-
 lib/eal/freebsd/eal_alarm.c                   |   1 +
 lib/eal/freebsd/eal_interrupts.c              |  10 +-
 lib/eal/freebsd/eal_thread.c                  |   9 +-
 lib/eal/include/rte_eal.h                     |   3 -
 lib/eal/include/rte_lcore.h                   |  42 ------
 lib/eal/include/rte_per_lcore.h               |   2 -
 lib/eal/include/rte_thread.h                  | 131 +++++++++---------
 lib/eal/linux/eal.c                           |   2 +-
 lib/eal/linux/eal_alarm.c                     |   1 +
 lib/eal/linux/eal_interrupts.c                |  10 +-
 lib/eal/linux/eal_thread.c                    |  18 +--
 lib/eal/linux/eal_timer.c                     |  11 +-
 lib/eal/unix/rte_thread.c                     |   2 +-
 lib/eal/version.map                           |  44 +++---
 lib/eal/windows/eal.c                         |   2 +-
 lib/eal/windows/eal_interrupts.c              |   2 +-
 lib/eal/windows/eal_thread.c                  |   8 --
 lib/eal/windows/rte_thread.c                  |   2 +-
 lib/ethdev/ethdev_driver.c                    |   1 +
 lib/ethdev/ethdev_driver.h                    |   2 +
 lib/ethdev/rte_ethdev_core.h                  |   2 -
 lib/ethdev/rte_flow.c                         |   1 +
 lib/eventdev/rte_event_eth_rx_adapter.c       |  24 ++--
 lib/vhost/fd_man.c                            |   6 +-
 lib/vhost/fd_man.h                            |   2 +-
 lib/vhost/socket.c                            |  23 ++-
 lib/vhost/vduse.c                             |   5 +-
 lib/vhost/vhost.c                             |   1 +
 81 files changed, 466 insertions(+), 632 deletions(-)

Comments

Konstantin Ananyev Sept. 17, 2023, 12:26 p.m. UTC | #1 
13/09/2023 12:28, Thomas Monjalon пишет:
> The main effect of this patch series is to
> remove calls to pthread functions except for pthread_cancel and locks.
> 
> The function rte_thread_create_control() does not take thread attributes
> settings anymore as it looks a useless complication of the API.
> Then the rte_thread API is made stable,
> so we can remove the old deprecated functions
> rte_thread_setname() and rte_ctrl_thread_create().
> 
> Some new internal functions are added in rte_thread to make sure
> all internal thread names are prefixed with "dpdk-".
> 
> Few other cleanups are done.
> 
> Future work about pthread portability are about:
>    - cancel
>    - mutex
> 
> ---
> 
> v2 changes:
>    - replace (|_) with _? in checkpatch
>    - simplify thread name size doc
>    - build time check of internal thread name size
>    - clean control thread params struct
> v3 change:
>    - fix build (wrong placement of RTE_BUILD_BUG_ON)
>      note for later: never send a patch during a summit!
> 
> 
> Thomas Monjalon (11):
>    devtools: warn when adding some pthread calls
>    eal: rename thread name length definition
>    eal: remove attributes from control thread creation
>    eal: promote thread API as stable
>    eal: force prefix for internal threads
>    lib: convert to internal control threads
>    drivers: convert to internal control threads
>    examples: convert to normal control threads
>    test: convert threads creation
>    eal: remove deprecated thread functions
>    lib: remove pthread.h from includes
> 
>   app/test/process.h                            |  10 +-
>   app/test/test_lcores.c                        |   9 +-
>   app/test/test_link_bonding.c                  |   2 +
>   app/test/test_pdump.c                         |   6 +-
>   app/test/test_pdump.h                         |   2 +-
>   app/test/test_threads.c                       |   2 +-
>   devtools/checkpatches.sh                      |  16 +++
>   .../prog_guide/env_abstraction_layer.rst      |   2 +-
>   doc/guides/rel_notes/deprecation.rst          |   5 -
>   doc/guides/rel_notes/release_23_11.rst        |   6 +
>   drivers/common/cnxk/roc_dev.c                 |  16 +--
>   drivers/common/cnxk/roc_dev_priv.h            |   2 +-
>   drivers/common/cnxk/roc_nix_inl_dev.c         |   9 +-
>   drivers/common/cnxk/roc_nix_inl_priv.h        |   2 +-
>   drivers/common/cnxk/roc_platform.h            |   3 +-
>   drivers/common/mlx5/mlx5_common.c             |   1 +
>   drivers/common/mlx5/windows/mlx5_win_ext.h    |   2 +
>   drivers/dma/skeleton/skeleton_dmadev.c        |   8 +-
>   drivers/event/dlb2/pf/base/dlb2_osdep.h       |  14 +-
>   drivers/event/dlb2/pf/base/dlb2_resource.c    |  39 +++---
>   drivers/event/dlb2/pf/dlb2_main.h             |   1 -
>   drivers/net/ark/ark_ethdev.c                  |  11 +-
>   drivers/net/ark/ark_pktgen.c                  |   8 +-
>   drivers/net/ark/ark_pktgen.h                  |   2 +-
>   drivers/net/bnxt/bnxt.h                       |   1 +
>   drivers/net/iavf/iavf_vchnl.c                 |   4 +-
>   drivers/net/ice/ice_dcf_parent.c              |   7 +-
>   drivers/net/ipn3ke/ipn3ke_representor.c       |  17 ++-
>   drivers/net/ixgbe/ixgbe_ethdev.c              |   8 +-
>   drivers/net/mlx5/mlx5.h                       |   2 +-
>   drivers/net/mlx5/mlx5_hws_cnt.c               |  42 +++---
>   drivers/net/qede/base/bcm_osal.h              |   1 +
>   drivers/net/sfc/sfc_mae.h                     |   2 +-
>   drivers/net/sfc/sfc_mae_counter.c             |  11 +-
>   drivers/net/txgbe/txgbe_ethdev.c              |   6 +-
>   drivers/raw/ifpga/base/opae_osdep.h           |   1 +
>   drivers/raw/ifpga/ifpga_rawdev.c              |  19 ++-
>   drivers/vdpa/ifc/ifcvf_vdpa.c                 |  86 ++++++------
>   drivers/vdpa/mlx5/mlx5_vdpa.c                 |   2 +-
>   drivers/vdpa/mlx5/mlx5_vdpa.h                 |  10 +-
>   drivers/vdpa/mlx5/mlx5_vdpa_cthread.c         |  70 +++-------
>   drivers/vdpa/mlx5/mlx5_vdpa_event.c           |  64 +++------
>   drivers/vdpa/sfc/sfc_vdpa.c                   |   1 +
>   drivers/vdpa/sfc/sfc_vdpa_ops.c               |  15 +-
>   drivers/vdpa/sfc/sfc_vdpa_ops.h               |   3 +-
>   examples/vhost/main.c                         |   9 +-
>   examples/vhost_blk/vhost_blk.c                |  21 +--
>   lib/eal/common/eal_common_options.c           |   1 +
>   lib/eal/common/eal_common_proc.c              |  15 +-
>   lib/eal/common/eal_common_thread.c            | 131 +++++++-----------
>   lib/eal/common/eal_common_trace.c             |   1 +
>   lib/eal/common/malloc_mp.c                    |   1 +
>   lib/eal/freebsd/eal.c                         |   2 +-
>   lib/eal/freebsd/eal_alarm.c                   |   1 +
>   lib/eal/freebsd/eal_interrupts.c              |  10 +-
>   lib/eal/freebsd/eal_thread.c                  |   9 +-
>   lib/eal/include/rte_eal.h                     |   3 -
>   lib/eal/include/rte_lcore.h                   |  42 ------
>   lib/eal/include/rte_per_lcore.h               |   2 -
>   lib/eal/include/rte_thread.h                  | 131 +++++++++---------
>   lib/eal/linux/eal.c                           |   2 +-
>   lib/eal/linux/eal_alarm.c                     |   1 +
>   lib/eal/linux/eal_interrupts.c                |  10 +-
>   lib/eal/linux/eal_thread.c                    |  18 +--
>   lib/eal/linux/eal_timer.c                     |  11 +-
>   lib/eal/unix/rte_thread.c                     |   2 +-
>   lib/eal/version.map                           |  44 +++---
>   lib/eal/windows/eal.c                         |   2 +-
>   lib/eal/windows/eal_interrupts.c              |   2 +-
>   lib/eal/windows/eal_thread.c                  |   8 --
>   lib/eal/windows/rte_thread.c                  |   2 +-
>   lib/ethdev/ethdev_driver.c                    |   1 +
>   lib/ethdev/ethdev_driver.h                    |   2 +
>   lib/ethdev/rte_ethdev_core.h                  |   2 -
>   lib/ethdev/rte_flow.c                         |   1 +
>   lib/eventdev/rte_event_eth_rx_adapter.c       |  24 ++--
>   lib/vhost/fd_man.c                            |   6 +-
>   lib/vhost/fd_man.h                            |   2 +-
>   lib/vhost/socket.c                            |  23 ++-
>   lib/vhost/vduse.c                             |   5 +-
>   lib/vhost/vhost.c                             |   1 +
>   81 files changed, 466 insertions(+), 632 deletions(-)
> 


Series-acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
David Marchand Sept. 22, 2023, 1:46 p.m. UTC | #2 
On Wed, Sep 13, 2023 at 1:45 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The main effect of this patch series is to
> remove calls to pthread functions except for pthread_cancel and locks.
>
> The function rte_thread_create_control() does not take thread attributes
> settings anymore as it looks a useless complication of the API.
> Then the rte_thread API is made stable,
> so we can remove the old deprecated functions
> rte_thread_setname() and rte_ctrl_thread_create().
>
> Some new internal functions are added in rte_thread to make sure
> all internal thread names are prefixed with "dpdk-".
>
> Few other cleanups are done.
>
> Future work about pthread portability are about:
>   - cancel
>   - mutex
>
> ---
>
> v2 changes:
>   - replace (|_) with _? in checkpatch
>   - simplify thread name size doc
>   - build time check of internal thread name size
>   - clean control thread params struct
> v3 change:
>   - fix build (wrong placement of RTE_BUILD_BUG_ON)
>     note for later: never send a patch during a summit!

Series applied, thanks.