Message ID | 20230626184223.155390-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FB9142D5F; Mon, 26 Jun 2023 20:42:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6832E40223; Mon, 26 Jun 2023 20:42:53 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 8D8114013F for <dev@dpdk.org>; Mon, 26 Jun 2023 20:42:51 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-53482b44007so1768494a12.2 for <dev@dpdk.org>; Mon, 26 Jun 2023 11:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687804970; x=1690396970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ia98ALs06bcqA9ySjSNisJ33jO+MuBUx45qXStzdiBs=; b=ssf9aCCSOtSE+UjD5TvIgf8F8kDmnRl0zV1LLkMvD6CUvxnlo6N9ig/pnueLb1HXYG GYbPNKGuVIIaLg4+RRWLNdFRIbAOVHMK9ip1XdcFXVeOcZuIqHKS8Y2LNcEpebGVQDK7 lxADQyvqEE41577kRjoOTBMSL7ZOmuiWfvDQ9DRUj9sukLa5EV+abb9lVu62efxOHe6a sCwkI6Q0VF9b6rsesSDVf75+vYsZu94ZRH/3zzmqskR7vzpgmyOFBE1DVJ+UibT/Inh7 KWTGml52yD4f6mmlmpMb0Sh86fOFd6uP4M+gGrzNrkY1GzN6bSy62h/vblGZlMEIKwpR Zehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687804970; x=1690396970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ia98ALs06bcqA9ySjSNisJ33jO+MuBUx45qXStzdiBs=; b=VFB/NS+mzPjlLRrtF8q4L0ZHJLvG6MLbQAOz1p4kHgOgYjGzOdB9AzkAre5JQgjqd/ Vgk0X6Io9okPCMmEiGUfWIXQ0TXzqThU9cHSXqp0xwYNwAzFml0743bO7ot3Yog+Pq4d Xu3BD9tuH8lTILbdb6FtthHGnHp0dbCodR4SeESpq46zbAycSEAdIjn9/cpicWz6zmJR Zfh6ZQOTu7DHJDvXLi8b6hnF6ZRV1hIGaVoo1XNYKCyGips44Zxohl7JTRSxADcJKQVr LteLrC6an8VFBLBlT+K0ieLS8vsTUWreyxzvM0jOh5KkcCjnv5KfF/HeUUinKC2bnPQ0 fmuA== X-Gm-Message-State: AC+VfDxD46hL7dR6j1m5Fq1ez4MrJdLce3me2e7R5nT1L9xvkTGEkA1r yDhnU06BnvfkISdiOc48Gt+EA0I4Y+2LJGKOZN2wDg== X-Google-Smtp-Source: ACHHUZ7HqFHAoyWv8drNIxcCLb5cjLgrWjuDdhdcEevFzVeRbzh2EgZGmVksQV4EVcxxxnm8+FUokQ== X-Received: by 2002:a17:90a:1947:b0:260:94fa:45d with SMTP id 7-20020a17090a194700b0026094fa045dmr14520575pjh.30.1687804970288; Mon, 26 Jun 2023 11:42:50 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id h17-20020a17090adb9100b0024e37e0a67dsm4846577pjv.20.2023.06.26.11.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 11:42:49 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Subject: [PATCH v4 0/5] Logging related patchs Date: Mon, 26 Jun 2023 11:42:11 -0700 Message-Id: <20230626184223.155390-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Logging related patchs
|
|
Message
Stephen Hemminger
June 26, 2023, 6:42 p.m. UTC
This patch set rebases and extends some earlier work on logging. Stephen Hemminger (5): eal: unify logging code for FreeBsd and Linux eal: turn off getopt_long error message during eal_log_level eal: skip stdio on console logging eal: move logging initialization earlier eal: add option to put timestamp on console output .../freebsd_gsg/freebsd_eal_parameters.rst | 32 +++++++ doc/guides/linux_gsg/linux_eal_parameters.rst | 5 + lib/eal/common/eal_common_options.c | 6 ++ lib/eal/common/eal_internal_cfg.h | 3 + lib/eal/common/eal_options.h | 2 + lib/eal/freebsd/eal.c | 39 +++++--- lib/eal/linux/eal.c | 48 +++++----- lib/eal/linux/eal_log.c | 61 ------------ lib/eal/linux/meson.build | 1 - lib/eal/unix/eal_log.c | 93 +++++++++++++++++++ lib/eal/unix/meson.build | 1 + lib/eal/windows/eal.c | 3 + 12 files changed, 194 insertions(+), 100 deletions(-) delete mode 100644 lib/eal/linux/eal_log.c create mode 100644 lib/eal/unix/eal_log.c
Comments
> From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, 26 June 2023 20.42 > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [PATCH v4 0/5] Logging related patchs > > This patch set rebases and extends some earlier work on logging. > > Stephen Hemminger (5): > eal: unify logging code for FreeBsd and Linux > eal: turn off getopt_long error message during eal_log_level > eal: skip stdio on console logging > eal: move logging initialization earlier > eal: add option to put timestamp on console output Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
On Tue, 27 Jun 2023 09:40:01 +0200 Morten Brørup <mb@smartsharesystems.com> wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and extends some earlier work on logging. > > > > Stephen Hemminger (5): > > eal: unify logging code for FreeBsd and Linux > > eal: turn off getopt_long error message during eal_log_level > > eal: skip stdio on console logging > > eal: move logging initialization earlier > > eal: add option to put timestamp on console output > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> > There are a few bugs, still working them out. In initial review feedback there was desire for timestamp feature to be global. I.e secondary process would show time since start of primary. But this would hard to implement due to chicken/egg issues during argument parsing during startup; so made a decision that it wasn't worth doing.
On Tue, Jun 27, 2023 at 09:40:01AM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and extends some earlier work on logging. > > > > Stephen Hemminger (5): > > eal: unify logging code for FreeBsd and Linux > > eal: turn off getopt_long error message during eal_log_level > > eal: skip stdio on console logging > > eal: move logging initialization earlier > > eal: add option to put timestamp on console output > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> > Gave it a quick sanity-test run on FreeBSD and all looks ok to me. Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, 27 June 2023 16.49 > > On Tue, 27 Jun 2023 09:40:01 +0200 > Morten Brørup <mb@smartsharesystems.com> wrote: > > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Sent: Monday, 26 June 2023 20.42 > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [PATCH v4 0/5] Logging related patchs > > > > > > This patch set rebases and extends some earlier work on logging. > > > > > > Stephen Hemminger (5): > > > eal: unify logging code for FreeBsd and Linux > > > eal: turn off getopt_long error message during eal_log_level > > > eal: skip stdio on console logging > > > eal: move logging initialization earlier > > > eal: add option to put timestamp on console output > > > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> > > > > There are a few bugs, still working them out. > In initial review feedback there was desire for timestamp feature > to be global. I.e secondary process would show time since start > of primary. But this would hard to implement due to chicken/egg > issues during argument parsing during startup; so made a decision > that it wasn't worth doing. I suppose it could be implemented with a piece of shared memory set by the primary process and read by secondary processes, holding the start time offset from a system global timer (e.g. CLOCK_MONOTONIC) and a tristate variable telling if timestamps are configured - which, if true or false, overrides any timestamp parameter given to the secondary process. Anyway, secondary process support is far from perfect, so I wouldn't worry too much about getting timestamp parameters from the primary process to the secondary process either. In short: I agree with your decision.