mbox series

[v1,0/2] add IPv6 extension push remove

Message ID 20230524073929.400623-1-rongweil@nvidia.com (mailing list archive)
Headers
Series add IPv6 extension push remove |

Message

Rongwei Liu May 24, 2023, 7:39 a.m. UTC 
  Add new rte_actions to push and remove the specific
type of IPv6 extension to and from original packets.

v1: Split the PMD implementation, add a description into release notes.

Rongwei Liu (2):
  ethdev: add IPv6 extension push remove action
  app/testpmd: add IPv6 extension push remove cli

 app/test-pmd/cmdline_flow.c            | 443 ++++++++++++++++++++++++-
 doc/guides/prog_guide/rte_flow.rst     |  21 ++
 doc/guides/rel_notes/release_23_07.rst |   6 +
 lib/ethdev/rte_flow.c                  |   2 +
 lib/ethdev/rte_flow.h                  |  52 +++
 5 files changed, 523 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit June 2, 2023, 2:39 p.m. UTC | #1 
On 5/24/2023 8:39 AM, Rongwei Liu wrote:
> Add new rte_actions to push and remove the specific
> type of IPv6 extension to and from original packets.
> 
> v1: Split the PMD implementation, add a description into release notes.
> 
> Rongwei Liu (2):
>   ethdev: add IPv6 extension push remove action
>   app/testpmd: add IPv6 extension push remove cli
>

Series applied to dpdk-next-net/main, thanks.
Rongwei Liu July 10, 2023, 2:32 a.m. UTC | #2 
Hi Ferruh & Andrew & Ori & Thomas:
	Sorry, we can't commit the PMD implementation for "IPv6 extension push remove" feature in time for this release.
	There are some dis-agreements which need to be addressed internally. 
	We will continue to work on this and plan to push it in the next release.

	RFC link: https://patchwork.dpdk.org/project/dpdk/cover/20230417022630.2377505-1-rongweil@nvidia.com/
	V1 patch with full PMD implementation: https://patchwork.dpdk.org/project/dpdk/cover/20230417092540.2617450-1-rongweil@nvidia.com/
BR
Rongwei

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Friday, June 2, 2023 22:39
> To: Rongwei Liu <rongweil@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Suanming Mou <suanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v1 0/2] add IPv6 extension push remove
> 
> External email: Use caution opening links or attachments
> 
> 
> On 5/24/2023 8:39 AM, Rongwei Liu wrote:
> > Add new rte_actions to push and remove the specific type of IPv6
> > extension to and from original packets.
> >
> > v1: Split the PMD implementation, add a description into release notes.
> >
> > Rongwei Liu (2):
> >   ethdev: add IPv6 extension push remove action
> >   app/testpmd: add IPv6 extension push remove cli
> >
> 
> Series applied to dpdk-next-net/main, thanks.
Ferruh Yigit July 10, 2023, 8:55 a.m. UTC | #3 
On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> Hi Ferruh & Andrew & Ori & Thomas:
> 	Sorry, we can't commit the PMD implementation for "IPv6 extension push remove" feature in time for this release.
> 	There are some dis-agreements which need to be addressed internally. 
> 	We will continue to work on this and plan to push it in the next release.
> 
> 	RFC link: https://patchwork.dpdk.org/project/dpdk/cover/20230417022630.2377505-1-rongweil@nvidia.com/
> 	V1 patch with full PMD implementation: https://patchwork.dpdk.org/project/dpdk/cover/20230417092540.2617450-1-rongweil@nvidia.com/
> 

Hi Rongwei,

Thanks for the heads up.
As long as there is a plan to upstream driver implementation, I think it
is OK to keep ethdev change and wait for driver implementation for
better design instead of rushing it for this release with lower quality
(although target should be to have driver changes with same release with
API changes for future features).


>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>> Sent: Friday, June 2, 2023 22:39
>> To: Rongwei Liu <rongweil@nvidia.com>; Matan Azrad <matan@nvidia.com>;
>> Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
>> Suanming Mou <suanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon
>> (EXTERNAL) <thomas@monjalon.net>
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH v1 0/2] add IPv6 extension push remove
>>
>> External email: Use caution opening links or attachments
>>
>>
>> On 5/24/2023 8:39 AM, Rongwei Liu wrote:
>>> Add new rte_actions to push and remove the specific type of IPv6
>>> extension to and from original packets.
>>>
>>> v1: Split the PMD implementation, add a description into release notes.
>>>
>>> Rongwei Liu (2):
>>>   ethdev: add IPv6 extension push remove action
>>>   app/testpmd: add IPv6 extension push remove cli
>>>
>>
>> Series applied to dpdk-next-net/main, thanks.
>
Stephen Hemminger July 10, 2023, 2:41 p.m. UTC | #4 
On Mon, 10 Jul 2023 09:55:59 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> > Hi Ferruh & Andrew & Ori & Thomas:
> > 	Sorry, we can't commit the PMD implementation for "IPv6 extension push remove" feature in time for this release.
> > 	There are some dis-agreements which need to be addressed internally. 
> > 	We will continue to work on this and plan to push it in the next release.
> > 
> > 	RFC link: https://patchwork.dpdk.org/project/dpdk/cover/20230417022630.2377505-1-rongweil@nvidia.com/
> > 	V1 patch with full PMD implementation: https://patchwork.dpdk.org/project/dpdk/cover/20230417092540.2617450-1-rongweil@nvidia.com/
> >   
> 
> Hi Rongwei,
> 
> Thanks for the heads up.
> As long as there is a plan to upstream driver implementation, I think it
> is OK to keep ethdev change and wait for driver implementation for
> better design instead of rushing it for this release with lower quality
> (although target should be to have driver changes with same release with
> API changes for future features).

Please wait the change until driver is ready.
Don't want to deal with API/ABI changes when driver is upstream.
Also, no unused code please.
Thomas Monjalon July 11, 2023, 6:16 a.m. UTC | #5 
10/07/2023 16:41, Stephen Hemminger:
> On Mon, 10 Jul 2023 09:55:59 +0100
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> 
> > On 7/10/2023 3:32 AM, Rongwei Liu wrote:
> > > Hi Ferruh & Andrew & Ori & Thomas:
> > > 	Sorry, we can't commit the PMD implementation for "IPv6 extension push remove" feature in time for this release.
> > > 	There are some dis-agreements which need to be addressed internally. 
> > > 	We will continue to work on this and plan to push it in the next release.
> > > 
> > > 	RFC link: https://patchwork.dpdk.org/project/dpdk/cover/20230417022630.2377505-1-rongweil@nvidia.com/
> > > 	V1 patch with full PMD implementation: https://patchwork.dpdk.org/project/dpdk/cover/20230417092540.2617450-1-rongweil@nvidia.com/
> > >   
> > 
> > Hi Rongwei,
> > 
> > Thanks for the heads up.
> > As long as there is a plan to upstream driver implementation, I think it
> > is OK to keep ethdev change and wait for driver implementation for
> > better design instead of rushing it for this release with lower quality
> > (although target should be to have driver changes with same release with
> > API changes for future features).
> 
> Please wait the change until driver is ready.
> Don't want to deal with API/ABI changes when driver is upstream.
> Also, no unused code please.

There was a driver patch sent in April.
It was impossible to imagine it was not good enough to be merged.