mbox series

[v2,0/2] net/igc: support launch time offloading

Message ID 20230201073014.431924-1-simei.su@intel.com (mailing list archive)
Headers
Series net/igc: support launch time offloading |

Message

Simei Su Feb. 1, 2023, 7:30 a.m. UTC 
  [PATCH v2 1/2] expose packet pacing registers
[PATCH v2 2/2] enable launch time offloading

v2:
* Refine title and commit log.
* Add release notes.
* Rename variable name.

Simei Su (2):
  net/igc/base: expose packet pacing registers
  net/igc: enable launch time offloading

 doc/guides/rel_notes/release_23_03.rst |  2 +-
 drivers/net/igc/base/igc_defines.h     |  9 +++++
 drivers/net/igc/base/igc_regs.h        |  8 ++++
 drivers/net/igc/igc_ethdev.c           | 70 ++++++++++++++++++++++++++++++++++
 drivers/net/igc/igc_ethdev.h           |  6 ++-
 drivers/net/igc/igc_txrx.c             | 58 ++++++++++++++++++++++++----
 drivers/net/igc/igc_txrx.h             |  3 ++
 7 files changed, 146 insertions(+), 10 deletions(-)

Comments

Morten Brørup Feb. 1, 2023, 8:46 a.m. UTC | #1 
+To: Ferruh, Matan and Viacheslav, regarding feature documentation

> From: Simei Su [mailto:simei.su@intel.com]
> Sent: Wednesday, 1 February 2023 08.30
> 
> [PATCH v2 1/2] expose packet pacing registers
> [PATCH v2 2/2] enable launch time offloading
> 
> v2:
> * Refine title and commit log.
> * Add release notes.
> * Rename variable name.
> 
> Simei Su (2):
>   net/igc/base: expose packet pacing registers
>   net/igc: enable launch time offloading
> 
>  doc/guides/rel_notes/release_23_03.rst |  2 +-
>  drivers/net/igc/base/igc_defines.h     |  9 +++++
>  drivers/net/igc/base/igc_regs.h        |  8 ++++
>  drivers/net/igc/igc_ethdev.c           | 70
> ++++++++++++++++++++++++++++++++++
>  drivers/net/igc/igc_ethdev.h           |  6 ++-
>  drivers/net/igc/igc_txrx.c             | 58 ++++++++++++++++++++++++--
> --
>  drivers/net/igc/igc_txrx.h             |  3 ++
>  7 files changed, 146 insertions(+), 10 deletions(-)
> 
> --
> 2.9.5
> 

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>

Please also note:

This RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP feature should be added to the documentation of NIC features [1] and [2].

[1]: https://doc.dpdk.org/guides/nics/overview.html
[2]: https://doc.dpdk.org/guides/nics/features.html

This should have been done when the feature was introduced by the mlx5 PMD. But apparently, no one thought about it back then. And late is better than never.

Also, adding the feature to the documentation might help deciding on a common name for it.