[v4,0/5] support dmadev/ethdev stats reset

  This patchset contains dmadev/ethdev stats reset, and also support
hide zero for ethdev xstats and two telemetry related bugs.

Chengwen Feng (5):
  dmadev: support stats reset telemetry command
  telemetry: fix repeat display when callback don't init dict
  ethdev: add newline to telemetry log string
  ethdev: support xstats reset telemetry command
  ethdev: telemetry xstats support hide zero

---
v4:
* solve the internal don't commit for 5/5 patch.
v3:
* address Bruce's comment on 1/5 and 2/5 patch, and also for 4/5 patch.
* reword the help info of 5/5 patch.
v2:
* address Bruce's comment on 2/5 patch.
* support output success when stats reset.

 lib/dmadev/rte_dmadev.c   | 43 ++++++++++++++++++++++++++++++
 lib/ethdev/rte_ethdev.c   | 56 ++++++++++++++++++++++++++++++++-------
 lib/telemetry/telemetry.c |  2 +-
 3 files changed, 91 insertions(+), 10 deletions(-)
  

20/01/2023 04:34, Chengwen Feng:
> This patchset contains dmadev/ethdev stats reset, and also support
> hide zero for ethdev xstats and two telemetry related bugs.
> 
> Chengwen Feng (5):
>   dmadev: support stats reset telemetry command
>   telemetry: fix repeat display when callback don't init dict
>   ethdev: add newline to telemetry log string
>   ethdev: support xstats reset telemetry command
>   ethdev: telemetry xstats support hide zero

Ping for review.
  

On Fri, Jan 20, 2023 at 03:34:51AM +0000, Chengwen Feng wrote:
> This patchset contains dmadev/ethdev stats reset, and also support
> hide zero for ethdev xstats and two telemetry related bugs.
> 
> Chengwen Feng (5):
>   dmadev: support stats reset telemetry command
>   telemetry: fix repeat display when callback don't init dict
>   ethdev: add newline to telemetry log string
>   ethdev: support xstats reset telemetry command
>   ethdev: telemetry xstats support hide zero
> 
On one level, I can understand how this may be useful, but on the other
side, we also support having multiple different clients connecting to
telemetry simultaneously. Would it not be problematic to have stats
suddenly being reset by one connection without the others being aware of
it?

/Bruce
  

On 2023/2/8 22:17, Bruce Richardson wrote:
> On Fri, Jan 20, 2023 at 03:34:51AM +0000, Chengwen Feng wrote:
>> This patchset contains dmadev/ethdev stats reset, and also support
>> hide zero for ethdev xstats and two telemetry related bugs.
>>
>> Chengwen Feng (5):
>>   dmadev: support stats reset telemetry command
>>   telemetry: fix repeat display when callback don't init dict
>>   ethdev: add newline to telemetry log string
>>   ethdev: support xstats reset telemetry command
>>   ethdev: telemetry xstats support hide zero
>>
> On one level, I can understand how this may be useful, but on the other
> side, we also support having multiple different clients connecting to
> telemetry simultaneously. Would it not be problematic to have stats
> suddenly being reset by one connection without the others being aware of
> it?

It's a problem. Anyone who can connect can execute the commands.
For this modify case, I suggest adding LOG for later refer. and will fix in V5.

Thanks.

> 
> /Bruce
> .
>