| Message ID | 20221214233346.391973-1-nicolas.chautru@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D9D9A0543; Thu, 15 Dec 2022 00:36:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C351840684; Thu, 15 Dec 2022 00:36:56 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id DC095400D6 for <dev@dpdk.org>; Thu, 15 Dec 2022 00:36:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671061015; x=1702597015; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XFyDYtkF7hnNu2uvF87+O0doss8Qy+8PcGgYPzjO+rY=; b=hsMJzUsBvGIMoGFOJuC/tZS5EeT+ni5+mK2ZriKIeQKRrOgSBvPU9Ese nZ0p3y3tqAmvpFeA0teKVsEsVrWuq6HpF6pbC6M7s8nu/mwJsaCRkBCSY E33HwJOGB8DrWuK8Eiy5Nl0lhqG0tYMT9QtGcsto2WxOx3VHRBxqurvpa Ll419DnohaJSaZKvuxvdopwoZFgDaFSHUaQ9UvtZ1Z1+0LBDQNT3FKwIp yTFZtNgtH5OP84VrgVNrmKRPrhuSr0rEYLS+i5UH2WjjoLdexwe/T7CT+ dhII1QM+SpEiUQ7JG5WXnxs1c5sM5Cqbi1uO+e9Tf2hZ4loOitGvmK70C g==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="306181657" X-IronPort-AV: E=Sophos;i="5.96,245,1665471600"; d="scan'208";a="306181657" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 15:36:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="626966006" X-IronPort-AV: E=Sophos;i="5.96,245,1665471600"; d="scan'208";a="626966006" Received: from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..) ([10.233.181.123]) by orsmga006.jf.intel.com with ESMTP; 14 Dec 2022 15:36:41 -0800 From: Nicolas Chautru <nicolas.chautru@intel.com> To: dev@dpdk.org, maxime.coquelin@redhat.com Cc: hernan.vargas@intel.com, Nicolas Chautru <nicolas.chautru@intel.com> Subject: [PATCH v1 0/3] bbdev: remove offload cost Date: Wed, 14 Dec 2022 23:33:43 +0000 Message-Id: <20221214233346.391973-1-nicolas.chautru@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series | bbdev: remove offload cost | |
Message
Chautru, Nicolas
Dec. 14, 2022, 11:33 p.m. UTC
Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel baseband PMDs and bbdev-test application. This helps to simplify build variants complexity causing compilation issues to be missed. Maxime, the first commit is actually a miss related to last commit on top of tree, you may want to merge these two commits together in the history. Sorry for missing it earlier. Nicolas Chautru (3): test/bbdev: explicit check for allocation failure drivers/baseband: remove offload cost optional build flag app/bbdev-test: remove offload cost optional build flag app/test-bbdev/test_bbdev_perf.c | 29 +------- drivers/baseband/acc/acc_common.h | 12 +--- drivers/baseband/acc/rte_acc100_pmd.c | 2 - drivers/baseband/acc/rte_acc200_pmd.c | 2 - .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- 7 files changed, 17 insertions(+), 118 deletions(-)
Comments
Hi Maxime, Happy new year. What does the state " Awaiting Upstream" mean in patchwork for that serie? Can this be applied? Thanks Nic > -----Original Message----- > From: Chautru, Nicolas <nicolas.chautru@intel.com> > Sent: Wednesday, December 14, 2022 3:34 PM > To: dev@dpdk.org; maxime.coquelin@redhat.com > Cc: Vargas, Hernan <hernan.vargas@intel.com>; Chautru, Nicolas > <nicolas.chautru@intel.com> > Subject: [PATCH v1 0/3] bbdev: remove offload cost > > Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel > baseband PMDs and bbdev-test application. > This helps to simplify build variants complexity causing compilation issues to > be missed. > > Maxime, the first commit is actually a miss related to last commit on top of > tree, you may want to merge these two commits together in the history. > Sorry for missing it earlier. > > > Nicolas Chautru (3): > test/bbdev: explicit check for allocation failure > drivers/baseband: remove offload cost optional build flag > app/bbdev-test: remove offload cost optional build flag > > app/test-bbdev/test_bbdev_perf.c | 29 +------- > drivers/baseband/acc/acc_common.h | 12 +--- > drivers/baseband/acc/rte_acc100_pmd.c | 2 - > drivers/baseband/acc/rte_acc200_pmd.c | 2 - > .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- > .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- > 7 files changed, 17 insertions(+), 118 deletions(-) > > -- > 2.34.1
Hi Nicolas, On 1/3/23 23:07, Chautru, Nicolas wrote: > Hi Maxime, > > Happy new year. Happy new year. > What does the state " Awaiting Upstream" mean in patchwork for that serie? Can this be applied? It means it is the the bbdev tree, and is awaiting being pulled into the main tree. So it is applied, but only in the bbdev tree for now. This should not be an issue since you shold base your work on top of the bbdev tree. Regards, Maxime > Thanks > Nic > > > >> -----Original Message----- >> From: Chautru, Nicolas <nicolas.chautru@intel.com> >> Sent: Wednesday, December 14, 2022 3:34 PM >> To: dev@dpdk.org; maxime.coquelin@redhat.com >> Cc: Vargas, Hernan <hernan.vargas@intel.com>; Chautru, Nicolas >> <nicolas.chautru@intel.com> >> Subject: [PATCH v1 0/3] bbdev: remove offload cost >> >> Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel >> baseband PMDs and bbdev-test application. >> This helps to simplify build variants complexity causing compilation issues to >> be missed. >> >> Maxime, the first commit is actually a miss related to last commit on top of >> tree, you may want to merge these two commits together in the history. >> Sorry for missing it earlier. >> >> >> Nicolas Chautru (3): >> test/bbdev: explicit check for allocation failure >> drivers/baseband: remove offload cost optional build flag >> app/bbdev-test: remove offload cost optional build flag >> >> app/test-bbdev/test_bbdev_perf.c | 29 +------- >> drivers/baseband/acc/acc_common.h | 12 +--- >> drivers/baseband/acc/rte_acc100_pmd.c | 2 - >> drivers/baseband/acc/rte_acc200_pmd.c | 2 - >> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- >> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- >> .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- >> 7 files changed, 17 insertions(+), 118 deletions(-) >> >> -- >> 2.34.1 >
Hi Maxime, I don’t see them on the baseband tree dpdk-next-baseband I did a clean clone, these are the last 3 commits dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check for allocation failure 0e927787a3 test/bbdev: fix build issue with optional build flag 51d49ccd23 test/bbdev: fix build issue with optional build flag I don’t see the last 3 commits from patchwork (ie. the serie from that email) [v1,3/3] app/bbdev-test: remove offload cost optional build flag bbdev: remove offload cost - - - 3-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream [v1,2/3] drivers/baseband: remove offload cost optional build flag bbdev: remove offload cost - - - 1-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream [v1,1/3] test/bbdev: explicit check for allocation failure bbdev: remove offload cost - - - 11- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream [v3,3/3] test/bbdev: explicit check for allocation failure test/bbdev: fix build issues with optional build flag - 1 - 10-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream [v3,2/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 1-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream [v3,1/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 11- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream Do I miss something? This last serie doesn’t look applied on the remote repo. Could you double check? Thanks Nic > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Wednesday, January 4, 2023 4:43 AM > To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org > Cc: Vargas, Hernan <hernan.vargas@intel.com> > Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost > > Hi Nicolas, > > On 1/3/23 23:07, Chautru, Nicolas wrote: > > Hi Maxime, > > > > Happy new year. > > Happy new year. > > > What does the state " Awaiting Upstream" mean in patchwork for that > serie? Can this be applied? > > It means it is the the bbdev tree, and is awaiting being pulled into the main > tree. > > So it is applied, but only in the bbdev tree for now. > This should not be an issue since you shold base your work on top of the > bbdev tree. > > Regards, > Maxime > > > Thanks > > Nic > > > > > > > >> -----Original Message----- > >> From: Chautru, Nicolas <nicolas.chautru@intel.com> > >> Sent: Wednesday, December 14, 2022 3:34 PM > >> To: dev@dpdk.org; maxime.coquelin@redhat.com > >> Cc: Vargas, Hernan <hernan.vargas@intel.com>; Chautru, Nicolas > >> <nicolas.chautru@intel.com> > >> Subject: [PATCH v1 0/3] bbdev: remove offload cost > >> > >> Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel > >> baseband PMDs and bbdev-test application. > >> This helps to simplify build variants complexity causing compilation > >> issues to be missed. > >> > >> Maxime, the first commit is actually a miss related to last commit on > >> top of tree, you may want to merge these two commits together in the > history. > >> Sorry for missing it earlier. > >> > >> > >> Nicolas Chautru (3): > >> test/bbdev: explicit check for allocation failure > >> drivers/baseband: remove offload cost optional build flag > >> app/bbdev-test: remove offload cost optional build flag > >> > >> app/test-bbdev/test_bbdev_perf.c | 29 +------- > >> drivers/baseband/acc/acc_common.h | 12 +--- > >> drivers/baseband/acc/rte_acc100_pmd.c | 2 - > >> drivers/baseband/acc/rte_acc200_pmd.c | 2 - > >> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- > >> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- > >> .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- > >> 7 files changed, 17 insertions(+), 118 deletions(-) > >> > >> -- > >> 2.34.1 > >
Hi Nicolas, On 1/4/23 19:01, Chautru, Nicolas wrote: > Hi Maxime, > > I don’t see them on the baseband tree dpdk-next-baseband > > I did a clean clone, these are the last 3 commits > dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check for allocation failure > 0e927787a3 test/bbdev: fix build issue with optional build flag > 51d49ccd23 test/bbdev: fix build issue with optional build flag > > I don’t see the last 3 commits from patchwork (ie. the serie from that email) > [v1,3/3] app/bbdev-test: remove offload cost optional build flag bbdev: remove offload cost - - - 3-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v1,2/3] drivers/baseband: remove offload cost optional build flag bbdev: remove offload cost - - - 1-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v1,1/3] test/bbdev: explicit check for allocation failure bbdev: remove offload cost - - - 11- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,3/3] test/bbdev: explicit check for allocation failure test/bbdev: fix build issues with optional build flag - 1 - 10-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,2/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 1-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,1/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 11- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > > Do I miss something? This last serie doesn’t look applied on the remote repo. Could you double check? Hmm OK, I think I got mislead by the similarity of the commit titles between the two series when I changed the state of the first series. I'm reverting back the state of this series from "Awaiting upstream" to "New" since I have not reviewed this one yet. I'll try to review it before end of week. Thanks for the heads-up! Maxime > Thanks > Nic > > >> -----Original Message----- >> From: Maxime Coquelin <maxime.coquelin@redhat.com> >> Sent: Wednesday, January 4, 2023 4:43 AM >> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org >> Cc: Vargas, Hernan <hernan.vargas@intel.com> >> Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost >> >> Hi Nicolas, >> >> On 1/3/23 23:07, Chautru, Nicolas wrote: >>> Hi Maxime, >>> >>> Happy new year. >> >> Happy new year. >> >>> What does the state " Awaiting Upstream" mean in patchwork for that >> serie? Can this be applied? >> >> It means it is the the bbdev tree, and is awaiting being pulled into the main >> tree. >> >> So it is applied, but only in the bbdev tree for now. >> This should not be an issue since you shold base your work on top of the >> bbdev tree. >> >> Regards, >> Maxime >> >>> Thanks >>> Nic >>> >>> >>> >>>> -----Original Message----- >>>> From: Chautru, Nicolas <nicolas.chautru@intel.com> >>>> Sent: Wednesday, December 14, 2022 3:34 PM >>>> To: dev@dpdk.org; maxime.coquelin@redhat.com >>>> Cc: Vargas, Hernan <hernan.vargas@intel.com>; Chautru, Nicolas >>>> <nicolas.chautru@intel.com> >>>> Subject: [PATCH v1 0/3] bbdev: remove offload cost >>>> >>>> Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel >>>> baseband PMDs and bbdev-test application. >>>> This helps to simplify build variants complexity causing compilation >>>> issues to be missed. >>>> >>>> Maxime, the first commit is actually a miss related to last commit on >>>> top of tree, you may want to merge these two commits together in the >> history. >>>> Sorry for missing it earlier. >>>> >>>> >>>> Nicolas Chautru (3): >>>> test/bbdev: explicit check for allocation failure >>>> drivers/baseband: remove offload cost optional build flag >>>> app/bbdev-test: remove offload cost optional build flag >>>> >>>> app/test-bbdev/test_bbdev_perf.c | 29 +------- >>>> drivers/baseband/acc/acc_common.h | 12 +--- >>>> drivers/baseband/acc/rte_acc100_pmd.c | 2 - >>>> drivers/baseband/acc/rte_acc200_pmd.c | 2 - >>>> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- >>>> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- >>>> .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- >>>> 7 files changed, 17 insertions(+), 118 deletions(-) >>>> >>>> -- >>>> 2.34.1 >>> >
On 12/15/22 00:33, Nicolas Chautru wrote: > Removing the optional build flag RTE_BBDEV_OFFLOAD_COST > from Intel baseband PMDs and bbdev-test application. > This helps to simplify build variants complexity > causing compilation issues to be missed. > > Maxime, the first commit is actually a miss related > to last commit on top of tree, you may want to merge > these two commits together in the history. > Sorry for missing it earlier. > > > Nicolas Chautru (3): > test/bbdev: explicit check for allocation failure > drivers/baseband: remove offload cost optional build flag > app/bbdev-test: remove offload cost optional build flag > > app/test-bbdev/test_bbdev_perf.c | 29 +------- > drivers/baseband/acc/acc_common.h | 12 +--- > drivers/baseband/acc/rte_acc100_pmd.c | 2 - > drivers/baseband/acc/rte_acc200_pmd.c | 2 - > .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- > .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- > 7 files changed, 17 insertions(+), 118 deletions(-) > Patch 1 squashed in: http://patches.dpdk.org/project/dpdk/patch/20221213161855.12970-4-nicolas.chautru@intel.com/ Patches 2 & 3 applied to dpdk-next-baseband/for-main. Thanks, Maxime