mbox series

[v10,0/8] app/procinfo: add some extended features

Message ID 20221011111843.3311-1-liudongdong3@huawei.com (mailing list archive)
Headers
Series app/procinfo: add some extended features |

Message

Dongdong Liu Oct. 11, 2022, 11:18 a.m. UTC
  This patchset is to add some extended features for dpdk-proc-info.

Thanks to Reshma and Stephen help to review the patchset.

v9->v10:
- Fix some comments for Rx/Tx descriptor dump.

v8->v9:
- Fixed some checkpatch warnings.

v7(v4)->v8:
- Add Acked-by: Reshma Pattan for PATCH 4,6.
- Add Rx/Tx descriptor dump.
- Adjust procinfo doc guide.

v3->v4:
- Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7.
- Rename show-module-info to show-module-eeprom to make more clear.

v2->v3: Fix some comments from Stephen.
- Use --version option for DPDK version.
- Add --firmware-version option to show firmware.
- Use errors on stderr, not stdout.
- Delete some unnecessary code.

v1->v2: Fix some comments from Reshma.

Dongdong Liu (4):
  app/procinfo: add firmware version dump
  app/procinfo: fix some wrong doxygen syntax
  app/procinfo: support descriptor dump
  doc: add some extended features in procinfo guide

Jie Hai (1):
  app/procinfo: add dump of Rx/Tx burst mode

Min Hu (Connor) (3):
  app/procinfo: add dpdk version dump
  app/procinfo: add RSS RETA dump
  app/procinfo: add module eeprom info dump

 app/proc-info/main.c           | 324 ++++++++++++++++++++++++++++++---
 doc/guides/tools/proc_info.rst |  36 +++-
 2 files changed, 336 insertions(+), 24 deletions(-)

--
2.22.0
  

Comments

Dongdong Liu Oct. 20, 2022, 7:48 a.m. UTC | #1
Hi Thomas

Could you have a look at the patchset?

Thanks,
Dongdong
On 2022/10/11 19:18, Dongdong Liu wrote:
> This patchset is to add some extended features for dpdk-proc-info.
>
> Thanks to Reshma and Stephen help to review the patchset.
>
> v9->v10:
> - Fix some comments for Rx/Tx descriptor dump.
>
> v8->v9:
> - Fixed some checkpatch warnings.
>
> v7(v4)->v8:
> - Add Acked-by: Reshma Pattan for PATCH 4,6.
> - Add Rx/Tx descriptor dump.
> - Adjust procinfo doc guide.
>
> v3->v4:
> - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7.
> - Rename show-module-info to show-module-eeprom to make more clear.
>
> v2->v3: Fix some comments from Stephen.
> - Use --version option for DPDK version.
> - Add --firmware-version option to show firmware.
> - Use errors on stderr, not stdout.
> - Delete some unnecessary code.
>
> v1->v2: Fix some comments from Reshma.
>
> Dongdong Liu (4):
>   app/procinfo: add firmware version dump
>   app/procinfo: fix some wrong doxygen syntax
>   app/procinfo: support descriptor dump
>   doc: add some extended features in procinfo guide
>
> Jie Hai (1):
>   app/procinfo: add dump of Rx/Tx burst mode
>
> Min Hu (Connor) (3):
>   app/procinfo: add dpdk version dump
>   app/procinfo: add RSS RETA dump
>   app/procinfo: add module eeprom info dump
>
>  app/proc-info/main.c           | 324 ++++++++++++++++++++++++++++++---
>  doc/guides/tools/proc_info.rst |  36 +++-
>  2 files changed, 336 insertions(+), 24 deletions(-)
>
> --
> 2.22.0
>
> .
>
  
Dongdong Liu Nov. 4, 2022, 9:16 a.m. UTC | #2
Hi Thomas

Kindly ping.
Can this patchset be applied?

Thanks,
Dongdong
On 2022/10/11 19:18, Dongdong Liu wrote:
> This patchset is to add some extended features for dpdk-proc-info.
>
> Thanks to Reshma and Stephen help to review the patchset.
>
> v9->v10:
> - Fix some comments for Rx/Tx descriptor dump.
>
> v8->v9:
> - Fixed some checkpatch warnings.
>
> v7(v4)->v8:
> - Add Acked-by: Reshma Pattan for PATCH 4,6.
> - Add Rx/Tx descriptor dump.
> - Adjust procinfo doc guide.
>
> v3->v4:
> - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7.
> - Rename show-module-info to show-module-eeprom to make more clear.
>
> v2->v3: Fix some comments from Stephen.
> - Use --version option for DPDK version.
> - Add --firmware-version option to show firmware.
> - Use errors on stderr, not stdout.
> - Delete some unnecessary code.
>
> v1->v2: Fix some comments from Reshma.
>
> Dongdong Liu (4):
>   app/procinfo: add firmware version dump
>   app/procinfo: fix some wrong doxygen syntax
>   app/procinfo: support descriptor dump
>   doc: add some extended features in procinfo guide
>
> Jie Hai (1):
>   app/procinfo: add dump of Rx/Tx burst mode
>
> Min Hu (Connor) (3):
>   app/procinfo: add dpdk version dump
>   app/procinfo: add RSS RETA dump
>   app/procinfo: add module eeprom info dump
>
>  app/proc-info/main.c           | 324 ++++++++++++++++++++++++++++++---
>  doc/guides/tools/proc_info.rst |  36 +++-
>  2 files changed, 336 insertions(+), 24 deletions(-)
>
> --
> 2.22.0
>
> .
>
  
David Marchand Nov. 15, 2022, 9:52 a.m. UTC | #3
On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu <liudongdong3@huawei.com> wrote:
>
> This patchset is to add some extended features for dpdk-proc-info.
>
> Thanks to Reshma and Stephen help to review the patchset.
>
> v9->v10:
> - Fix some comments for Rx/Tx descriptor dump.
>
> v8->v9:
> - Fixed some checkpatch warnings.
>
> v7(v4)->v8:
> - Add Acked-by: Reshma Pattan for PATCH 4,6.
> - Add Rx/Tx descriptor dump.
> - Adjust procinfo doc guide.
>
> v3->v4:
> - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7.
> - Rename show-module-info to show-module-eeprom to make more clear.
>
> v2->v3: Fix some comments from Stephen.
> - Use --version option for DPDK version.
> - Add --firmware-version option to show firmware.
> - Use errors on stderr, not stdout.
> - Delete some unnecessary code.
>
> v1->v2: Fix some comments from Reshma.
>
> Dongdong Liu (4):
>   app/procinfo: add firmware version dump
>   app/procinfo: fix some wrong doxygen syntax
>   app/procinfo: support descriptor dump
>   doc: add some extended features in procinfo guide
>
> Jie Hai (1):
>   app/procinfo: add dump of Rx/Tx burst mode
>
> Min Hu (Connor) (3):
>   app/procinfo: add dpdk version dump
>   app/procinfo: add RSS RETA dump
>   app/procinfo: add module eeprom info dump
>
>  app/proc-info/main.c           | 324 ++++++++++++++++++++++++++++++---
>  doc/guides/tools/proc_info.rst |  36 +++-
>  2 files changed, 336 insertions(+), 24 deletions(-)

The last patch was a mix of various changes in the documentation.
Please make sure to update the documentation as part of the code
changes, in the future.
And separate fixes with proper Fixes: tag from other changes.

Series applied, thanks.
  
Dongdong Liu Nov. 15, 2022, 11 a.m. UTC | #4
On 2022/11/15 17:52, David Marchand wrote:
> On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu <liudongdong3@huawei.com> wrote:
>>
>> This patchset is to add some extended features for dpdk-proc-info.
>>
>> Thanks to Reshma and Stephen help to review the patchset.
>>
>> v9->v10:
>> - Fix some comments for Rx/Tx descriptor dump.
>>
>> v8->v9:
>> - Fixed some checkpatch warnings.
>>
>> v7(v4)->v8:
>> - Add Acked-by: Reshma Pattan for PATCH 4,6.
>> - Add Rx/Tx descriptor dump.
>> - Adjust procinfo doc guide.
>>
>> v3->v4:
>> - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7.
>> - Rename show-module-info to show-module-eeprom to make more clear.
>>
>> v2->v3: Fix some comments from Stephen.
>> - Use --version option for DPDK version.
>> - Add --firmware-version option to show firmware.
>> - Use errors on stderr, not stdout.
>> - Delete some unnecessary code.
>>
>> v1->v2: Fix some comments from Reshma.
>>
>> Dongdong Liu (4):
>>   app/procinfo: add firmware version dump
>>   app/procinfo: fix some wrong doxygen syntax
>>   app/procinfo: support descriptor dump
>>   doc: add some extended features in procinfo guide
>>
>> Jie Hai (1):
>>   app/procinfo: add dump of Rx/Tx burst mode
>>
>> Min Hu (Connor) (3):
>>   app/procinfo: add dpdk version dump
>>   app/procinfo: add RSS RETA dump
>>   app/procinfo: add module eeprom info dump
>>
>>  app/proc-info/main.c           | 324 ++++++++++++++++++++++++++++++---
>>  doc/guides/tools/proc_info.rst |  36 +++-
>>  2 files changed, 336 insertions(+), 24 deletions(-)
>
> The last patch was a mix of various changes in the documentation.
> Please make sure to update the documentation as part of the code
> changes, in the future.
> And separate fixes with proper Fixes: tag from other changes.
Thanks for pointing this and helping to fix.
>
> Series applied, thanks.
Many thanks for the work.

Thanks,
Dongdong.
>