mbox series

[v5,0/3] support ethdev Rx/Tx descriptor dump

Message ID 20221006120514.28830-1-liudongdong3@huawei.com (mailing list archive)
Headers show
Series support ethdev Rx/Tx descriptor dump | expand

Message

Dongdong Liu Oct. 6, 2022, 12:05 p.m. UTC 
Support ethdev Rx/Tx descriptor dump by using procinfo tool.

Thanks to Ferruh, Andrew and Reshma help to review the patchset.

NOTE:
October 1st to October 7th is China's National Day holiday.
I don't have a test environment available at the moment.
I will test this patchset on October 8th.  Current compile is ok.

v4->v5:
- Rename the Rx/Tx descriptor dump API and provide 'offset' parameter.
- Refactor procinfo dump descriptor code as Reshma suggested.

v3->v4:
- Modify the desc dump API to dump specified number of descriptors.
- Modify the hn3 pmd implementation and procinfo part

Dongdong Liu (3):
  ethdev: introduce ethdev desc dump API
  net/hns3: support Rx/Tx bd dump
  app/procinfo: support descriptor dump

 app/proc-info/main.c                   | 80 +++++++++++++++++++++++
 doc/guides/rel_notes/release_22_11.rst |  6 ++
 drivers/net/hns3/hns3_dump.c           | 88 ++++++++++++++++++++++++++
 drivers/net/hns3/hns3_dump.h           |  5 ++
 drivers/net/hns3/hns3_ethdev.c         |  2 +
 drivers/net/hns3/hns3_ethdev_vf.c      |  2 +
 lib/ethdev/ethdev_driver.h             | 53 ++++++++++++++++
 lib/ethdev/rte_ethdev.c                | 52 +++++++++++++++
 lib/ethdev/rte_ethdev.h                | 55 ++++++++++++++++
 lib/ethdev/version.map                 |  2 +
 10 files changed, 345 insertions(+)

--
2.22.0

Comments

Ferruh Yigit Oct. 6, 2022, 4:42 p.m. UTC | #1 
On 10/6/2022 1:05 PM, Dongdong Liu wrote:
> Support ethdev Rx/Tx descriptor dump by using procinfo tool.
> 
> Thanks to Ferruh, Andrew and Reshma help to review the patchset.
> 
> NOTE:
> October 1st to October 7th is China's National Day holiday.
> I don't have a test environment available at the moment.
> I will test this patchset on October 8th.  Current compile is ok.
> 
> v4->v5:
> - Rename the Rx/Tx descriptor dump API and provide 'offset' parameter.
> - Refactor procinfo dump descriptor code as Reshma suggested.
> 
> v3->v4:
> - Modify the desc dump API to dump specified number of descriptors.
> - Modify the hn3 pmd implementation and procinfo part
> 
> Dongdong Liu (3):
>    ethdev: introduce ethdev desc dump API
>    net/hns3: support Rx/Tx bd dump
>    app/procinfo: support descriptor dump
> 

I will wait review from Reshma for procinfo, but will merge rest to make 
them available for -rc1, procinfo can get after -rc1,

Except from procinfo patch, 3/3,
Series applied to dpdk-next-net/main, thanks.


Release notes and .map file order updated while merging.
Dongdong Liu Oct. 8, 2022, 11:11 a.m. UTC | #2 
On 2022/10/7 0:42, Ferruh Yigit wrote:
> On 10/6/2022 1:05 PM, Dongdong Liu wrote:
>> Support ethdev Rx/Tx descriptor dump by using procinfo tool.
>>
>> Thanks to Ferruh, Andrew and Reshma help to review the patchset.
>>
>> NOTE:
>> October 1st to October 7th is China's National Day holiday.
>> I don't have a test environment available at the moment.
>> I will test this patchset on October 8th.  Current compile is ok.
I have tested the patchset and it works ok.
>>
>> v4->v5:
>> - Rename the Rx/Tx descriptor dump API and provide 'offset' parameter.
>> - Refactor procinfo dump descriptor code as Reshma suggested.
>>
>> v3->v4:
>> - Modify the desc dump API to dump specified number of descriptors.
>> - Modify the hn3 pmd implementation and procinfo part
>>
>> Dongdong Liu (3):
>>    ethdev: introduce ethdev desc dump API
>>    net/hns3: support Rx/Tx bd dump
>>    app/procinfo: support descriptor dump
>>
>
> I will wait review from Reshma for procinfo, but will merge rest to make
> them available for -rc1, procinfo can get after -rc1,
>
> Except from procinfo patch, 3/3,
> Series applied to dpdk-next-net/main, thanks.
>
>
> Release notes and .map file order updated while merging.
Thanks for the work.

I have sent out the below patchset for the procinfo.

[PATCH v9 0/8] app/procinfo: add some extended features
https://patches.dpdk.org/project/dpdk/list/?series=25048

[v9,7/8] app/procinfo: support descriptor dump
https://patches.dpdk.org/project/dpdk/patch/20221008105353.18195-8-liudongdong3@huawei.com/

Thanks,
Dongdong.
>
> .
>