mbox series

[RFT,0/2] pie: floating point fixes

Message ID 20220524184623.480646-1-stephen@networkplumber.org (mailing list archive)
Headers
Series pie: floating point fixes |

Message

Stephen Hemminger May 24, 2022, 6:46 p.m. UTC 
  A couple of small untested changes to address some
issues found while reviewing usage of random in DPDK.

The PIE code should get rexamined in later release.
It should not be exposing internal algorithm, that makes
it brittle for ABI.

Also, no code in DPDK should ever be doing floating point
math in the data path!

Stephen Hemminger (2):
  rte_pie: remove unnecessary floating point
  rte_pie: fix incorrect floating point math

 lib/sched/rte_pie.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Morten Brørup May 24, 2022, 7:31 p.m. UTC | #1 
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, 24 May 2022 20.46
> 
> A couple of small untested changes to address some
> issues found while reviewing usage of random in DPDK.
> 
> The PIE code should get rexamined in later release.

Untested fixes to seemingly untested code. What's not to like? ;-)

> It should not be exposing internal algorithm, that makes
> it brittle for ABI.

Agree. Just look at the mempool... an increasing amount of its internals are getting elevated to public API, so other code can understand and use its internals instead of going through its API. (My current pet peeve.)

> 
> Also, no code in DPDK should ever be doing floating point
> math in the data path!

+1

> 
> Stephen Hemminger (2):
>   rte_pie: remove unnecessary floating point
>   rte_pie: fix incorrect floating point math

This looks much better than what it replaces, so...

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>