mbox series

[v5,0/2] Verify C++ compatibility of public headers

Message ID 20220211113641.755308-1-bruce.richardson@intel.com (mailing list archive)
Headers
Series Verify C++ compatibility of public headers |

Message

Bruce Richardson Feb. 11, 2022, 11:36 a.m. UTC 
  NOTE: despite significant differences in patchset, submitting this as v5
to keep history and threading rather than as new v1

This patchset expands upon the exiting chkincs infrastructure to build a
C++ test application as well as the existing C test app, which helps
catch any build errors when the public DPDK headers are included in C++
code.

V5:
* Dropped first 6 patches which contained fixes now already applied.
* Added new patch to slim-down the linkage of existing chkincs binary
* New patch to add CPP checks also only does mimimal linkage

V4:
* add g++-multilib to packages to install for github checks to ensure 32-bit
  builds work
* correct the fixline for patch 1
* add extra cpp_args and cpp_link_args for 32-bit builds in test-meson-builds
  so that includes checks can pass there if enabled.

V3:
* update linux-build script to have cpp_args=-m32 for 32-bit builds

V2:
* Changed patch 6 to have a minimally-invasive fix for C++ without
  affecting existing C code.
* Added fixlines and Cc stable for all patches which are fixes

Bruce Richardson (2):
  buildtools/chkincs: remove unnecesary linkage
  buildtools/chkincs: test headers for C++ compatibility

 .ci/linux-build.sh             |  1 +
 .github/workflows/build.yml    |  2 +-
 buildtools/chkincs/main.cpp    |  4 ++++
 buildtools/chkincs/meson.build | 21 +++++++++++++++++++--
 devtools/test-meson-builds.sh  |  3 ++-
 5 files changed, 27 insertions(+), 4 deletions(-)
 create mode 100644 buildtools/chkincs/main.cpp

--
2.32.0

Comments

Thomas Monjalon Feb. 12, 2022, 1:27 p.m. UTC | #1 
11/02/2022 12:36, Bruce Richardson:
> NOTE: despite significant differences in patchset, submitting this as v5
> to keep history and threading rather than as new v1
> 
> This patchset expands upon the exiting chkincs infrastructure to build a
> C++ test application as well as the existing C test app, which helps
> catch any build errors when the public DPDK headers are included in C++
> code.
> 
> V5:
> * Dropped first 6 patches which contained fixes now already applied.
> * Added new patch to slim-down the linkage of existing chkincs binary
> * New patch to add CPP checks also only does mimimal linkage

This version works fine in my environment.
Applied, thanks.