[v4,0/6] support L2TPv2 for AVF RSS hash and FDIR

  Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow
director. Required to distribute packets based on outer MAC src
address and L2TPv2 session ID.

Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute
packets based on inner IP src+dest address and TCP/UDP src+dest port.

---
v4:
 * update new macros in ethdev.
 * update commit log.
 * rebase the main branch code.
v3:
 * update new macros in ethdev.
 * update commit log.
 * rebase the main branch code.
v2:
 * upadte release notes.
 * add comment for RTE_ETH_RSS_L2TPV2.
 * update ipv6 l2tpv2 flow item.
 * rebase the main branch code.

Jie Wang (6):
  ethdev: add L2TPv2 RSS offload type
  net: fix L2TPv2 common header
  app/testpmd: add 6 types of L2TPv2 message
  common/iavf: add session ID fields for L2TPv2
  net/iavf: support L2TPv2 for AVF HASH
  net/iavf: support L2TPv2 for AVF FDIR

 app/test-pmd/cmdline.c                 |  10 +-
 app/test-pmd/cmdline_flow.c            | 313 +++++++++++++++++++++----
 app/test-pmd/config.c                  |   3 +-
 doc/guides/rel_notes/release_22_03.rst |  15 ++
 drivers/common/iavf/virtchnl.h         |   4 +
 drivers/net/iavf/iavf.h                |   2 +
 drivers/net/iavf/iavf_fdir.c           | 174 +++++++++++---
 drivers/net/iavf/iavf_generic_flow.c   |  34 +++
 drivers/net/iavf/iavf_generic_flow.h   |  10 +
 drivers/net/iavf/iavf_hash.c           |  83 ++++++-
 lib/ethdev/rte_ethdev.h                |   6 +
 lib/net/rte_l2tpv2.h                   |  33 ++-
 12 files changed, 589 insertions(+), 98 deletions(-)
  

On 2/8/2022 8:38 AM, Jie Wang wrote:
> Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow
> director. Required to distribute packets based on outer MAC src
> address and L2TPv2 session ID.
> 
> Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute
> packets based on inner IP src+dest address and TCP/UDP src+dest port.
> 
> ---
> v4:
>   * update new macros in ethdev.
>   * update commit log.
>   * rebase the main branch code.
> v3:
>   * update new macros in ethdev.
>   * update commit log.
>   * rebase the main branch code.
> v2:
>   * upadte release notes.
>   * add comment for RTE_ETH_RSS_L2TPV2.
>   * update ipv6 l2tpv2 flow item.
>   * rebase the main branch code.
> 
> Jie Wang (6):
>    ethdev: add L2TPv2 RSS offload type
>    net: fix L2TPv2 common header
>    app/testpmd: add 6 types of L2TPv2 message
>    common/iavf: add session ID fields for L2TPv2
>    net/iavf: support L2TPv2 for AVF HASH
>    net/iavf: support L2TPv2 for AVF FDIR
> 

Hi Jie, Qi,

Can you please make iavf patches reviewed, so the set can be merged as whole,
or driver changes will block the ethdev changes.
  

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, February 8, 2022 10:45 PM
> To: Wang, Jie1X <jie1x.wang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Yang, SteveX <stevex.yang@intel.com>; orika@nvidia.com; Singh, Aman
> Deep <aman.deep.singh@intel.com>; thomas@monjalon.net;
> andrew.rybchenko@oktetlabs.ru; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; olivier.matz@6wind.com
> Subject: Re: [PATCH v4 0/6] support L2TPv2 for AVF RSS hash and FDIR
> 
> On 2/8/2022 8:38 AM, Jie Wang wrote:
> > Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow
> > director. Required to distribute packets based on outer MAC src
> > address and L2TPv2 session ID.
> >
> > Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute
> > packets based on inner IP src+dest address and TCP/UDP src+dest port.
> >
> > ---
> > v4:
> >   * update new macros in ethdev.
> >   * update commit log.
> >   * rebase the main branch code.
> > v3:
> >   * update new macros in ethdev.
> >   * update commit log.
> >   * rebase the main branch code.
> > v2:
> >   * upadte release notes.
> >   * add comment for RTE_ETH_RSS_L2TPV2.
> >   * update ipv6 l2tpv2 flow item.
> >   * rebase the main branch code.
> >
> > Jie Wang (6):
> >    ethdev: add L2TPv2 RSS offload type
> >    net: fix L2TPv2 common header
> >    app/testpmd: add 6 types of L2TPv2 message
> >    common/iavf: add session ID fields for L2TPv2
> >    net/iavf: support L2TPv2 for AVF HASH
> >    net/iavf: support L2TPv2 for AVF FDIR
> >
> 
> Hi Jie, Qi,
> 
> Can you please make iavf patches reviewed, so the set can be merged as
> whole, or driver changes will block the ethdev changes.

Hi Ferruh:

The pmd part overall looks ok for me, but still need some rework, I think it should not block the part of ethdev merge, if we are close to deadline.

Thanks
Qi