mbox series

[v3,0/4] ethdev: introduce IP reassembly offload

Message ID 20220130175935.1947730-1-gakhil@marvell.com (mailing list archive)
Headers
Series ethdev: introduce IP reassembly offload |

Message

Akhil Goyal Jan. 30, 2022, 5:59 p.m. UTC
  As discussed in the RFC[1] sent in 21.11, a new offload is
introduced in ethdev for IP reassembly.

This patchset add the IP reassembly RX offload.
Currently, the offload is tested along with inline IPsec processing.
It can also be updated as a standalone offload without IPsec, if there
are some hardware available to test it.
The patchset is tested on cnxk platform. The driver implementation
and a test app are added as separate patchsets.

[1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/

changes in v3:
- incorporated comments from Andrew and Stephen Hemminger

changes in v2:
- added abi ignore exceptions for modifications in reserved fields.
  Added a crude way to subside the rte_security and rte_ipsec ABI issue.
  Please suggest a better way.
- incorporated Konstantin's comment for extra checks in new API
  introduced.
- converted static mbuf ol_flag to mbuf dynflag (Konstantin)
- added a get API for reassembly configuration (Konstantin)
- Fixed checkpatch issues.
- Dynfield is NOT split into 2 parts as it would cause an extra fetch in
  case of IP reassembly failure.
- Application patches are split into a separate series.


Akhil Goyal (4):
  ethdev: introduce IP reassembly offload
  ethdev: add dev op to set/get IP reassembly configuration
  ethdev: add mbuf dynfield for incomplete IP reassembly
  security: add IPsec option for IP reassembly

 devtools/libabigail.abignore |  19 ++++++
 doc/guides/nics/features.rst |  12 ++++
 lib/ethdev/ethdev_driver.h   |  45 +++++++++++++++
 lib/ethdev/rte_ethdev.c      | 109 +++++++++++++++++++++++++++++++++++
 lib/ethdev/rte_ethdev.h      | 100 +++++++++++++++++++++++++++++++-
 lib/ethdev/version.map       |   5 ++
 lib/security/rte_security.h  |  12 +++-
 7 files changed, 300 insertions(+), 2 deletions(-)
  

Comments

Ferruh Yigit Feb. 1, 2022, 2:10 p.m. UTC | #1
On 1/30/2022 5:59 PM, Akhil Goyal wrote:
> As discussed in the RFC[1] sent in 21.11, a new offload is
> introduced in ethdev for IP reassembly.
> 
> This patchset add the IP reassembly RX offload.
> Currently, the offload is tested along with inline IPsec processing.
> It can also be updated as a standalone offload without IPsec, if there
> are some hardware available to test it.
> The patchset is tested on cnxk platform. The driver implementation
> and a test app are added as separate patchsets.> 

Can you please share the links of those sets?

> [1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/
> 
> changes in v3:
> - incorporated comments from Andrew and Stephen Hemminger
> 
> changes in v2:
> - added abi ignore exceptions for modifications in reserved fields.
>    Added a crude way to subside the rte_security and rte_ipsec ABI issue.
>    Please suggest a better way.
> - incorporated Konstantin's comment for extra checks in new API
>    introduced.
> - converted static mbuf ol_flag to mbuf dynflag (Konstantin)
> - added a get API for reassembly configuration (Konstantin)
> - Fixed checkpatch issues.
> - Dynfield is NOT split into 2 parts as it would cause an extra fetch in
>    case of IP reassembly failure.
> - Application patches are split into a separate series.
> 
> 
> Akhil Goyal (4):
>    ethdev: introduce IP reassembly offload
>    ethdev: add dev op to set/get IP reassembly configuration
>    ethdev: add mbuf dynfield for incomplete IP reassembly
>    security: add IPsec option for IP reassembly
> 
>   devtools/libabigail.abignore |  19 ++++++
>   doc/guides/nics/features.rst |  12 ++++
>   lib/ethdev/ethdev_driver.h   |  45 +++++++++++++++
>   lib/ethdev/rte_ethdev.c      | 109 +++++++++++++++++++++++++++++++++++
>   lib/ethdev/rte_ethdev.h      | 100 +++++++++++++++++++++++++++++++-
>   lib/ethdev/version.map       |   5 ++
>   lib/security/rte_security.h  |  12 +++-
>   7 files changed, 300 insertions(+), 2 deletions(-)
>
  
Akhil Goyal Feb. 2, 2022, 9:05 a.m. UTC | #2
> On 1/30/2022 5:59 PM, Akhil Goyal wrote:
> > As discussed in the RFC[1] sent in 21.11, a new offload is
> > introduced in ethdev for IP reassembly.
> >
> > This patchset add the IP reassembly RX offload.
> > Currently, the offload is tested along with inline IPsec processing.
> > It can also be updated as a standalone offload without IPsec, if there
> > are some hardware available to test it.
> > The patchset is tested on cnxk platform. The driver implementation
> > and a test app are added as separate patchsets.>
> 
> Can you please share the links of those sets?

APP: http://patches.dpdk.org/project/dpdk/list/?series=21284
PMD: http://patches.dpdk.org/project/dpdk/list/?series=21285