mbox series

[v2,0/9] net/mlx5: add flex item support

Message ID 20211102085347.20568-1-getelson@nvidia.com (mailing list archive)
Headers
Series net/mlx5: add flex item support |

Message

Gregory Etelson Nov. 2, 2021, 8:53 a.m. UTC 
  Gregory Etelson (4):
  common/mlx5: extend flex parser capabilities
  common/mlx5: fix flex parser DevX creation routine
  net/mlx5: add flex parser DevX object management
  net/mlx5: handle flex item in flows

Viacheslav Ovsiienko (5):
  common/mlx5: refactor HCA attributes query
  net/mlx5: update eCPRI flex parser structures
  net/mlx5: add flex item API
  net/mlx5: translate flex item configuration
  net/mlx5: translate flex item pattern into matcher

 drivers/common/mlx5/mlx5_devx_cmds.c |  239 +++--
 drivers/common/mlx5/mlx5_devx_cmds.h |   65 +-
 drivers/common/mlx5/mlx5_prm.h       |   50 +-
 drivers/net/mlx5/linux/mlx5_os.c     |   14 +
 drivers/net/mlx5/meson.build         |    1 +
 drivers/net/mlx5/mlx5.c              |   15 +-
 drivers/net/mlx5/mlx5.h              |   79 +-
 drivers/net/mlx5/mlx5_flow.c         |   49 +
 drivers/net/mlx5/mlx5_flow.h         |   27 +-
 drivers/net/mlx5/mlx5_flow_dv.c      |  127 ++-
 drivers/net/mlx5/mlx5_flow_flex.c    | 1373 ++++++++++++++++++++++++++
 11 files changed, 1913 insertions(+), 126 deletions(-)
 create mode 100644 drivers/net/mlx5/mlx5_flow_flex.c

Comments

Raslan Darawsheh Nov. 3, 2021, 12:57 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Gregory Etelson
> Sent: Tuesday, November 2, 2021 10:54 AM
> To: dev@dpdk.org; Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: Matan Azrad <matan@nvidia.com>
> Subject: [dpdk-dev] [PATCH v2 0/9] net/mlx5: add flex item support
> 
> Gregory Etelson (4):
>   common/mlx5: extend flex parser capabilities
>   common/mlx5: fix flex parser DevX creation routine
>   net/mlx5: add flex parser DevX object management
>   net/mlx5: handle flex item in flows
> 
> Viacheslav Ovsiienko (5):
>   common/mlx5: refactor HCA attributes query
>   net/mlx5: update eCPRI flex parser structures
>   net/mlx5: add flex item API
>   net/mlx5: translate flex item configuration
>   net/mlx5: translate flex item pattern into matcher
> 
>  drivers/common/mlx5/mlx5_devx_cmds.c |  239 +++--
>  drivers/common/mlx5/mlx5_devx_cmds.h |   65 +-
>  drivers/common/mlx5/mlx5_prm.h       |   50 +-
>  drivers/net/mlx5/linux/mlx5_os.c     |   14 +
>  drivers/net/mlx5/meson.build         |    1 +
>  drivers/net/mlx5/mlx5.c              |   15 +-
>  drivers/net/mlx5/mlx5.h              |   79 +-
>  drivers/net/mlx5/mlx5_flow.c         |   49 +
>  drivers/net/mlx5/mlx5_flow.h         |   27 +-
>  drivers/net/mlx5/mlx5_flow_dv.c      |  127 ++-
>  drivers/net/mlx5/mlx5_flow_flex.c    | 1373
> ++++++++++++++++++++++++++
>  11 files changed, 1913 insertions(+), 126 deletions(-)  create mode 100644
> drivers/net/mlx5/mlx5_flow_flex.c
> 
> --
> v2: rebase to updated master-net-mlx.
> --
> 2.33.1

Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
Ferruh Yigit Nov. 3, 2021, 6:24 p.m. UTC | #2 
On 11/2/2021 8:53 AM, Gregory Etelson wrote:
> Gregory Etelson (4):
>    common/mlx5: extend flex parser capabilities
>    common/mlx5: fix flex parser DevX creation routine
>    net/mlx5: add flex parser DevX object management
>    net/mlx5: handle flex item in flows
> 
> Viacheslav Ovsiienko (5):
>    common/mlx5: refactor HCA attributes query
>    net/mlx5: update eCPRI flex parser structures
>    net/mlx5: add flex item API
>    net/mlx5: translate flex item configuration
>    net/mlx5: translate flex item pattern into matcher
> 

Hi Gregory,

Can you please check following doc error [1] and build error [2]:

[1]
$ ./devtools/check-doc-vs-code.sh
rte_flow doc out of sync for mlx5
         item flex



[2]
                  from ../lib/eal/x86/include/rte_rwlock.h:13,
                  from ../lib/eal/include/rte_fbarray.h:40,
                  from ../lib/eal/include/rte_memory.h:25,
                  from ../lib/eal/include/rte_malloc.h:17,
                  from ../drivers/net/mlx5/mlx5_flow_flex.c:4:
../drivers/net/mlx5/mlx5_flow_flex.c: In function ‘mlx5_flex_flow_translate_item’:
../drivers/net/mlx5/mlx5_flow_flex.c:240:37: error: ‘priv’ undeclared (first use in this function)
   240 |         MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0);
       |                                     ^~~~
../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’
    38 | #define unlikely(x)     __builtin_expect(!!(x), 0)
       |                                             ^
../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’
    47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp)
       |                         ^~~~~~~~~~
../drivers/common/mlx5/mlx5_common.h:104:26: note: in expansion of macro ‘RTE_ASSERT’
   104 | #define MLX5_ASSERT(exp) RTE_ASSERT(exp)
       |                          ^~~~~~~~~~
../drivers/net/mlx5/mlx5_flow_flex.c:240:9: note: in expansion of macro ‘MLX5_ASSERT’
   240 |         MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0);
       |         ^~~~~~~~~~~
../drivers/net/mlx5/mlx5_flow_flex.c:240:37: note: each undeclared identifier is reported only once for each function it appears in
   240 |         MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0);
       |                                     ^~~~
../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’
    38 | #define unlikely(x)     __builtin_expect(!!(x), 0)
       |                                             ^
../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’
    47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp)
       |                         ^~~~~~~~~~
../drivers/common/mlx5/mlx5_common.h:104:26: note: in expansion of macro ‘RTE_ASSERT’
   104 | #define MLX5_ASSERT(exp) RTE_ASSERT(exp)
       |                          ^~~~~~~~~~
../drivers/net/mlx5/mlx5_flow_flex.c:240:9: note: in expansion of macro ‘MLX5_ASSERT’
   240 |         MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0);
       |         ^~~~~~~~~~~