mbox series

[v9,0/4] enable protocol agnostic flow offloading in FDIR

Message ID 20211102053918.4063391-1-junfeng.guo@intel.com (mailing list archive)
Headers
Series enable protocol agnostic flow offloading in FDIR |

Message

Junfeng Guo Nov. 2, 2021, 5:39 a.m. UTC
  Protocol agnostic flow offloading in Flow Director is enabled by this
patch set based on the Parser Library using existing rte_flow raw API.

[PATCH v9 1/4] net/ice/base: add method to disable FDIR SWAP option.
[PATCH v9 2/4] net/ice/base: add function to set HW profile for raw flow.
[PATCH v9 3/4] app/testpmd: update Max RAW pattern size to 512.
[PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR.

Junfeng Guo (4):
  net/ice/base: add method to disable FDIR SWAP option
  net/ice/base: add function to set HW profile for raw flow
  app/testpmd: update Max RAW pattern size to 512
  net/ice: enable protocol agnostic flow offloading in FDIR

* v8:
Added memory free logic.

* v8:
Replaced profile info list with a table.

* v7:
Fixed LIST_FOR_EACH_ENTRY logic.

* v6:
Removed redundant code.

* v5:
Optimized some code logic.

* v4:
Added list to check inputset conflict.

* v3:
Added necessary base code for raw flow in FDIR.

* v2:
Enabled vxlan port add for raw flow and updated commit message

 app/test-pmd/cmdline_flow.c            |   2 +-
 doc/guides/rel_notes/release_21_11.rst |   1 +
 drivers/net/ice/base/README            |   2 +-
 drivers/net/ice/base/ice_flex_pipe.c   |  93 +++++++++-
 drivers/net/ice/base/ice_flex_pipe.h   |   6 +-
 drivers/net/ice/base/ice_flow.c        |  86 ++++++++-
 drivers/net/ice/base/ice_flow.h        |   4 +
 drivers/net/ice/ice_ethdev.h           |  14 ++
 drivers/net/ice/ice_fdir_filter.c      | 231 +++++++++++++++++++++++++
 drivers/net/ice/ice_generic_flow.c     |   7 +
 drivers/net/ice/ice_generic_flow.h     |   3 +
 11 files changed, 443 insertions(+), 6 deletions(-)
  

Comments

Qi Zhang Nov. 2, 2021, 5:58 a.m. UTC | #1
> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Tuesday, November 2, 2021 1:39 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Xu, Ting
> <ting.xu@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH v9 0/4] enable protocol agnostic flow offloading in FDIR
> 
> Protocol agnostic flow offloading in Flow Director is enabled by this patch set
> based on the Parser Library using existing rte_flow raw API.
> 
> [PATCH v9 1/4] net/ice/base: add method to disable FDIR SWAP option.
> [PATCH v9 2/4] net/ice/base: add function to set HW profile for raw flow.
> [PATCH v9 3/4] app/testpmd: update Max RAW pattern size to 512.
> [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR.
> 
> Junfeng Guo (4):
>   net/ice/base: add method to disable FDIR SWAP option
>   net/ice/base: add function to set HW profile for raw flow
>   app/testpmd: update Max RAW pattern size to 512
>   net/ice: enable protocol agnostic flow offloading in FDIR
> 
> * v8:
> Added memory free logic.
> 
> * v8:
> Replaced profile info list with a table.
> 
> * v7:
> Fixed LIST_FOR_EACH_ENTRY logic.
> 
> * v6:
> Removed redundant code.
> 
> * v5:
> Optimized some code logic.
> 
> * v4:
> Added list to check inputset conflict.
> 
> * v3:
> Added necessary base code for raw flow in FDIR.
> 
> * v2:
> Enabled vxlan port add for raw flow and updated commit message
> 
>  app/test-pmd/cmdline_flow.c            |   2 +-
>  doc/guides/rel_notes/release_21_11.rst |   1 +
>  drivers/net/ice/base/README            |   2 +-
>  drivers/net/ice/base/ice_flex_pipe.c   |  93 +++++++++-
>  drivers/net/ice/base/ice_flex_pipe.h   |   6 +-
>  drivers/net/ice/base/ice_flow.c        |  86 ++++++++-
>  drivers/net/ice/base/ice_flow.h        |   4 +
>  drivers/net/ice/ice_ethdev.h           |  14 ++
>  drivers/net/ice/ice_fdir_filter.c      | 231 +++++++++++++++++++++++++
>  drivers/net/ice/ice_generic_flow.c     |   7 +
>  drivers/net/ice/ice_generic_flow.h     |   3 +
>  11 files changed, 443 insertions(+), 6 deletions(-)
> 
> --
> 2.25.1

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  
Ferruh Yigit Nov. 2, 2021, 4:29 p.m. UTC | #2
On 11/2/2021 5:39 AM, Junfeng Guo wrote:
> Protocol agnostic flow offloading in Flow Director is enabled by this
> patch set based on the Parser Library using existing rte_flow raw API.
> 
> [PATCH v9 1/4] net/ice/base: add method to disable FDIR SWAP option.
> [PATCH v9 2/4] net/ice/base: add function to set HW profile for raw flow.
> [PATCH v9 3/4] app/testpmd: update Max RAW pattern size to 512.
> [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR.
> 
> Junfeng Guo (4):
>    net/ice/base: add method to disable FDIR SWAP option
>    net/ice/base: add function to set HW profile for raw flow
>    app/testpmd: update Max RAW pattern size to 512
>    net/ice: enable protocol agnostic flow offloading in FDIR

Hi Junfeng,

Since there will be a new version, can you please fix following too?

$ ./devtools/check-doc-vs-code.sh
rte_flow doc out of sync for ice
         item raw
  
Junfeng Guo Nov. 3, 2021, 3:16 a.m. UTC | #3
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Wednesday, November 3, 2021 00:29
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Xu, Ting <Ting.Xu@intel.com>
> Subject: Re: [PATCH v9 0/4] enable protocol agnostic flow offloading in
> FDIR
> 
> On 11/2/2021 5:39 AM, Junfeng Guo wrote:
> > Protocol agnostic flow offloading in Flow Director is enabled by this
> > patch set based on the Parser Library using existing rte_flow raw API.
> >
> > [PATCH v9 1/4] net/ice/base: add method to disable FDIR SWAP option.
> > [PATCH v9 2/4] net/ice/base: add function to set HW profile for raw
> flow.
> > [PATCH v9 3/4] app/testpmd: update Max RAW pattern size to 512.
> > [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in
> FDIR.
> >
> > Junfeng Guo (4):
> >    net/ice/base: add method to disable FDIR SWAP option
> >    net/ice/base: add function to set HW profile for raw flow
> >    app/testpmd: update Max RAW pattern size to 512
> >    net/ice: enable protocol agnostic flow offloading in FDIR
> 
> Hi Junfeng,
> 
> Since there will be a new version, can you please fix following too?
> 
> $ ./devtools/check-doc-vs-code.sh
> rte_flow doc out of sync for ice
>          item raw

Fixed in the coming patch set, thanks for your careful review!

Regards,
Junfeng Guo