mbox series

[v6,0/5] Implement rte_power_monitor API in virtio/vhost PMD

Message ID 20211015170911.478394-1-miao.li@intel.com (mailing list archive)
Headers
Series Implement rte_power_monitor API in virtio/vhost PMD |

Message

Li, Miao Oct. 15, 2021, 5:09 p.m. UTC
  This patchset implements rte_power_monitor API in virtio and vhost PMD
to reduce power consumption when no packet come in. This API can be
called and tested in l3fwd-power after adding vhost and virtio support
in l3fwd-power and ignoring the rx queue information check in
queue_stopped().

v6:
-modify comment
-remove extra space
-fix IPv4 CKSUM check

v5:
-Rebase on lastest repo

v4:
-modify comment
-update the release note
-add IPv4 CKSUM check

v3:
-fix some code format issues
-fix spelling mistake

v2:
-remove flag and add match and size in rte_vhost_power_monitor_cond
-modify power callback function
-add dev and queue id check and remove unnecessary check
-fix the assignment of pmc->size
-update port configuration according to the device information and
remove adding command line arguments
-modify some titles

Miao Li (5):
  net/virtio: implement rte_power_monitor API
  vhost: implement rte_power_monitor API
  net/vhost: implement rte_power_monitor API
  power: modify return of queue_stopped
  examples/l3fwd-power: support virtio/vhost

 doc/guides/rel_notes/release_21_11.rst | 12 ++++++
 drivers/net/vhost/rte_eth_vhost.c      | 40 ++++++++++++++++++
 drivers/net/virtio/virtio_ethdev.c     | 56 ++++++++++++++++++++++++++
 examples/l3fwd-power/main.c            | 15 ++++++-
 lib/power/rte_power_pmd_mgmt.c         |  9 ++++-
 lib/vhost/rte_vhost.h                  | 42 +++++++++++++++++++
 lib/vhost/version.map                  |  3 ++
 lib/vhost/vhost.c                      | 38 +++++++++++++++++
 8 files changed, 212 insertions(+), 3 deletions(-)
  

Comments

Maxime Coquelin Oct. 15, 2021, 12:57 p.m. UTC | #1
Hi,

On 10/15/21 19:09, Miao Li wrote:
> This patchset implements rte_power_monitor API in virtio and vhost PMD
> to reduce power consumption when no packet come in. This API can be
> called and tested in l3fwd-power after adding vhost and virtio support
> in l3fwd-power and ignoring the rx queue information check in
> queue_stopped().
> 
> v6:
> -modify comment
> -remove extra space
> -fix IPv4 CKSUM check
> 
> v5:
> -Rebase on lastest repo
> 
> v4:
> -modify comment
> -update the release note
> -add IPv4 CKSUM check
> 
> v3:
> -fix some code format issues
> -fix spelling mistake
> 
> v2:
> -remove flag and add match and size in rte_vhost_power_monitor_cond
> -modify power callback function
> -add dev and queue id check and remove unnecessary check
> -fix the assignment of pmc->size
> -update port configuration according to the device information and
> remove adding command line arguments
> -modify some titles
> 
> Miao Li (5):
>    net/virtio: implement rte_power_monitor API
>    vhost: implement rte_power_monitor API
>    net/vhost: implement rte_power_monitor API
>    power: modify return of queue_stopped
>    examples/l3fwd-power: support virtio/vhost
> 
>   doc/guides/rel_notes/release_21_11.rst | 12 ++++++
>   drivers/net/vhost/rte_eth_vhost.c      | 40 ++++++++++++++++++
>   drivers/net/virtio/virtio_ethdev.c     | 56 ++++++++++++++++++++++++++
>   examples/l3fwd-power/main.c            | 15 ++++++-
>   lib/power/rte_power_pmd_mgmt.c         |  9 ++++-
>   lib/vhost/rte_vhost.h                  | 42 +++++++++++++++++++
>   lib/vhost/version.map                  |  3 ++
>   lib/vhost/vhost.c                      | 38 +++++++++++++++++
>   8 files changed, 212 insertions(+), 3 deletions(-)
> 

Please run checkpatch and check-git-log scripts, there are some issues.

Thanks,
Maxime
  
Li, Miao Oct. 18, 2021, 1:54 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, October 15, 2021 8:58 PM
> To: Li, Miao <miao.li@intel.com>; dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>
> Subject: Re: [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost
> PMD
> 
> Hi,
> 
> On 10/15/21 19:09, Miao Li wrote:
> > This patchset implements rte_power_monitor API in virtio and vhost PMD
> > to reduce power consumption when no packet come in. This API can be
> > called and tested in l3fwd-power after adding vhost and virtio support
> > in l3fwd-power and ignoring the rx queue information check in
> > queue_stopped().
> >
> > v6:
> > -modify comment
> > -remove extra space
> > -fix IPv4 CKSUM check
> >
> > v5:
> > -Rebase on lastest repo
> >
> > v4:
> > -modify comment
> > -update the release note
> > -add IPv4 CKSUM check
> >
> > v3:
> > -fix some code format issues
> > -fix spelling mistake
> >
> > v2:
> > -remove flag and add match and size in rte_vhost_power_monitor_cond
> > -modify power callback function
> > -add dev and queue id check and remove unnecessary check
> > -fix the assignment of pmc->size
> > -update port configuration according to the device information and
> > remove adding command line arguments
> > -modify some titles
> >
> > Miao Li (5):
> >    net/virtio: implement rte_power_monitor API
> >    vhost: implement rte_power_monitor API
> >    net/vhost: implement rte_power_monitor API
> >    power: modify return of queue_stopped
> >    examples/l3fwd-power: support virtio/vhost
> >
> >   doc/guides/rel_notes/release_21_11.rst | 12 ++++++
> >   drivers/net/vhost/rte_eth_vhost.c      | 40 ++++++++++++++++++
> >   drivers/net/virtio/virtio_ethdev.c     | 56 ++++++++++++++++++++++++++
> >   examples/l3fwd-power/main.c            | 15 ++++++-
> >   lib/power/rte_power_pmd_mgmt.c         |  9 ++++-
> >   lib/vhost/rte_vhost.h                  | 42 +++++++++++++++++++
> >   lib/vhost/version.map                  |  3 ++
> >   lib/vhost/vhost.c                      | 38 +++++++++++++++++
> >   8 files changed, 212 insertions(+), 3 deletions(-)
> >
> 
> Please run checkpatch and check-git-log scripts, there are some issues.

Ok, I will fix them in the next version.

Thanks,
Miao

> 
> Thanks,
> Maxime