mbox series

[v10,0/9] new features for ipsec and security libraries

Message ID 20211014160329.579970-1-radu.nicolau@intel.com (mailing list archive)
Headers
Series new features for ipsec and security libraries |

Message

Radu Nicolau Oct. 14, 2021, 4:03 p.m. UTC 
  Add support for:
NAT-T/UDP encapsulation
AES_CCM, CHACHA20_POLY1305 and AES_GMAC
SA telemetry
ESN with initial SQN value

Signed-off-by: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>

Radu Nicolau (9):
  security: add ESN field to ipsec_xform
  ipsec: add support for AEAD algorithms
  security: add UDP params for IPsec NAT-T
  ipsec: add support for NAT-T
  mbuf: add IPsec ESP tunnel type
  ipsec: add support for SA telemetry
  ipsec: add support for initial SQN value
  doc: remove unneeded ipsec new field deprecation
  doc: remove unneeded security deprecation

 doc/guides/prog_guide/ipsec_lib.rst    |  12 +-
 doc/guides/rel_notes/deprecation.rst   |  11 --
 doc/guides/rel_notes/release_21_11.rst |  16 ++
 lib/ipsec/crypto.h                     | 137 ++++++++++++++
 lib/ipsec/esp_inb.c                    |  84 ++++++++-
 lib/ipsec/esp_outb.c                   |  91 ++++++++-
 lib/ipsec/ipsec_telemetry.c            | 244 +++++++++++++++++++++++++
 lib/ipsec/meson.build                  |   6 +-
 lib/ipsec/rte_ipsec.h                  |  23 +++
 lib/ipsec/rte_ipsec_sa.h               |   9 +-
 lib/ipsec/sa.c                         | 120 ++++++++++--
 lib/ipsec/sa.h                         |  15 ++
 lib/ipsec/version.map                  |   9 +
 lib/mbuf/rte_mbuf_core.h               |   1 +
 lib/security/rte_security.h            |  15 ++
 15 files changed, 745 insertions(+), 48 deletions(-)
 create mode 100644 lib/ipsec/ipsec_telemetry.c

Comments

Akhil Goyal Oct. 17, 2021, 12:17 p.m. UTC | #1 
> Add support for:
> NAT-T/UDP encapsulation
> AES_CCM, CHACHA20_POLY1305 and AES_GMAC
> SA telemetry
> ESN with initial SQN value
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
> 
> Radu Nicolau (9):
>   security: add ESN field to ipsec_xform
>   ipsec: add support for AEAD algorithms
>   security: add UDP params for IPsec NAT-T
>   ipsec: add support for NAT-T
>   mbuf: add IPsec ESP tunnel type
>   ipsec: add support for SA telemetry
>   ipsec: add support for initial SQN value
>   doc: remove unneeded ipsec new field deprecation

Can you specify why this field is not needed now?

>   doc: remove unneeded security deprecation

Series Acked-by: Akhil Goyal <gakhil@marvell.com>

Modified release notes and patch titles while merging.
Applied to dpdk-next-crypto

Thanks.


> 
>  doc/guides/prog_guide/ipsec_lib.rst    |  12 +-
>  doc/guides/rel_notes/deprecation.rst   |  11 --
>  doc/guides/rel_notes/release_21_11.rst |  16 ++
>  lib/ipsec/crypto.h                     | 137 ++++++++++++++
>  lib/ipsec/esp_inb.c                    |  84 ++++++++-
>  lib/ipsec/esp_outb.c                   |  91 ++++++++-
>  lib/ipsec/ipsec_telemetry.c            | 244 +++++++++++++++++++++++++
>  lib/ipsec/meson.build                  |   6 +-
>  lib/ipsec/rte_ipsec.h                  |  23 +++
>  lib/ipsec/rte_ipsec_sa.h               |   9 +-
>  lib/ipsec/sa.c                         | 120 ++++++++++--
>  lib/ipsec/sa.h                         |  15 ++
>  lib/ipsec/version.map                  |   9 +
>  lib/mbuf/rte_mbuf_core.h               |   1 +
>  lib/security/rte_security.h            |  15 ++
>  15 files changed, 745 insertions(+), 48 deletions(-)
>  create mode 100644 lib/ipsec/ipsec_telemetry.c
> 
> --
> 
> v2: fixed lib/ipsec/version.map updates to show correct version
> v3: fixed build error and corrected misspelled email address
> v4: add doxygen comments for the IPsec telemetry APIs
>     update inline comments refering to the wrong RFC
> v5: update commit messages after feedback
>     update the UDP encapsulation patch to actually use the configured ports
> v6: fix initial SQN value
> v7: reworked the patches after feedback
> v8: updated library doc, release notes and removed deprecation notices
> v9: reworked telemetry, tso and esn patches
> v10: removed TSO patch, addressed feedback
> 
> 2.25.1
Radu Nicolau Oct. 18, 2021, 9:06 a.m. UTC | #2 
On 10/17/2021 1:17 PM, Akhil Goyal wrote:
>> Add support for:
>> NAT-T/UDP encapsulation
>> AES_CCM, CHACHA20_POLY1305 and AES_GMAC
>> SA telemetry
>> ESN with initial SQN value
>>
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
>> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
>>
>> Radu Nicolau (9):
>>    security: add ESN field to ipsec_xform
>>    ipsec: add support for AEAD algorithms
>>    security: add UDP params for IPsec NAT-T
>>    ipsec: add support for NAT-T
>>    mbuf: add IPsec ESP tunnel type
>>    ipsec: add support for SA telemetry
>>    ipsec: add support for initial SQN value
>>    doc: remove unneeded ipsec new field deprecation
> Can you specify why this field is not needed now?
It was part of the TSO feature that is being reworked with no API changes.
>
>>    doc: remove unneeded security deprecation
> Series Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> Modified release notes and patch titles while merging.
> Applied to dpdk-next-crypto
>
> Thanks.
Thank you!