mbox series

[v3,0/2] fix mingw build error

Message ID 20210127142706.6290-1-leyi.rong@intel.com (mailing list archive)
Headers
Series fix mingw build error |

Message

Leyi Rong Jan. 27, 2021, 2:27 p.m. UTC 
  This patchset fix mingw build error when avx512 is introduced.

---
v2:
- Set i40e_avx512_cc_support to false to avoid the build error under
  windows with mingw.

Leyi Rong (2):
  config: disable avx512 on mingw cross build
  net/i40e: fix mingw build error

 config/x86/cross-mingw       | 3 +++
 drivers/net/i40e/meson.build | 4 ++++
 2 files changed, 7 insertions(+)

Comments

Kadam, Pallavi Jan. 27, 2021, 7:15 p.m. UTC | #1 
On 1/27/2021 6:27 AM, Leyi Rong wrote:
> This patchset fix mingw build error when avx512 is introduced.
>
> ---

Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
David Marchand Jan. 28, 2021, 12:28 p.m. UTC | #2 
On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
>
> This patchset fix mingw build error when avx512 is introduced.
>
> ---
> v2:
> - Set i40e_avx512_cc_support to false to avoid the build error under
>   windows with mingw.
>
> Leyi Rong (2):
>   config: disable avx512 on mingw cross build
>   net/i40e: fix mingw build error
>
>  config/x86/cross-mingw       | 3 +++
>  drivers/net/i40e/meson.build | 4 ++++
>  2 files changed, 7 insertions(+)

LGTM with fc32 mingw.
Tested-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon Jan. 28, 2021, 9:26 p.m. UTC | #3 
28/01/2021 13:28, David Marchand:
> On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> >
> > This patchset fix mingw build error when avx512 is introduced.
> >
> > ---
> > v2:
> > - Set i40e_avx512_cc_support to false to avoid the build error under
> >   windows with mingw.
> >
> > Leyi Rong (2):
> >   config: disable avx512 on mingw cross build
> >   net/i40e: fix mingw build error
> >
> >  config/x86/cross-mingw       | 3 +++
> >  drivers/net/i40e/meson.build | 4 ++++
> >  2 files changed, 7 insertions(+)
> 
> LGTM with fc32 mingw.
> Tested-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.

Dmitry found a lighter alternative option to be tested and discussed.
David Marchand Feb. 2, 2021, 8:36 a.m. UTC | #4 
On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/01/2021 13:28, David Marchand:
> > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> > >
> > > This patchset fix mingw build error when avx512 is introduced.
> > >
> > > ---
> > > v2:
> > > - Set i40e_avx512_cc_support to false to avoid the build error under
> > >   windows with mingw.
> > >
> > > Leyi Rong (2):
> > >   config: disable avx512 on mingw cross build
> > >   net/i40e: fix mingw build error
> > >
> > >  config/x86/cross-mingw       | 3 +++
> > >  drivers/net/i40e/meson.build | 4 ++++
> > >  2 files changed, 7 insertions(+)
> >
> > LGTM with fc32 mingw.
> > Tested-by: David Marchand <david.marchand@redhat.com>
>
> Applied, thanks.
>
> Dmitry found a lighter alternative option to be tested and discussed.

We still have build failures at UNH for Windows, on the rc2 tag:
http://mails.dpdk.org/archives/test-report/2021-February/177464.html

Is this issue being looked at?
Leyi Rong Feb. 2, 2021, 9:09 a.m. UTC | #5 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, February 2, 2021 4:37 PM
> To: Rong, Leyi <leyi.rong@intel.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Richardson, Bruce
> <bruce.richardson@intel.com>; Tal Shnaiderman <talshn@nvidia.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; dev <dev@dpdk.org>; Aaron Conole
> <aconole@redhat.com>; ci@dpdk.org; dpdklab <dpdklab@iol.unh.edu>
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error
> 
> On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 28/01/2021 13:28, David Marchand:
> > > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> > > >
> > > > This patchset fix mingw build error when avx512 is introduced.
> > > >
> > > > ---
> > > > v2:
> > > > - Set i40e_avx512_cc_support to false to avoid the build error under
> > > >   windows with mingw.
> > > >
> > > > Leyi Rong (2):
> > > >   config: disable avx512 on mingw cross build
> > > >   net/i40e: fix mingw build error
> > > >
> > > >  config/x86/cross-mingw       | 3 +++
> > > >  drivers/net/i40e/meson.build | 4 ++++
> > > >  2 files changed, 7 insertions(+)
> > >
> > > LGTM with fc32 mingw.
> > > Tested-by: David Marchand <david.marchand@redhat.com>
> >
> > Applied, thanks.
> >
> > Dmitry found a lighter alternative option to be tested and discussed.
> 
> We still have build failures at UNH for Windows, on the rc2 tag:
> http://mails.dpdk.org/archives/test-report/2021-February/177464.html
> 
> Is this issue being looked at?
> 
> 
> --
> David Marchand

Hi David,

Seems the issue still exist on the platform which CPU has AVX512 capability, I think previous patch is not verified to cover this case.
Will send hotfix patch for this.