mbox series

[v3,0/2] Support i40e PMD on Windows

Message ID 20201222004511.12948-1-pallavi.kadam@intel.com (mailing list archive)
Headers
Series Support i40e PMD on Windows |

Message

Kadam, Pallavi Dec. 22, 2020, 12:45 a.m. UTC
  This patch-set enables building the Intel i40e PMD on Windows.


Depends-on: series-14296 ("eal/windows: add interrupt functions stub")

v3 changes:
	- Added a comment for __m_prefetchw (Thomas)
	- Replaced the letter from the reason to lowercase (Thomas)

v2 changes:
	- Updated commit message (Dmitry Kozlyuk)
	- Replaced x86intrin.h with rte_vect.h (Dmitry Kozlyuk)
	- Disable all drivers that do not support on Windows and enable
          as required (Thomas and Bruce)
	- added #include "i40e_status.h" for enum definition to avoid
	  forward references warning (Naty)

Pallavi Kadam (2):
  eal: add rte_random.c file on windows
  build: i40e PMD on Windows

 drivers/net/af_xdp/meson.build               |  6 ++++++
 drivers/net/ark/meson.build                  |  6 ++++++
 drivers/net/atlantic/meson.build             |  6 ++++++
 drivers/net/bnx2x/meson.build                |  6 ++++++
 drivers/net/bnxt/meson.build                 |  6 ++++++
 drivers/net/bonding/meson.build              |  6 ++++++
 drivers/net/cxgbe/meson.build                |  6 ++++++
 drivers/net/e1000/meson.build                |  6 ++++++
 drivers/net/ena/meson.build                  |  6 ++++++
 drivers/net/enic/meson.build                 |  6 ++++++
 drivers/net/failsafe/meson.build             |  6 ++++++
 drivers/net/fm10k/meson.build                |  6 ++++++
 drivers/net/hinic/meson.build                |  6 ++++++
 drivers/net/i40e/base/i40e_osdep.h           | 10 ++++++++++
 drivers/net/i40e/i40e_ethdev_vf.c            |  3 ++-
 drivers/net/i40e/i40e_rxtx_vec_avx2.c        |  2 +-
 drivers/net/i40e/i40e_tm.c                   |  2 +-
 drivers/net/iavf/meson.build                 |  6 ++++++
 drivers/net/ice/meson.build                  |  6 ++++++
 drivers/net/igc/meson.build                  |  6 ++++++
 drivers/net/ionic/meson.build                |  6 ++++++
 drivers/net/ipn3ke/meson.build               |  6 ++++++
 drivers/net/ixgbe/meson.build                |  6 ++++++
 drivers/net/kni/meson.build                  |  6 ++++++
 drivers/net/liquidio/meson.build             |  6 ++++++
 drivers/net/meson.build                      |  3 ---
 drivers/net/mlx5/windows/meson.build         |  0
 drivers/net/mvneta/meson.build               |  6 ++++++
 drivers/net/mvpp2/meson.build                |  6 ++++++
 drivers/net/netvsc/meson.build               |  6 ++++++
 drivers/net/nfb/meson.build                  |  6 ++++++
 drivers/net/null/meson.build                 |  6 ++++++
 drivers/net/octeontx/meson.build             |  6 ++++++
 drivers/net/octeontx2/meson.build            |  6 ++++++
 drivers/net/pcap/meson.build                 |  6 ++++++
 drivers/net/qede/meson.build                 |  6 ++++++
 drivers/net/ring/meson.build                 |  6 ++++++
 drivers/net/sfc/meson.build                  |  6 ++++++
 drivers/net/szedata2/meson.build             |  6 ++++++
 drivers/net/thunderx/meson.build             |  6 ++++++
 drivers/net/txgbe/meson.build                |  6 ++++++
 drivers/net/vhost/meson.build                |  6 ++++++
 drivers/net/virtio/meson.build               |  6 ++++++
 drivers/net/vmxnet3/meson.build              |  6 ++++++
 lib/librte_eal/common/meson.build            |  1 +
 lib/librte_eal/rte_eal_exports.def           |  1 +
 lib/librte_eal/windows/include/rte_windows.h |  6 ++++++
 47 files changed, 250 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/mlx5/windows/meson.build
  

Comments

Thomas Monjalon Jan. 14, 2021, 10:55 p.m. UTC | #1
22/12/2020 01:45, Pallavi Kadam:
> Pallavi Kadam (2):
>   eal: add rte_random.c file on windows
>   build: i40e PMD on Windows

Applied, thanks

For info, I've fixed an additional warning in i40e compilation on Windows:
	drivers/net/i40e/i40e_hash.c:357:22: warning:
	comparison of integers of different signs:
	'enum rte_flow_item_type' and 'unsigned long long'

--- a/drivers/net/i40e/i40e_hash.c
+++ b/drivers/net/i40e/i40e_hash.c
@@ -354,9 +354,10 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[],
                }
 
                /* Check the previous item allows this sub-item. */
-               if (prev_item_type >= RTE_DIM(pattern_next_allow_items) ||
+               if (prev_item_type >= (enum rte_flow_item_type)
+                               RTE_DIM(pattern_next_allow_items) ||
                    !(pattern_next_allow_items[prev_item_type] &
-                   BIT_ULL(pattern->type)))
+                               BIT_ULL(pattern->type)))
                        goto not_sup;
 
                /* For VLAN item, it does no matter about to pattern type
@@ -372,7 +373,8 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[],
                }
 
                prev_item_type = last_item_type;
-               assert(last_item_type < RTE_DIM(pattern_item_header));
+               assert(last_item_type < (enum rte_flow_item_type)
+                               RTE_DIM(pattern_item_header));
                item_hdr = pattern_item_header[last_item_type];
                assert(item_hdr);
  
Menon, Ranjit Jan. 14, 2021, 11:06 p.m. UTC | #2
On 1/14/2021 2:55 PM, Thomas Monjalon wrote:
> 22/12/2020 01:45, Pallavi Kadam:
>> Pallavi Kadam (2):
>>    eal: add rte_random.c file on windows
>>    build: i40e PMD on Windows
> Applied, thanks
>
> For info, I've fixed an additional warning in i40e compilation on Windows:
> 	drivers/net/i40e/i40e_hash.c:357:22: warning:
> 	comparison of integers of different signs:
> 	'enum rte_flow_item_type' and 'unsigned long long'

Thanks, Thomas. Oddly, we never saw this warning when we submitted the 
patch.

I'll check with Pallavi when she's back.

ranjit m.