Message
Jiawen Wu
Oct. 19, 2020, 8:53 a.m. UTC
v4: Add log type introduction,
add txgbe support in release note.
v3: Merge some recent changes in the main repo,
fix the checkpatch warnings.
v2: Re-order patches and fix some known problems.
v1: Introduce txgbe PMD.
Jiawen Wu (58):
net/txgbe: add build and doc infrastructure
net/txgbe: add ethdev probe and remove
net/txgbe: add device init and uninit
net/txgbe: add error types and registers
net/txgbe: add MAC type and bus lan id
net/txgbe: add HW infrastructure and dummy function
net/txgbe: add EEPROM functions
net/txgbe: add HW init and reset operation
net/txgbe: add PHY init
net/txgbe: add module identify
net/txgbe: add PHY reset
net/txgbe: add info get operation
net/txgbe: add interrupt operation
net/txgbe: add device configure operation
net/txgbe: add link status change
net/txgbe: add multi-speed link setup
net/txgbe: add autoc read and write
net/txgbe: add MAC address operations
net/txgbe: add unicast hash bitmap
net/txgbe: add Rx and Tx init
net/txgbe: add Rx and Tx queues setup and release
net/txgbe: add Rx and Tx start and stop
net/txgbe: add packet type
net/txgbe: fill simple transmit function
net/txgbe: fill transmit function with hardware offload
net/txgbe: fill Tx prepare function
net/txgbe: fill receive functions
net/txgbe: add device start operation
net/txgbe: add Rx and Tx data path start and stop
net/txgbe: add device stop and close operations
net/txgbe: support Rx interrupt
net/txgbe: add Rx and Tx queue info get
net/txgbe: add device stats get
net/txgbe: add device xstats get
net/txgbe: add queue stats mapping
net/txgbe: add VLAN handle support
net/txgbe: add SWFW semaphore and lock
net/txgbe: add PF module init and uninit for SRIOV
net/txgbe: add process mailbox operation
net/txgbe: add PF module configure for SRIOV
net/txgbe: add VMDq configure
net/txgbe: add RSS support
net/txgbe: add DCB support
net/txgbe: add flow control support
net/txgbe: add FC auto negotiation support
net/txgbe: add priority flow control support
net/txgbe: add device promiscuous and allmulticast mode
net/txgbe: add MTU set operation
net/txgbe: add FW version get operation
net/txgbe: add EEPROM info get operation
net/txgbe: add register dump support
net/txgbe: support device LED on and off
net/txgbe: add mirror rule operations
net/txgbe: add PTP support
net/txgbe: add DCB info get operation
net/txgbe: add Rx and Tx descriptor status
net/txgbe: change stop operation callback to return int
net/txgbe: introduce log type in the driver documentation
MAINTAINERS | 7 +
doc/guides/nics/features/txgbe.ini | 54 +
doc/guides/nics/txgbe.rst | 92 +
doc/guides/rel_notes/release_20_11.rst | 6 +
drivers/net/meson.build | 1 +
drivers/net/txgbe/base/meson.build | 26 +
drivers/net/txgbe/base/txgbe.h | 16 +
drivers/net/txgbe/base/txgbe_dcb.c | 360 ++
drivers/net/txgbe/base/txgbe_dcb.h | 121 +
drivers/net/txgbe/base/txgbe_dcb_hw.c | 282 ++
drivers/net/txgbe/base/txgbe_dcb_hw.h | 24 +
drivers/net/txgbe/base/txgbe_devids.h | 40 +
drivers/net/txgbe/base/txgbe_dummy.h | 657 +++
drivers/net/txgbe/base/txgbe_eeprom.c | 581 +++
drivers/net/txgbe/base/txgbe_eeprom.h | 64 +
drivers/net/txgbe/base/txgbe_hw.c | 3783 +++++++++++++++
drivers/net/txgbe/base/txgbe_hw.h | 112 +
drivers/net/txgbe/base/txgbe_mbx.c | 332 ++
drivers/net/txgbe/base/txgbe_mbx.h | 93 +
drivers/net/txgbe/base/txgbe_mng.c | 396 ++
drivers/net/txgbe/base/txgbe_mng.h | 176 +
drivers/net/txgbe/base/txgbe_osdep.h | 181 +
drivers/net/txgbe/base/txgbe_phy.c | 2247 +++++++++
drivers/net/txgbe/base/txgbe_phy.h | 375 ++
drivers/net/txgbe/base/txgbe_regs.h | 1887 ++++++++
drivers/net/txgbe/base/txgbe_status.h | 122 +
drivers/net/txgbe/base/txgbe_type.h | 705 +++
drivers/net/txgbe/meson.build | 18 +
drivers/net/txgbe/rte_pmd_txgbe.h | 37 +
drivers/net/txgbe/rte_pmd_txgbe_version.map | 3 +
drivers/net/txgbe/txgbe_ethdev.c | 4274 +++++++++++++++++
drivers/net/txgbe/txgbe_ethdev.h | 414 ++
drivers/net/txgbe/txgbe_logs.h | 54 +
drivers/net/txgbe/txgbe_pf.c | 887 ++++
drivers/net/txgbe/txgbe_ptypes.c | 673 +++
drivers/net/txgbe/txgbe_ptypes.h | 351 ++
drivers/net/txgbe/txgbe_regs_group.h | 54 +
drivers/net/txgbe/txgbe_rxtx.c | 4654 +++++++++++++++++++
drivers/net/txgbe/txgbe_rxtx.h | 413 ++
39 files changed, 24572 insertions(+)
create mode 100644 doc/guides/nics/features/txgbe.ini
create mode 100644 doc/guides/nics/txgbe.rst
create mode 100644 drivers/net/txgbe/base/meson.build
create mode 100644 drivers/net/txgbe/base/txgbe.h
create mode 100644 drivers/net/txgbe/base/txgbe_dcb.c
create mode 100644 drivers/net/txgbe/base/txgbe_dcb.h
create mode 100644 drivers/net/txgbe/base/txgbe_dcb_hw.c
create mode 100644 drivers/net/txgbe/base/txgbe_dcb_hw.h
create mode 100644 drivers/net/txgbe/base/txgbe_devids.h
create mode 100644 drivers/net/txgbe/base/txgbe_dummy.h
create mode 100644 drivers/net/txgbe/base/txgbe_eeprom.c
create mode 100644 drivers/net/txgbe/base/txgbe_eeprom.h
create mode 100644 drivers/net/txgbe/base/txgbe_hw.c
create mode 100644 drivers/net/txgbe/base/txgbe_hw.h
create mode 100644 drivers/net/txgbe/base/txgbe_mbx.c
create mode 100644 drivers/net/txgbe/base/txgbe_mbx.h
create mode 100644 drivers/net/txgbe/base/txgbe_mng.c
create mode 100644 drivers/net/txgbe/base/txgbe_mng.h
create mode 100644 drivers/net/txgbe/base/txgbe_osdep.h
create mode 100644 drivers/net/txgbe/base/txgbe_phy.c
create mode 100644 drivers/net/txgbe/base/txgbe_phy.h
create mode 100644 drivers/net/txgbe/base/txgbe_regs.h
create mode 100644 drivers/net/txgbe/base/txgbe_status.h
create mode 100644 drivers/net/txgbe/base/txgbe_type.h
create mode 100644 drivers/net/txgbe/meson.build
create mode 100644 drivers/net/txgbe/rte_pmd_txgbe.h
create mode 100644 drivers/net/txgbe/rte_pmd_txgbe_version.map
create mode 100644 drivers/net/txgbe/txgbe_ethdev.c
create mode 100644 drivers/net/txgbe/txgbe_ethdev.h
create mode 100644 drivers/net/txgbe/txgbe_logs.h
create mode 100644 drivers/net/txgbe/txgbe_pf.c
create mode 100644 drivers/net/txgbe/txgbe_ptypes.c
create mode 100644 drivers/net/txgbe/txgbe_ptypes.h
create mode 100644 drivers/net/txgbe/txgbe_regs_group.h
create mode 100644 drivers/net/txgbe/txgbe_rxtx.c
create mode 100644 drivers/net/txgbe/txgbe_rxtx.h
Comments
On October 19, 2020 4:53 PM, Jiawen Wu wrote: > v4: Add log type introduction, > add txgbe support in release note. > v3: Merge some recent changes in the main repo, > fix the checkpatch warnings. > v2: Re-order patches and fix some known problems. > v1: Introduce txgbe PMD. > Hi Ferruh, Does this patch still need to be modified? If it can be merged into the repo, I will make the second patch. Perhaps, the second patch would miss the proposal deadline? > > Jiawen Wu (58): > net/txgbe: add build and doc infrastructure > net/txgbe: add ethdev probe and remove > net/txgbe: add device init and uninit > net/txgbe: add error types and registers > net/txgbe: add MAC type and bus lan id > net/txgbe: add HW infrastructure and dummy function > net/txgbe: add EEPROM functions > net/txgbe: add HW init and reset operation > net/txgbe: add PHY init > net/txgbe: add module identify > net/txgbe: add PHY reset > net/txgbe: add info get operation > net/txgbe: add interrupt operation > net/txgbe: add device configure operation > net/txgbe: add link status change > net/txgbe: add multi-speed link setup > net/txgbe: add autoc read and write > net/txgbe: add MAC address operations > net/txgbe: add unicast hash bitmap > net/txgbe: add Rx and Tx init > net/txgbe: add Rx and Tx queues setup and release > net/txgbe: add Rx and Tx start and stop > net/txgbe: add packet type > net/txgbe: fill simple transmit function > net/txgbe: fill transmit function with hardware offload > net/txgbe: fill Tx prepare function > net/txgbe: fill receive functions > net/txgbe: add device start operation > net/txgbe: add Rx and Tx data path start and stop > net/txgbe: add device stop and close operations > net/txgbe: support Rx interrupt > net/txgbe: add Rx and Tx queue info get > net/txgbe: add device stats get > net/txgbe: add device xstats get > net/txgbe: add queue stats mapping > net/txgbe: add VLAN handle support > net/txgbe: add SWFW semaphore and lock > net/txgbe: add PF module init and uninit for SRIOV > net/txgbe: add process mailbox operation > net/txgbe: add PF module configure for SRIOV > net/txgbe: add VMDq configure > net/txgbe: add RSS support > net/txgbe: add DCB support > net/txgbe: add flow control support > net/txgbe: add FC auto negotiation support > net/txgbe: add priority flow control support > net/txgbe: add device promiscuous and allmulticast mode > net/txgbe: add MTU set operation > net/txgbe: add FW version get operation > net/txgbe: add EEPROM info get operation > net/txgbe: add register dump support > net/txgbe: support device LED on and off > net/txgbe: add mirror rule operations > net/txgbe: add PTP support > net/txgbe: add DCB info get operation > net/txgbe: add Rx and Tx descriptor status > net/txgbe: change stop operation callback to return int > net/txgbe: introduce log type in the driver documentation >
On 10/22/2020 12:23 PM, Jiawen Wu wrote: > On October 19, 2020 4:53 PM, Jiawen Wu wrote: >> v4: Add log type introduction, >> add txgbe support in release note. >> v3: Merge some recent changes in the main repo, >> fix the checkpatch warnings. >> v2: Re-order patches and fix some known problems. >> v1: Introduce txgbe PMD. >> > > Hi Ferruh, > > Does this patch still need to be modified? > If it can be merged into the repo, I will make the second patch. > Perhaps, the second patch would miss the proposal deadline? > Hi Jiawen, I forget about your second set, I will try to finish reviewing this one today, to give enough time for the next set.
On 10/19/2020 9:53 AM, Jiawen Wu wrote: > v4: Add log type introduction, > add txgbe support in release note. > v3: Merge some recent changes in the main repo, > fix the checkpatch warnings. > v2: Re-order patches and fix some known problems. > v1: Introduce txgbe PMD. > > > Jiawen Wu (58): > net/txgbe: add build and doc infrastructure > net/txgbe: add ethdev probe and remove > net/txgbe: add device init and uninit > net/txgbe: add error types and registers > net/txgbe: add MAC type and bus lan id > net/txgbe: add HW infrastructure and dummy function > net/txgbe: add EEPROM functions > net/txgbe: add HW init and reset operation > net/txgbe: add PHY init > net/txgbe: add module identify > net/txgbe: add PHY reset > net/txgbe: add info get operation > net/txgbe: add interrupt operation > net/txgbe: add device configure operation > net/txgbe: add link status change > net/txgbe: add multi-speed link setup > net/txgbe: add autoc read and write > net/txgbe: add MAC address operations > net/txgbe: add unicast hash bitmap > net/txgbe: add Rx and Tx init > net/txgbe: add Rx and Tx queues setup and release > net/txgbe: add Rx and Tx start and stop > net/txgbe: add packet type > net/txgbe: fill simple transmit function > net/txgbe: fill transmit function with hardware offload > net/txgbe: fill Tx prepare function > net/txgbe: fill receive functions > net/txgbe: add device start operation > net/txgbe: add Rx and Tx data path start and stop > net/txgbe: add device stop and close operations > net/txgbe: support Rx interrupt > net/txgbe: add Rx and Tx queue info get > net/txgbe: add device stats get > net/txgbe: add device xstats get > net/txgbe: add queue stats mapping > net/txgbe: add VLAN handle support > net/txgbe: add SWFW semaphore and lock > net/txgbe: add PF module init and uninit for SRIOV > net/txgbe: add process mailbox operation > net/txgbe: add PF module configure for SRIOV > net/txgbe: add VMDq configure > net/txgbe: add RSS support > net/txgbe: add DCB support > net/txgbe: add flow control support > net/txgbe: add FC auto negotiation support > net/txgbe: add priority flow control support > net/txgbe: add device promiscuous and allmulticast mode > net/txgbe: add MTU set operation > net/txgbe: add FW version get operation > net/txgbe: add EEPROM info get operation > net/txgbe: add register dump support > net/txgbe: support device LED on and off > net/txgbe: add mirror rule operations > net/txgbe: add PTP support > net/txgbe: add DCB info get operation > net/txgbe: add Rx and Tx descriptor status > net/txgbe: change stop operation callback to return int > net/txgbe: introduce log type in the driver documentation For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Series applied to dpdk-next-net/main, thanks. 57/58 & 58/58 has been distributed to the relevant commits while merging, please double check them in the upstream repo. 56/58 & 53/58 has been dropped while merging. 56/58 needs a new version which can be send individually, 53/58 is adding a deprecated feature, it can't go in as it is. Also can you please send a patch for the comment mentioned in 38/58?
On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: > On 10/19/2020 9:53 AM, Jiawen Wu wrote: > > v4: Add log type introduction, > > add txgbe support in release note. > > v3: Merge some recent changes in the main repo, > > fix the checkpatch warnings. > > v2: Re-order patches and fix some known problems. > > v1: Introduce txgbe PMD. > > > > > > Jiawen Wu (58): > > net/txgbe: add build and doc infrastructure > > net/txgbe: add ethdev probe and remove > > net/txgbe: add device init and uninit > > net/txgbe: add error types and registers > > net/txgbe: add MAC type and bus lan id > > net/txgbe: add HW infrastructure and dummy function > > net/txgbe: add EEPROM functions > > net/txgbe: add HW init and reset operation > > net/txgbe: add PHY init > > net/txgbe: add module identify > > net/txgbe: add PHY reset > > net/txgbe: add info get operation > > net/txgbe: add interrupt operation > > net/txgbe: add device configure operation > > net/txgbe: add link status change > > net/txgbe: add multi-speed link setup > > net/txgbe: add autoc read and write > > net/txgbe: add MAC address operations > > net/txgbe: add unicast hash bitmap > > net/txgbe: add Rx and Tx init > > net/txgbe: add Rx and Tx queues setup and release > > net/txgbe: add Rx and Tx start and stop > > net/txgbe: add packet type > > net/txgbe: fill simple transmit function > > net/txgbe: fill transmit function with hardware offload > > net/txgbe: fill Tx prepare function > > net/txgbe: fill receive functions > > net/txgbe: add device start operation > > net/txgbe: add Rx and Tx data path start and stop > > net/txgbe: add device stop and close operations > > net/txgbe: support Rx interrupt > > net/txgbe: add Rx and Tx queue info get > > net/txgbe: add device stats get > > net/txgbe: add device xstats get > > net/txgbe: add queue stats mapping > > net/txgbe: add VLAN handle support > > net/txgbe: add SWFW semaphore and lock > > net/txgbe: add PF module init and uninit for SRIOV > > net/txgbe: add process mailbox operation > > net/txgbe: add PF module configure for SRIOV > > net/txgbe: add VMDq configure > > net/txgbe: add RSS support > > net/txgbe: add DCB support > > net/txgbe: add flow control support > > net/txgbe: add FC auto negotiation support > > net/txgbe: add priority flow control support > > net/txgbe: add device promiscuous and allmulticast mode > > net/txgbe: add MTU set operation > > net/txgbe: add FW version get operation > > net/txgbe: add EEPROM info get operation > > net/txgbe: add register dump support > > net/txgbe: support device LED on and off > > net/txgbe: add mirror rule operations > > net/txgbe: add PTP support > > net/txgbe: add DCB info get operation > > net/txgbe: add Rx and Tx descriptor status > > net/txgbe: change stop operation callback to return int > > net/txgbe: introduce log type in the driver documentation > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Series applied to dpdk-next-net/main, thanks. > Thanks Ferruh, I want to know when should I send the web patch for NICs support. Will I be notified after the patch is merged? Or after the release of rc2? > > 57/58 & 58/58 has been distributed to the relevant commits while merging, > please double check them in the upstream repo. > > 56/58 & 53/58 has been dropped while merging. > 56/58 needs a new version which can be send individually, > 53/58 is adding a deprecated feature, it can't go in as it is. > > Also can you please send a patch for the comment mentioned in 38/58? I will send two additional patches, one as a new version for 56/58, the other one to fix 'rte_panic()'.
On Mon, Oct 26, 2020 at 3:56 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > Series applied to dpdk-next-net/main, thanks. > > > > 57/58 & 58/58 has been distributed to the relevant commits while merging, please > double check them in the upstream repo. > > 56/58 & 53/58 has been dropped while merging. > 56/58 needs a new version which can be send individually, > 53/58 is adding a deprecated feature, it can't go in as it is. > > Also can you please send a patch for the comment mentioned in 38/58? > Caught an issue while compiling next-net in Travis. txgbe.rst is not included in the doc index which triggers a doc generation error: FAILED: doc/guides/html /usr/bin/python3 ../buildtools/call-sphinx-build.py /usr/bin/sphinx-build 20.11.0-rc1 /home/travis/build/david-marchand/dpdk/doc/guides /home/travis/build/david-marchand/dpdk/build/doc/guides -W Install the sphinx ReadTheDocs theme for improved html documentation layout: https://sphinx-rtd-theme.readthedocs.io/ Warning, treated as error: /home/travis/build/david-marchand/dpdk/doc/guides/nics/txgbe.rst:document isn't included in any toctree
On 10/27/2020 8:48 AM, David Marchand wrote: > On Mon, Oct 26, 2020 at 3:56 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: >> Series applied to dpdk-next-net/main, thanks. >> >> >> >> 57/58 & 58/58 has been distributed to the relevant commits while merging, please >> double check them in the upstream repo. >> >> 56/58 & 53/58 has been dropped while merging. >> 56/58 needs a new version which can be send individually, >> 53/58 is adding a deprecated feature, it can't go in as it is. >> >> Also can you please send a patch for the comment mentioned in 38/58? >> > > Caught an issue while compiling next-net in Travis. > txgbe.rst is not included in the doc index which triggers a doc > generation error: > > FAILED: doc/guides/html > /usr/bin/python3 ../buildtools/call-sphinx-build.py > /usr/bin/sphinx-build 20.11.0-rc1 > /home/travis/build/david-marchand/dpdk/doc/guides > /home/travis/build/david-marchand/dpdk/build/doc/guides -W > Install the sphinx ReadTheDocs theme for improved html documentation > layout: https://sphinx-rtd-theme.readthedocs.io/ > Warning, treated as error: > /home/travis/build/david-marchand/dpdk/doc/guides/nics/txgbe.rst:document > isn't included in any toctree > Thanks David, I will fix it in the nex-net as following: diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index da5d85bcd0..3443617755 100644 --- a/doc/guides/nics/index.rst +++ b/doc/guides/nics/index.rst @@ -57,6 +57,7 @@ Network Interface Controller Drivers szedata2 tap thunderx + txgbe vdev_netvsc virtio vhost
On 10/27/2020 2:39 AM, Jiawen Wu wrote: > On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: >> On 10/19/2020 9:53 AM, Jiawen Wu wrote: >>> v4: Add log type introduction, >>> add txgbe support in release note. >>> v3: Merge some recent changes in the main repo, >>> fix the checkpatch warnings. >>> v2: Re-order patches and fix some known problems. >>> v1: Introduce txgbe PMD. >>> >>> >>> Jiawen Wu (58): >>> net/txgbe: add build and doc infrastructure >>> net/txgbe: add ethdev probe and remove >>> net/txgbe: add device init and uninit >>> net/txgbe: add error types and registers >>> net/txgbe: add MAC type and bus lan id >>> net/txgbe: add HW infrastructure and dummy function >>> net/txgbe: add EEPROM functions >>> net/txgbe: add HW init and reset operation >>> net/txgbe: add PHY init >>> net/txgbe: add module identify >>> net/txgbe: add PHY reset >>> net/txgbe: add info get operation >>> net/txgbe: add interrupt operation >>> net/txgbe: add device configure operation >>> net/txgbe: add link status change >>> net/txgbe: add multi-speed link setup >>> net/txgbe: add autoc read and write >>> net/txgbe: add MAC address operations >>> net/txgbe: add unicast hash bitmap >>> net/txgbe: add Rx and Tx init >>> net/txgbe: add Rx and Tx queues setup and release >>> net/txgbe: add Rx and Tx start and stop >>> net/txgbe: add packet type >>> net/txgbe: fill simple transmit function >>> net/txgbe: fill transmit function with hardware offload >>> net/txgbe: fill Tx prepare function >>> net/txgbe: fill receive functions >>> net/txgbe: add device start operation >>> net/txgbe: add Rx and Tx data path start and stop >>> net/txgbe: add device stop and close operations >>> net/txgbe: support Rx interrupt >>> net/txgbe: add Rx and Tx queue info get >>> net/txgbe: add device stats get >>> net/txgbe: add device xstats get >>> net/txgbe: add queue stats mapping >>> net/txgbe: add VLAN handle support >>> net/txgbe: add SWFW semaphore and lock >>> net/txgbe: add PF module init and uninit for SRIOV >>> net/txgbe: add process mailbox operation >>> net/txgbe: add PF module configure for SRIOV >>> net/txgbe: add VMDq configure >>> net/txgbe: add RSS support >>> net/txgbe: add DCB support >>> net/txgbe: add flow control support >>> net/txgbe: add FC auto negotiation support >>> net/txgbe: add priority flow control support >>> net/txgbe: add device promiscuous and allmulticast mode >>> net/txgbe: add MTU set operation >>> net/txgbe: add FW version get operation >>> net/txgbe: add EEPROM info get operation >>> net/txgbe: add register dump support >>> net/txgbe: support device LED on and off >>> net/txgbe: add mirror rule operations >>> net/txgbe: add PTP support >>> net/txgbe: add DCB info get operation >>> net/txgbe: add Rx and Tx descriptor status >>> net/txgbe: change stop operation callback to return int >>> net/txgbe: introduce log type in the driver documentation >> >> For series, >> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> >> >> Series applied to dpdk-next-net/main, thanks. >> > > Thanks Ferruh, > > I want to know when should I send the web patch for NICs support. > It would be better to merge it after driver support merged into main tree, but you can send the patch now. > Will I be notified after the patch is merged? > Or after the release of rc2? > >> >> 57/58 & 58/58 has been distributed to the relevant commits while merging, >> please double check them in the upstream repo. >> >> 56/58 & 53/58 has been dropped while merging. >> 56/58 needs a new version which can be send individually, >> 53/58 is adding a deprecated feature, it can't go in as it is. >> >> Also can you please send a patch for the comment mentioned in 38/58? > > I will send two additional patches, one as a new version for 56/58, the other one to fix 'rte_panic()'. > Thanks.
On Tue, Oct 27, 2020 at 12:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > I will fix it in the nex-net as following: > > diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst > index da5d85bcd0..3443617755 100644 > --- a/doc/guides/nics/index.rst > +++ b/doc/guides/nics/index.rst > @@ -57,6 +57,7 @@ Network Interface Controller Drivers > szedata2 > tap > thunderx > + txgbe > vdev_netvsc > virtio > vhost > LGTM. Thanks Ferruh.
27/10/2020 12:37, Ferruh Yigit: > On 10/27/2020 2:39 AM, Jiawen Wu wrote: > > On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: > >> Series applied to dpdk-next-net/main, thanks. > >> > >> 57/58 & 58/58 has been distributed to the relevant commits while merging, > >> please double check them in the upstream repo. > >> > >> 56/58 & 53/58 has been dropped while merging. > >> 56/58 needs a new version which can be send individually, > >> 53/58 is adding a deprecated feature, it can't go in as it is. > >> > >> Also can you please send a patch for the comment mentioned in 38/58? > > > > I will send two additional patches, one as a new version for 56/58, the other one to fix 'rte_panic()'. When pulling in the main branch, I see some checkpatches warnings (in order of criticality): Using rte_smp_[r/w]mb Using rte_panic/rte_exit Using compiler attribute directly Please could you fix them (at least first two) before the second series?
On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > 27/10/2020 12:37, Ferruh Yigit: >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: >>> On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: >>>> Series applied to dpdk-next-net/main, thanks. >>>> >>>> 57/58 & 58/58 has been distributed to the relevant commits while merging, >>>> please double check them in the upstream repo. >>>> >>>> 56/58 & 53/58 has been dropped while merging. >>>> 56/58 needs a new version which can be send individually, >>>> 53/58 is adding a deprecated feature, it can't go in as it is. >>>> >>>> Also can you please send a patch for the comment mentioned in 38/58? >>> >>> I will send two additional patches, one as a new version for 56/58, the other one to fix 'rte_panic()'. > > When pulling in the main branch, I see some checkpatches warnings > (in order of criticality): > Using rte_smp_[r/w]mb > Using rte_panic/rte_exit > Using compiler attribute directly > > Please could you fix them (at least first two) before the second series? > Hi Jiawen, Jian, I would like to double check if above request is clear, and if it is OK in your end? Thanks, ferruh
On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > 27/10/2020 12:37, Ferruh Yigit: > >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: > >>> On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: > >>>> Series applied to dpdk-next-net/main, thanks. > >>>> > >>>> 57/58 & 58/58 has been distributed to the relevant commits while > >>>> merging, please double check them in the upstream repo. > >>>> > >>>> 56/58 & 53/58 has been dropped while merging. > >>>> 56/58 needs a new version which can be send individually, > >>>> 53/58 is adding a deprecated feature, it can't go in as it is. > >>>> > >>>> Also can you please send a patch for the comment mentioned in 38/58? > >>> > >>> I will send two additional patches, one as a new version for 56/58, the > other one to fix 'rte_panic()'. > > > > When pulling in the main branch, I see some checkpatches warnings (in > > order of criticality): > > Using rte_smp_[r/w]mb > > Using rte_panic/rte_exit > > Using compiler attribute directly > > > > Please could you fix them (at least first two) before the second series? > > > > Hi Jiawen, Jian, > > I would like to double check if above request is clear, and if it is OK in your end? > > Thanks, > ferruh Sorry I did not see this message, I will add a patch to fix this problem today.
On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > 27/10/2020 12:37, Ferruh Yigit: > > >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: > > >>> On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: > > >>>> Series applied to dpdk-next-net/main, thanks. > > >>>> > > >>>> 57/58 & 58/58 has been distributed to the relevant commits while > > >>>> merging, please double check them in the upstream repo. > > >>>> > > >>>> 56/58 & 53/58 has been dropped while merging. > > >>>> 56/58 needs a new version which can be send individually, > > >>>> 53/58 is adding a deprecated feature, it can't go in as it is. > > >>>> > > >>>> Also can you please send a patch for the comment mentioned in 38/58? > > >>> > > >>> I will send two additional patches, one as a new version for > > >>> 56/58, the > > other one to fix 'rte_panic()'. > > > > > > When pulling in the main branch, I see some checkpatches warnings > > > (in order of criticality): > > > Using rte_smp_[r/w]mb > > > Using rte_panic/rte_exit > > > Using compiler attribute directly > > > > > > Please could you fix them (at least first two) before the second series? > > > > > > > Hi Jiawen, Jian, > > > > I would like to double check if above request is clear, and if it is OK in your > end? > > > > Thanks, > > ferruh > > Sorry I did not see this message, I will add a patch to fix this problem today. I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no function can be an alternative. I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to replace 'rte_smp_rmb()', is it the correct usage?
+Cc Konstantin and Honnappa for guidance 05/11/2020 09:55, Jiawen Wu: > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > When pulling in the main branch, I see some checkpatches warnings > > > > (in order of criticality): > > > > Using rte_smp_[r/w]mb > > > > Using rte_panic/rte_exit > > > > Using compiler attribute directly > > > > > > > > Please could you fix them (at least first two) before the second series? [...] > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no function > can be an alternative. > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to replace > 'rte_smp_rmb()', is it the correct usage?
<snip> > > +Cc Konstantin and Honnappa for guidance > > 05/11/2020 09:55, Jiawen Wu: > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > When pulling in the main branch, I see some checkpatches > > > > > warnings (in order of criticality): > > > > > Using rte_smp_[r/w]mb > > > > > Using rte_panic/rte_exit > > > > > Using compiler attribute directly > > > > > > > > > > Please could you fix them (at least first two) before the second series? > [...] > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no > > function can be an alternative. > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > replace 'rte_smp_rmb()', is it the correct usage? Yes, rte_atomic_thread_fence(__ATOMIC_ACQUIRE) is the correct code to replace 'rte_smp_rmb()'. However, I took a look at the code and it is not clear to me if the barrier is required or if it is in the correct place. > > >
On Friday, November 6, 2020 2:29 PM, Honnappa Nagarahalli wrote: > <snip> > > > > > +Cc Konstantin and Honnappa for guidance > > > > 05/11/2020 09:55, Jiawen Wu: > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > warnings (in order of criticality): > > > > > > Using rte_smp_[r/w]mb > > > > > > Using rte_panic/rte_exit > > > > > > Using compiler attribute directly > > > > > > > > > > > > Please could you fix them (at least first two) before the second series? > > [...] > > > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no > > > function can be an alternative. > > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > > replace 'rte_smp_rmb()', is it the correct usage? > Yes, rte_atomic_thread_fence(__ATOMIC_ACQUIRE) is the correct code to > replace 'rte_smp_rmb()'. > > However, I took a look at the code and it is not clear to me if the barrier is > required or if it is in the correct place. > Thanks for guidance. I want to add the barrier at the time before reading descriptors in Rx scan, to synchronize with the hardware. Actually I don't really understand the usage of this function. Could you please tell me more details?
<snip> > > > +Cc Konstantin and Honnappa for guidance > > > > > > 05/11/2020 09:55, Jiawen Wu: > > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > > warnings (in order of criticality): > > > > > > > Using rte_smp_[r/w]mb > > > > > > > Using rte_panic/rte_exit > > > > > > > Using compiler attribute directly > > > > > > > > > > > > > > Please could you fix them (at least first two) before the > > > > > > > second > series? > > > [...] > > > > > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is > > > > no function can be an alternative. > > > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > > > replace 'rte_smp_rmb()', is it the correct usage? > > Yes, rte_atomic_thread_fence(__ATOMIC_ACQUIRE) is the correct code to > > replace 'rte_smp_rmb()'. > > > > However, I took a look at the code and it is not clear to me if the > barrier is > > required or if it is in the correct place. > > > > Thanks for guidance. > > I want to add the barrier at the time before reading descriptors in Rx scan, to > synchronize with the hardware. > Actually I don't really understand the usage of this function. > Could you please tell me more details? Looking at the code again, qw0 should not be read before checking the status of the descriptors. So, barrier is required. But, I think the barrier can be moved down after the for loop that computes the number of status bits set. > >
<snip> > > +Cc Konstantin and Honnappa for guidance > > 05/11/2020 09:55, Jiawen Wu: > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > When pulling in the main branch, I see some checkpatches > > > > > warnings (in order of criticality): > > > > > Using rte_smp_[r/w]mb > > > > > Using rte_panic/rte_exit > > > > > Using compiler attribute directly > > > > > > > > > > Please could you fix them (at least first two) before the second series? Thomas, IMO, these should result in errors in checkpatch, not just warnings. Do you see any issues? > [...] > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no > > function can be an alternative. > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > replace 'rte_smp_rmb()', is it the correct usage? > > >
06/11/2020 19:21, Honnappa Nagarahalli: > > 05/11/2020 09:55, Jiawen Wu: > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > warnings (in order of criticality): > > > > > > Using rte_smp_[r/w]mb > > > > > > Using rte_panic/rte_exit > > > > > > Using compiler attribute directly > > > > > > > > > > > > Please could you fix them (at least first two) before the second series? > > Thomas, IMO, these should result in errors in checkpatch, not just warnings. > Do you see any issues? The problem is that there are too many false positives in checkpatch.
<snip> > > 06/11/2020 19:21, Honnappa Nagarahalli: > > > 05/11/2020 09:55, Jiawen Wu: > > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > > warnings (in order of criticality): > > > > > > > Using rte_smp_[r/w]mb > > > > > > > Using rte_panic/rte_exit > > > > > > > Using compiler attribute directly > > > > > > > > > > > > > > Please could you fix them (at least first two) before the second > series? > > > > Thomas, IMO, these should result in errors in checkpatch, not just warnings. > > Do you see any issues? > > The problem is that there are too many false positives in checkpatch. These two, mentioned above, should be pretty straight forward. Have you seen any false positives with these> > >
06/11/2020 20:56, Honnappa Nagarahalli: > > 06/11/2020 19:21, Honnappa Nagarahalli: > > > > 05/11/2020 09:55, Jiawen Wu: > > > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > > > warnings (in order of criticality): > > > > > > > > Using rte_smp_[r/w]mb > > > > > > > > Using rte_panic/rte_exit > > > > > > > > Using compiler attribute directly > > > > > > > > > > > > > > > > Please could you fix them (at least first two) before the second > > series? > > > > > > Thomas, IMO, these should result in errors in checkpatch, not just warnings. > > > Do you see any issues? > > > > The problem is that there are too many false positives in checkpatch. > > These two, mentioned above, should be pretty straight forward. Yes > Have you seen any false positives with these> No What do you propose to distinguish warnings and errors in patchwork? We can have a different return value in the script to categorize the checkpatch test in the right patchwork column.