mbox series

[v5,0/3] Tunnel Offload API

Message ID 20201015124154.13357-1-getelson@nvidia.com (mailing list archive)
Headers
Series Tunnel Offload API |

Message

Gregory Etelson Oct. 15, 2020, 12:41 p.m. UTC
  Tunnel Offload API provides hardware independent, unified model
to offload tunneled traffic. Key model elements are:
 - apply matches to both outer and inner packet headers
   during entire offload procedure;
 - restore outer header of partially offloaded packet;
 - model is implemented as a set of helper functions.

 v2:
 * documentation updates
 * MLX5 PMD implementation for tunnel offload
 * testpmd updates for tunnel offload

 v3:
 * documentation updates
 * MLX5 PMD updates
 * testpmd updates

 v4:
 * updated patch: allow negative values in flow rule types

v5:
 * rebase to next-net

Eli Britstein (1):
  ethdev: tunnel offload model

Gregory Etelson (2):
  ethdev: allow negative values in flow rule types
  app/testpmd: add commands for tunnel offload API

 app/test-pmd/cmdline_flow.c                 | 170 ++++++++++++-
 app/test-pmd/config.c                       | 252 +++++++++++++++++++-
 app/test-pmd/testpmd.c                      |   5 +-
 app/test-pmd/testpmd.h                      |  34 ++-
 app/test-pmd/util.c                         |  35 ++-
 doc/guides/prog_guide/rte_flow.rst          | 108 +++++++++
 doc/guides/rel_notes/release_20_11.rst      |  10 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  49 ++++
 lib/librte_ethdev/rte_ethdev_version.map    |   5 +
 lib/librte_ethdev/rte_flow.c                | 140 ++++++++++-
 lib/librte_ethdev/rte_flow.h                | 195 +++++++++++++++
 lib/librte_ethdev/rte_flow_driver.h         |  32 +++
 12 files changed, 1016 insertions(+), 19 deletions(-)
  

Comments

Ferruh Yigit Oct. 15, 2020, 10:47 p.m. UTC | #1
On 10/15/2020 1:41 PM, Gregory Etelson wrote:
> Tunnel Offload API provides hardware independent, unified model
> to offload tunneled traffic. Key model elements are:
>   - apply matches to both outer and inner packet headers
>     during entire offload procedure;
>   - restore outer header of partially offloaded packet;
>   - model is implemented as a set of helper functions.
> 
>   v2:
>   * documentation updates
>   * MLX5 PMD implementation for tunnel offload
>   * testpmd updates for tunnel offload
> 
>   v3:
>   * documentation updates
>   * MLX5 PMD updates
>   * testpmd updates
> 
>   v4:
>   * updated patch: allow negative values in flow rule types
> 
> v5:
>   * rebase to next-net
> 
> Eli Britstein (1):
>    ethdev: tunnel offload model
> 
> Gregory Etelson (2):
>    ethdev: allow negative values in flow rule types
>    app/testpmd: add commands for tunnel offload API
> 

32 build fails [1], can you please check?

Also there are a few typos [2].


[1]
../app/test-pmd/config.c: In function ‘port_flow_tunnel_list’:
../app/test-pmd/config.c:1580:18: error: format ‘%lu’ expects argument of type 
‘long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned 
int’} [-Werror=format=]

1580 |    printf(" id=%lu", flt->tunnel.tun_id);
      |                ~~^   ~~~~~~~~~~~~~~~~~~
      |                  |              |
      |                  |              uint64_t {aka long long unsigned int}
      |                  long unsigned int
      |                %llu


[2]
### ethdev: allow negative values in flow rule types

WARNING:TYPO_SPELLING: 'becase' may be misspelled - perhaps 'because'?
#17:
actions do not fit into this scheme becase PMD type values are

total: 0 errors, 1 warnings, 72 lines checked

### app/testpmd: add commands for tunnel offload API

WARNING:TYPO_SPELLING: 'argumens' may be misspelled - perhaps 'arguments'?
#87: FILE: app/test-pmd/cmdline_flow.c:79:
+       /* Tunnel argumens. */