| Message ID | 20201002085931.265699-1-maxime.coquelin@redhat.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 214F5A04BA; Fri, 2 Oct 2020 11:00:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E44BA1D559; Fri, 2 Oct 2020 11:00:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 5406F1D53A for <dev@dpdk.org>; Fri, 2 Oct 2020 11:00:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601629204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YXm8j+qbw2tlh+qDdci1TlZqpaO9+6pq9UIbCoqOZuk=; b=Ib+LBmCIbQ5P7z+tdALmV9or1xbx1b+VumGCtIiqcgYxFqf4d0DJGdsS9aziaWvm+BuD8Q 0gHCUYCTQ4tpVekiFryqwaTl1LPc9rFUIzrsVsbHgxuSt3OQeSpl47b84pJJN8K3vGIq9Q ZIP6R755bOZLnxD9S+zTPoWtDHxF7Xk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-l-1iGoNgPMiLNdYnLFtUcg-1; Fri, 02 Oct 2020 04:59:37 -0400 X-MC-Unique: l-1iGoNgPMiLNdYnLFtUcg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF1E980EFA6; Fri, 2 Oct 2020 08:59:35 +0000 (UTC) Received: from localhost.localdomain (unknown [10.36.110.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA88173677; Fri, 2 Oct 2020 08:59:33 +0000 (UTC) From: Maxime Coquelin <maxime.coquelin@redhat.com> To: dev@dpdk.org, akhil.goyal@nxp.com, nicolas.chautru@intel.com, ferruh.yigit@intel.com, trix@redhat.com Cc: Maxime Coquelin <maxime.coquelin@redhat.com> Date: Fri, 2 Oct 2020 10:59:29 +0200 Message-Id: <20201002085931.265699-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH 0/2] baseband: fix drivers API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
baseband: fix drivers API
|
|
Message
Maxime Coquelin
Oct. 2, 2020, 8:59 a.m. UTC
The series prefixes drivers APIs with rte_<drv_name>_ in order to avoid namespace pollution. These APIs are experimental, so no need to follow the deprecation process. Maxime Coquelin (2): baseband/fpga_5gnr_fec: fix API naming baseband/fpga_lte_fec: fix API naming app/test-bbdev/test_bbdev_perf.c | 12 ++++++------ doc/guides/bbdevs/fpga_5gnr_fec.rst | 14 +++++++------- doc/guides/bbdevs/fpga_lte_fec.rst | 14 +++++++------- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 +++++----- .../rte_pmd_bbdev_fpga_5gnr_fec_version.map | 2 +- .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 6 +++--- drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 +++++----- drivers/baseband/fpga_lte_fec/fpga_lte_fec.h | 6 +++--- .../rte_pmd_bbdev_fpga_lte_fec_version.map | 2 +- 9 files changed, 38 insertions(+), 38 deletions(-)
Comments
> > The series prefixes drivers APIs with rte_<drv_name>_ in > order to avoid namespace pollution. > > These APIs are experimental, so no need to follow the > deprecation process. > Added Fixes commit in patch description. Series applied to dpdk-next-crypto Thanks.
Hi Akhil, Adding Thomas as he pulls your tree. On 10/6/20 9:42 PM, Akhil Goyal wrote: > >> >> The series prefixes drivers APIs with rte_<drv_name>_ in >> order to avoid namespace pollution. >> >> These APIs are experimental, so no need to follow the >> deprecation process. >> > Added Fixes commit in patch description. Thanks for applying it to your tree. I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, because I thought it is was not a good idea to backport API changes, even if this is experimental it might be annoying for the user. Thomas, do you confirm? Thanks, Maxime > Series applied to dpdk-next-crypto > > Thanks. >
07/10/2020 10:22, Maxime Coquelin: > Hi Akhil, > > Adding Thomas as he pulls your tree. > > On 10/6/20 9:42 PM, Akhil Goyal wrote: > > > >> > >> The series prefixes drivers APIs with rte_<drv_name>_ in > >> order to avoid namespace pollution. > >> > >> These APIs are experimental, so no need to follow the > >> deprecation process. > >> > > Added Fixes commit in patch description. > > Thanks for applying it to your tree. > > I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, > because I thought it is was not a good idea to backport API changes, > even if this is experimental it might be annoying for the user. > > Thomas, do you confirm? Absolutely: API must not change in a stable branch. If an API is changed, it must be in the release notes. But stable branches are not allowed to update such sections of the release notes.
On 10/7/20 12:09 PM, Thomas Monjalon wrote: > 07/10/2020 10:22, Maxime Coquelin: >> Hi Akhil, >> >> Adding Thomas as he pulls your tree. >> >> On 10/6/20 9:42 PM, Akhil Goyal wrote: >>> >>>> >>>> The series prefixes drivers APIs with rte_<drv_name>_ in >>>> order to avoid namespace pollution. >>>> >>>> These APIs are experimental, so no need to follow the >>>> deprecation process. >>>> >>> Added Fixes commit in patch description. >> >> Thanks for applying it to your tree. >> >> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, >> because I thought it is was not a good idea to backport API changes, >> even if this is experimental it might be annoying for the user. >> >> Thomas, do you confirm? > > Absolutely: API must not change in a stable branch. > > If an API is changed, it must be in the release notes. Ok, even for experimental APIs? I thought not. > But stable branches are not allowed to update such sections > of the release notes. > >
07/10/2020 12:12, Maxime Coquelin: > On 10/7/20 12:09 PM, Thomas Monjalon wrote: > > 07/10/2020 10:22, Maxime Coquelin: > >> On 10/6/20 9:42 PM, Akhil Goyal wrote: > >>>> > >>>> The series prefixes drivers APIs with rte_<drv_name>_ in > >>>> order to avoid namespace pollution. > >>>> > >>>> These APIs are experimental, so no need to follow the > >>>> deprecation process. > >>>> > >>> Added Fixes commit in patch description. > >> > >> Thanks for applying it to your tree. > >> > >> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, > >> because I thought it is was not a good idea to backport API changes, > >> even if this is experimental it might be annoying for the user. > >> > >> Thomas, do you confirm? > > > > Absolutely: API must not change in a stable branch. > > > > If an API is changed, it must be in the release notes. > > Ok, even for experimental APIs? I thought not. Yes, experimental means it can change in the main branch without prior notice. But it must be noted when it's changed.
On 10/7/20 12:29 PM, Thomas Monjalon wrote: > 07/10/2020 12:12, Maxime Coquelin: >> On 10/7/20 12:09 PM, Thomas Monjalon wrote: >>> 07/10/2020 10:22, Maxime Coquelin: >>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: >>>>>> >>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in >>>>>> order to avoid namespace pollution. >>>>>> >>>>>> These APIs are experimental, so no need to follow the >>>>>> deprecation process. >>>>>> >>>>> Added Fixes commit in patch description. >>>> >>>> Thanks for applying it to your tree. >>>> >>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, >>>> because I thought it is was not a good idea to backport API changes, >>>> even if this is experimental it might be annoying for the user. >>>> >>>> Thomas, do you confirm? >>> >>> Absolutely: API must not change in a stable branch. >>> >>> If an API is changed, it must be in the release notes. >> >> Ok, even for experimental APIs? I thought not. > > Yes, experimental means it can change in the main branch > without prior notice. But it must be noted when it's changed. > > > Ok, do you want me to send add-on patches that you will squash when pulling Akhil's branch?
07/10/2020 12:52, Maxime Coquelin: > On 10/7/20 12:29 PM, Thomas Monjalon wrote: > > 07/10/2020 12:12, Maxime Coquelin: > >> On 10/7/20 12:09 PM, Thomas Monjalon wrote: > >>> 07/10/2020 10:22, Maxime Coquelin: > >>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: > >>>>>> > >>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in > >>>>>> order to avoid namespace pollution. > >>>>>> > >>>>>> These APIs are experimental, so no need to follow the > >>>>>> deprecation process. > >>>>>> > >>>>> Added Fixes commit in patch description. > >>>> > >>>> Thanks for applying it to your tree. > >>>> > >>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, > >>>> because I thought it is was not a good idea to backport API changes, > >>>> even if this is experimental it might be annoying for the user. > >>>> > >>>> Thomas, do you confirm? > >>> > >>> Absolutely: API must not change in a stable branch. > >>> > >>> If an API is changed, it must be in the release notes. > >> > >> Ok, even for experimental APIs? I thought not. > > > > Yes, experimental means it can change in the main branch > > without prior notice. But it must be noted when it's changed. > > Ok, do you want me to send add-on patches that you will squash when > pulling Akhil's branch? Yes please
07/10/2020 13:06, Thomas Monjalon: > 07/10/2020 12:52, Maxime Coquelin: > > On 10/7/20 12:29 PM, Thomas Monjalon wrote: > > > 07/10/2020 12:12, Maxime Coquelin: > > >> On 10/7/20 12:09 PM, Thomas Monjalon wrote: > > >>> 07/10/2020 10:22, Maxime Coquelin: > > >>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: > > >>>>>> > > >>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in > > >>>>>> order to avoid namespace pollution. > > >>>>>> > > >>>>>> These APIs are experimental, so no need to follow the > > >>>>>> deprecation process. > > >>>>>> > > >>>>> Added Fixes commit in patch description. > > >>>> > > >>>> Thanks for applying it to your tree. > > >>>> > > >>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, > > >>>> because I thought it is was not a good idea to backport API changes, > > >>>> even if this is experimental it might be annoying for the user. > > >>>> > > >>>> Thomas, do you confirm? > > >>> > > >>> Absolutely: API must not change in a stable branch. > > >>> > > >>> If an API is changed, it must be in the release notes. > > >> > > >> Ok, even for experimental APIs? I thought not. > > > > > > Yes, experimental means it can change in the main branch > > > without prior notice. But it must be noted when it's changed. > > > > Ok, do you want me to send add-on patches that you will squash when > > pulling Akhil's branch? > > Yes please Better: Akhil can squash in his tree and remove the Cc: stable tag.
On 10/7/20 1:06 PM, Thomas Monjalon wrote: > 07/10/2020 12:52, Maxime Coquelin: >> On 10/7/20 12:29 PM, Thomas Monjalon wrote: >>> 07/10/2020 12:12, Maxime Coquelin: >>>> On 10/7/20 12:09 PM, Thomas Monjalon wrote: >>>>> 07/10/2020 10:22, Maxime Coquelin: >>>>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: >>>>>>>> >>>>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in >>>>>>>> order to avoid namespace pollution. >>>>>>>> >>>>>>>> These APIs are experimental, so no need to follow the >>>>>>>> deprecation process. >>>>>>>> >>>>>>> Added Fixes commit in patch description. >>>>>> >>>>>> Thanks for applying it to your tree. >>>>>> >>>>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, >>>>>> because I thought it is was not a good idea to backport API changes, >>>>>> even if this is experimental it might be annoying for the user. >>>>>> >>>>>> Thomas, do you confirm? >>>>> >>>>> Absolutely: API must not change in a stable branch. >>>>> >>>>> If an API is changed, it must be in the release notes. >>>> >>>> Ok, even for experimental APIs? I thought not. >>> >>> Yes, experimental means it can change in the main branch >>> without prior notice. But it must be noted when it's changed. >> >> Ok, do you want me to send add-on patches that you will squash when >> pulling Akhil's branch? > > Yes please OK, will do that later today. Thanks, Maxime
> 07/10/2020 13:06, Thomas Monjalon: > > 07/10/2020 12:52, Maxime Coquelin: > > > On 10/7/20 12:29 PM, Thomas Monjalon wrote: > > > > 07/10/2020 12:12, Maxime Coquelin: > > > >> On 10/7/20 12:09 PM, Thomas Monjalon wrote: > > > >>> 07/10/2020 10:22, Maxime Coquelin: > > > >>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: > > > >>>>>> > > > >>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in > > > >>>>>> order to avoid namespace pollution. > > > >>>>>> > > > >>>>>> These APIs are experimental, so no need to follow the > > > >>>>>> deprecation process. > > > >>>>>> > > > >>>>> Added Fixes commit in patch description. > > > >>>> > > > >>>> Thanks for applying it to your tree. > > > >>>> > > > >>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, > > > >>>> because I thought it is was not a good idea to backport API changes, > > > >>>> even if this is experimental it might be annoying for the user. > > > >>>> > > > >>>> Thomas, do you confirm? > > > >>> > > > >>> Absolutely: API must not change in a stable branch. > > > >>> > > > >>> If an API is changed, it must be in the release notes. > > > >> > > > >> Ok, even for experimental APIs? I thought not. > > > > > > > > Yes, experimental means it can change in the main branch > > > > without prior notice. But it must be noted when it's changed. > > > > > > Ok, do you want me to send add-on patches that you will squash when > > > pulling Akhil's branch? > > > > Yes please > > Better: Akhil can squash in his tree and remove the Cc: stable tag. Sure will do that.
On 10/7/20 2:05 PM, Akhil Goyal wrote: >> 07/10/2020 13:06, Thomas Monjalon: >>> 07/10/2020 12:52, Maxime Coquelin: >>>> On 10/7/20 12:29 PM, Thomas Monjalon wrote: >>>>> 07/10/2020 12:12, Maxime Coquelin: >>>>>> On 10/7/20 12:09 PM, Thomas Monjalon wrote: >>>>>>> 07/10/2020 10:22, Maxime Coquelin: >>>>>>>> On 10/6/20 9:42 PM, Akhil Goyal wrote: >>>>>>>>>> >>>>>>>>>> The series prefixes drivers APIs with rte_<drv_name>_ in >>>>>>>>>> order to avoid namespace pollution. >>>>>>>>>> >>>>>>>>>> These APIs are experimental, so no need to follow the >>>>>>>>>> deprecation process. >>>>>>>>>> >>>>>>>>> Added Fixes commit in patch description. >>>>>>>> >>>>>>>> Thanks for applying it to your tree. >>>>>>>> >>>>>>>> I did not add Fixes tag and Cc'ed stable@dpdk.org on purpose, >>>>>>>> because I thought it is was not a good idea to backport API changes, >>>>>>>> even if this is experimental it might be annoying for the user. >>>>>>>> >>>>>>>> Thomas, do you confirm? >>>>>>> >>>>>>> Absolutely: API must not change in a stable branch. >>>>>>> >>>>>>> If an API is changed, it must be in the release notes. >>>>>> >>>>>> Ok, even for experimental APIs? I thought not. >>>>> >>>>> Yes, experimental means it can change in the main branch >>>>> without prior notice. But it must be noted when it's changed. >>>> >>>> Ok, do you want me to send add-on patches that you will squash when >>>> pulling Akhil's branch? >>> >>> Yes please >> >> Better: Akhil can squash in his tree and remove the Cc: stable tag. > > Sure will do that. > Thanks Akhil for handling it, I just posted the release note patch. Maxime