mbox series

[v3,0/2] Support EAL debug functions on Windows

Message ID 20200623205721.21200-1-talshn@mellanox.com (mailing list archive)
Headers
Series Support EAL debug functions on Windows |

Message

Tal Shnaiderman June 23, 2020, 8:57 p.m. UTC 
  From: Tal Shnaiderman <talshn@mellanox.com>

This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup.

Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplication.

---
v3: Fix license comment[ThomasM] 

v2: Fix style and cross-compiling MinGW-w64 on Linux error[DmitryK]
---


Tal Shnaiderman (2):
  eal: move OS common debug functions to single file
  eal/windows: support debug calls

 config/meson.build                       |  1 +
 lib/librte_eal/common/eal_common_debug.c | 59 +++++++++++++++++++++++++
 lib/librte_eal/common/meson.build        |  2 +
 lib/librte_eal/freebsd/Makefile          |  1 +
 lib/librte_eal/freebsd/eal_debug.c       | 49 --------------------
 lib/librte_eal/linux/Makefile            |  1 +
 lib/librte_eal/linux/eal_debug.c         | 49 --------------------
 lib/librte_eal/windows/eal.c             |  9 +++-
 lib/librte_eal/windows/eal_debug.c       | 76 ++++++++++++++++++++++++++++----
 9 files changed, 140 insertions(+), 107 deletions(-)
 create mode 100644 lib/librte_eal/common/eal_common_debug.c

Comments

Dmitry Kozlyuk June 23, 2020, 10:48 p.m. UTC | #1 
On Tue, 23 Jun 2020 23:57:19 +0300, talshn@mellanox.com wrote:

> From: Tal Shnaiderman <talshn@mellanox.com>
> 
> This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup.
> 
> Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplication.
> 
> ---
> v3: Fix license comment[ThomasM] 
> 
> v2: Fix style and cross-compiling MinGW-w64 on Linux error[DmitryK]
> ---

Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Thomas Monjalon June 24, 2020, 9:17 a.m. UTC | #2 
24/06/2020 00:48, Dmitry Kozlyuk:
> On Tue, 23 Jun 2020 23:57:19 +0300, talshn@mellanox.com wrote:
> 
> > From: Tal Shnaiderman <talshn@mellanox.com>
> > 
> > This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup.
> > 
> > Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplication.
> 
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks