mbox series

[v8,0/3] eal timer split and implementation for Windows

Message ID 20200614084348.22404-1-fady@mellanox.com (mailing list archive)
Headers
Series eal timer split and implementation for Windows |

Message

Fady Bader June 14, 2020, 8:43 a.m. UTC
  This patchset splits OS dependent EAL timer functions and implements them for windows.

v2:
    * fixing styles and correctness errors.
v3:
    * fixing correctness, get_tsc_freq was reimplemented.
v4:
    * rebasing to the new version of "Windows basic memory management" series.
    * fixing styles and correctness errors.
v5:
    * breaking the dependency on "Windows basic memory management" series.
    * fixing correctness errors and warnings.
v6:
    * fixing styles and correctness errors.
v7:
    * fixing make errors.
v8:
    * fixing error handling issue.
    * removed unneded headers.

Fady Bader (3):
  timer: move from common to Unix directory
  eal: proc type function for Windows
  timer: support EAL functions on Windows

 lib/librte_eal/common/eal_common_timer.c | 22 --------
 lib/librte_eal/common/meson.build        |  1 +
 lib/librte_eal/freebsd/Makefile          |  4 ++
 lib/librte_eal/linux/Makefile            |  4 ++
 lib/librte_eal/meson.build               |  4 ++
 lib/librte_eal/unix/eal_unix_timer.c     | 29 ++++++++++
 lib/librte_eal/unix/meson.build          |  6 +++
 lib/librte_eal/windows/eal.c             | 12 +++++
 lib/librte_eal/windows/eal_timer.c       | 90 ++++++++++++++++++++++++++++++++
 lib/librte_eal/windows/include/rte_os.h  |  2 +
 lib/librte_eal/windows/meson.build       |  1 +
 11 files changed, 153 insertions(+), 22 deletions(-)
 create mode 100644 lib/librte_eal/unix/eal_unix_timer.c
 create mode 100644 lib/librte_eal/unix/meson.build
 create mode 100644 lib/librte_eal/windows/eal_timer.c
  

Comments

Tal Shnaiderman June 14, 2020, 8:53 a.m. UTC | #1
> Subject: [PATCH v8 0/3] eal timer split and implementation for Windows
> 
> This patchset splits OS dependent EAL timer functions and implements them
> for windows.
> 
> v2:
>     * fixing styles and correctness errors.
> v3:
>     * fixing correctness, get_tsc_freq was reimplemented.
> v4:
>     * rebasing to the new version of "Windows basic memory management"
> series.
>     * fixing styles and correctness errors.
> v5:
>     * breaking the dependency on "Windows basic memory management"
> series.
>     * fixing correctness errors and warnings.
> v6:
>     * fixing styles and correctness errors.
> v7:
>     * fixing make errors.
> v8:
>     * fixing error handling issue.
>     * removed unneded headers.
> 
> Fady Bader (3):
>   timer: move from common to Unix directory
>   eal: proc type function for Windows
>   timer: support EAL functions on Windows
> 
>  lib/librte_eal/common/eal_common_timer.c | 22 --------
>  lib/librte_eal/common/meson.build        |  1 +
>  lib/librte_eal/freebsd/Makefile          |  4 ++
>  lib/librte_eal/linux/Makefile            |  4 ++
>  lib/librte_eal/meson.build               |  4 ++
>  lib/librte_eal/unix/eal_unix_timer.c     | 29 ++++++++++
>  lib/librte_eal/unix/meson.build          |  6 +++
>  lib/librte_eal/windows/eal.c             | 12 +++++
>  lib/librte_eal/windows/eal_timer.c       | 90
> ++++++++++++++++++++++++++++++++
>  lib/librte_eal/windows/include/rte_os.h  |  2 +
>  lib/librte_eal/windows/meson.build       |  1 +
>  11 files changed, 153 insertions(+), 22 deletions(-)  create mode 100644
> lib/librte_eal/unix/eal_unix_timer.c
>  create mode 100644 lib/librte_eal/unix/meson.build  create mode 100644
> lib/librte_eal/windows/eal_timer.c
> 
> --
> 2.16.1.windows.4

Tested-by: Tal Shnaiderman <talshn@mellanox.com>
Reviewed-by: Tal Shnaiderman <talshn@mellanox.com>
  
Thomas Monjalon June 16, 2020, 8:49 a.m. UTC | #2
14/06/2020 10:43, Fady Bader:
> This patchset splits OS dependent EAL timer functions and implements them for windows.
> 
> v2:
>     * fixing styles and correctness errors.
> v3:
>     * fixing correctness, get_tsc_freq was reimplemented.
> v4:
>     * rebasing to the new version of "Windows basic memory management" series.
>     * fixing styles and correctness errors.
> v5:
>     * breaking the dependency on "Windows basic memory management" series.
>     * fixing correctness errors and warnings.
> v6:
>     * fixing styles and correctness errors.
> v7:
>     * fixing make errors.
> v8:
>     * fixing error handling issue.
>     * removed unneded headers.

Please use --in-reply-to to keep all versions in the same thread.
  
Dmitry Kozlyuk June 16, 2020, 9:08 p.m. UTC | #3
On Sun, 14 Jun 2020 11:43:45 +0300
Fady Bader <fady@mellanox.com> wrote:

> v8:
>     * fixing error handling issue.
>     * removed unneded headers.

The patchset now needs a trivial rebase to apply.
Feel free to propagate my previous Tested-by.