[0/9] test/crypto: code cleanup

  Certain cases were put in PMD specific checks which
should be avoided. Appropriate capability/supported
feature flag should be checked before executing the
test case.
Added 1 missing feature flag for non-byte aligned data
Enabled it for SNOW/ZUC/KASUMI PMDs.
All the PMD owners are requested to verify these changes
and let me know in case there are some issues.

Also removed PMD specific testsuite for dpaa_sec and dpaa2_sec.
It is requested to all PMD owners to remove their PMD specific
suites and move to generic testsuite.

Akhil Goyal (9):
  cryptodev: add feature flag for non-byte aligned data
  test/crypto: skip unsupported non-byte aligned cases
  test/crypto: skip unsupported SG cases
  test/crypto: skip unsupported sessionless cases
  test/crypto: skip unsupported session
  test/crypto: run PDCP cases if supported
  test/crypto: remove dpaaX_sec specific testsuites
  test/crypto: remove QAT specific check
  test/crypto: remove unused variable

 app/test/test_cryptodev.c                  | 845 +++++----------------
 doc/guides/cryptodevs/features/default.ini |   1 +
 doc/guides/cryptodevs/features/kasumi.ini  |   1 +
 doc/guides/cryptodevs/features/snow3g.ini  |   1 +
 doc/guides/cryptodevs/features/zuc.ini     |   1 +
 drivers/crypto/kasumi/rte_kasumi_pmd.c     |   1 +
 drivers/crypto/snow3g/rte_snow3g_pmd.c     |   1 +
 drivers/crypto/zuc/rte_zuc_pmd.c           |   1 +
 lib/librte_cryptodev/rte_cryptodev.c       |   2 +
 lib/librte_cryptodev/rte_cryptodev.h       |   2 +
 10 files changed, 194 insertions(+), 662 deletions(-)
  

Hi Akhil.

I checked these PMDs work properly after applying this patch series:
QAT, SW_ZUC, SW_SNOW3G, SCHEDULER, NULL

But there is a problem with OpenSSL PMD - it fails in one test now:
+ TestCase [15] : test_stats failed

As it is software-only PMD, you can verify this also on your side. Please do.

Adam Dybkowski


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Akhil Goyal
> Sent: Monday, 4 May, 2020 23:58
> To: dev@dpdk.org
> Cc: Ruifeng.Wang@arm.com; Doherty, Declan <declan.doherty@intel.com>;
> asomalap@amd.com; anoobj@marvell.com; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> tdu@semihalf.com; rnagadheeraj@marvell.com; adwivedi@marvell.com;
> G.Singh@nxp.com; hemant.agrawal@nxp.com; jianjay.zhou@huawei.com;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: [dpdk-dev] [PATCH 0/9] test/crypto: code cleanup
> 
> Certain cases were put in PMD specific checks which should be avoided.
> Appropriate capability/supported feature flag should be checked before
> executing the test case.
> Added 1 missing feature flag for non-byte aligned data Enabled it for
> SNOW/ZUC/KASUMI PMDs.
> All the PMD owners are requested to verify these changes and let me know
> in case there are some issues.
> 
> Also removed PMD specific testsuite for dpaa_sec and dpaa2_sec.
> It is requested to all PMD owners to remove their PMD specific suites and
> move to generic testsuite.
> 
> Akhil Goyal (9):
>   cryptodev: add feature flag for non-byte aligned data
>   test/crypto: skip unsupported non-byte aligned cases
>   test/crypto: skip unsupported SG cases
>   test/crypto: skip unsupported sessionless cases
>   test/crypto: skip unsupported session
>   test/crypto: run PDCP cases if supported
>   test/crypto: remove dpaaX_sec specific testsuites
>   test/crypto: remove QAT specific check
>   test/crypto: remove unused variable
> 
>  app/test/test_cryptodev.c                  | 845 +++++----------------
>  doc/guides/cryptodevs/features/default.ini |   1 +
>  doc/guides/cryptodevs/features/kasumi.ini  |   1 +
>  doc/guides/cryptodevs/features/snow3g.ini  |   1 +
>  doc/guides/cryptodevs/features/zuc.ini     |   1 +
>  drivers/crypto/kasumi/rte_kasumi_pmd.c     |   1 +
>  drivers/crypto/snow3g/rte_snow3g_pmd.c     |   1 +
>  drivers/crypto/zuc/rte_zuc_pmd.c           |   1 +
>  lib/librte_cryptodev/rte_cryptodev.c       |   2 +
>  lib/librte_cryptodev/rte_cryptodev.h       |   2 +
>  10 files changed, 194 insertions(+), 662 deletions(-)
> 
> --
> 2.17.1
  

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, May 5, 2020 5:58 AM
> To: dev@dpdk.org
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; declan.doherty@intel.com;
> asomalap@amd.com; anoobj@marvell.com; roy.fan.zhang@intel.com;
> fiona.trahe@intel.com; tdu@semihalf.com; rnagadheeraj@marvell.com;
> adwivedi@marvell.com; G.Singh@nxp.com; hemant.agrawal@nxp.com;
> jianjay.zhou@huawei.com; pablo.de.lara.guarch@intel.com;
> Akhil.goyal@nxp.com
> Subject: [PATCH 0/9] test/crypto: code cleanup
> 
> Certain cases were put in PMD specific checks which should be avoided.
> Appropriate capability/supported feature flag should be checked before
> executing the test case.
> Added 1 missing feature flag for non-byte aligned data Enabled it for
> SNOW/ZUC/KASUMI PMDs.
> All the PMD owners are requested to verify these changes and let me know
> in case there are some issues.
> 
> Also removed PMD specific testsuite for dpaa_sec and dpaa2_sec.
> It is requested to all PMD owners to remove their PMD specific suites and
> move to generic testsuite.
> 
> Akhil Goyal (9):
>   cryptodev: add feature flag for non-byte aligned data
>   test/crypto: skip unsupported non-byte aligned cases
>   test/crypto: skip unsupported SG cases
>   test/crypto: skip unsupported sessionless cases
>   test/crypto: skip unsupported session
>   test/crypto: run PDCP cases if supported
>   test/crypto: remove dpaaX_sec specific testsuites
>   test/crypto: remove QAT specific check
>   test/crypto: remove unused variable
> 
>  app/test/test_cryptodev.c                  | 845 +++++----------------
>  doc/guides/cryptodevs/features/default.ini |   1 +
>  doc/guides/cryptodevs/features/kasumi.ini  |   1 +
>  doc/guides/cryptodevs/features/snow3g.ini  |   1 +
>  doc/guides/cryptodevs/features/zuc.ini     |   1 +
>  drivers/crypto/kasumi/rte_kasumi_pmd.c     |   1 +
>  drivers/crypto/snow3g/rte_snow3g_pmd.c     |   1 +
>  drivers/crypto/zuc/rte_zuc_pmd.c           |   1 +
>  lib/librte_cryptodev/rte_cryptodev.c       |   2 +
>  lib/librte_cryptodev/rte_cryptodev.h       |   2 +
>  10 files changed, 194 insertions(+), 662 deletions(-)
> 
> --
> 2.17.1

Tested on armv8 platform. 
armv8 PMD and null PMD are OK.
cryptodev_openssl_autotest has a failure.
  

Hi Ruifeng,
> 
> Tested on armv8 platform.
> armv8 PMD and null PMD are OK.
> cryptodev_openssl_autotest has a failure.

I have added a workaround to fix the openssl failure in v2. It is caused by the 8/9 patch
Of the patchset due to some dependency. I have altered the execution of two tests
And now the cases are passing on openssl. Please check.

If the workaround is not acceptable, we can skip the 8/9 patch in RC2 which is on Monday
And debug the actual cause afterwards.

Could you please Ack the other patches so that it can be applied in RC2?

Regards,
Akhil