mbox series

[0/3] RFC: Support disabling DPDK drivers in meson builds

Message ID 20190925145531.52705-1-bruce.richardson@intel.com (mailing list archive)
Headers
Series RFC: Support disabling DPDK drivers in meson builds |

Message

Bruce Richardson Sept. 25, 2019, 2:55 p.m. UTC 
  Following on from the discussion about meson at userspace 2019, here is
a patchset which allows a user to disable drivers in a DPDK build. This
set also includes the changes necessary to recursively disable any
drivers that depend upon the disabled one, e.g. disabling mempool/dpaa
also disables net/dpaa and event/dpaa with suitable reasons provided in
the output summary at the end of the meson configuration phase.

A number of changes are made to the lib/meson.build file too, in order
to keep the general logic flow between drivers/meson.build and
lib/meson.build as similar as possible.

Example of use:

	meson -Ddisable_drivers=mempool/dpaa,net/i40e build

Bruce Richardson (3):
  build: align variable names between drivers and libs
  build: process dependencies before main build check
  build: support disabling drivers with meson

 drivers/meson.build | 45 +++++++++++++++++++++++++++------------------
 lib/meson.build     | 23 +++++++++++++----------
 meson_options.txt   |  2 ++
 3 files changed, 42 insertions(+), 28 deletions(-)

Comments

Luca Boccassi Sept. 25, 2019, 6:01 p.m. UTC | #1 
On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote:
> Following on from the discussion about meson at userspace 2019, here
> is
> a patchset which allows a user to disable drivers in a DPDK build.
> This
> set also includes the changes necessary to recursively disable any
> drivers that depend upon the disabled one, e.g. disabling
> mempool/dpaa
> also disables net/dpaa and event/dpaa with suitable reasons provided
> in
> the output summary at the end of the meson configuration phase.
> 
> A number of changes are made to the lib/meson.build file too, in
> order
> to keep the general logic flow between drivers/meson.build and
> lib/meson.build as similar as possible.
> 
> Example of use:
> 
> 	meson -Ddisable_drivers=mempool/dpaa,net/i40e build
> 
> Bruce Richardson (3):
>   build: align variable names between drivers and libs
>   build: process dependencies before main build check
>   build: support disabling drivers with meson
> 
>  drivers/meson.build | 45 +++++++++++++++++++++++++++--------------
> ----
>  lib/meson.build     | 23 +++++++++++++----------
>  meson_options.txt   |  2 ++
>  3 files changed, 42 insertions(+), 28 deletions(-)

Series-grumbly-acked-by: Luca Boccassi <bluca@debian.org>
Bruce Richardson Sept. 26, 2019, 8:33 a.m. UTC | #2 
On Wed, Sep 25, 2019 at 07:01:10PM +0100, Luca Boccassi wrote:
> On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote:
> > Following on from the discussion about meson at userspace 2019, here
> > is
> > a patchset which allows a user to disable drivers in a DPDK build.
> > This
> > set also includes the changes necessary to recursively disable any
> > drivers that depend upon the disabled one, e.g. disabling
> > mempool/dpaa
> > also disables net/dpaa and event/dpaa with suitable reasons provided
> > in
> > the output summary at the end of the meson configuration phase.
> > 
> > A number of changes are made to the lib/meson.build file too, in
> > order
> > to keep the general logic flow between drivers/meson.build and
> > lib/meson.build as similar as possible.
> > 
> > Example of use:
> > 
> > 	meson -Ddisable_drivers=mempool/dpaa,net/i40e build
> > 
> > Bruce Richardson (3):
> >   build: align variable names between drivers and libs
> >   build: process dependencies before main build check
> >   build: support disabling drivers with meson
> > 
> >  drivers/meson.build | 45 +++++++++++++++++++++++++++--------------
> > ----
> >  lib/meson.build     | 23 +++++++++++++----------
> >  meson_options.txt   |  2 ++
> >  3 files changed, 42 insertions(+), 28 deletions(-)
> 
> Series-grumbly-acked-by: Luca Boccassi <bluca@debian.org>
>
Not exactly doing my happy-dance here myself about this set, but I think
it's something those building their own DPDK will appreciate.
Morten Brørup Sept. 26, 2019, 3:28 p.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, September 26, 2019 10:34 AM
> To: Luca Boccassi
> Cc: dev@dpdk.org; thomas@monjalon.net; Morten Brørup; techboard@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/3] RFC: Support disabling DPDK drivers in
> meson builds
> 
> On Wed, Sep 25, 2019 at 07:01:10PM +0100, Luca Boccassi wrote:
> > On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote:
> > > Following on from the discussion about meson at userspace 2019, here
> > > is
> > > a patchset which allows a user to disable drivers in a DPDK build.
> > > This
> > > set also includes the changes necessary to recursively disable any
> > > drivers that depend upon the disabled one, e.g. disabling
> > > mempool/dpaa
> > > also disables net/dpaa and event/dpaa with suitable reasons provided
> > > in
> > > the output summary at the end of the meson configuration phase.
> > >
> > > A number of changes are made to the lib/meson.build file too, in
> > > order
> > > to keep the general logic flow between drivers/meson.build and
> > > lib/meson.build as similar as possible.
> > >
> > > Example of use:
> > >
> > > 	meson -Ddisable_drivers=mempool/dpaa,net/i40e build
> > >
> > > Bruce Richardson (3):
> > >   build: align variable names between drivers and libs
> > >   build: process dependencies before main build check
> > >   build: support disabling drivers with meson
> > >
> > >  drivers/meson.build | 45 +++++++++++++++++++++++++++--------------
> > > ----
> > >  lib/meson.build     | 23 +++++++++++++----------
> > >  meson_options.txt   |  2 ++
> > >  3 files changed, 42 insertions(+), 28 deletions(-)
> >
> > Series-grumbly-acked-by: Luca Boccassi <bluca@debian.org>
> >
> Not exactly doing my happy-dance here myself about this set, but I think
> it's something those building their own DPDK will appreciate.

Yes, we will.


Med venlig hilsen / kind regards
- Morten Brørup
Maxime Coquelin Sept. 27, 2019, 7:14 a.m. UTC | #4 
On 9/25/19 4:55 PM, Bruce Richardson wrote:
> Following on from the discussion about meson at userspace 2019, here is
> a patchset which allows a user to disable drivers in a DPDK build. This
> set also includes the changes necessary to recursively disable any
> drivers that depend upon the disabled one, e.g. disabling mempool/dpaa
> also disables net/dpaa and event/dpaa with suitable reasons provided in
> the output summary at the end of the meson configuration phase.
> 
> A number of changes are made to the lib/meson.build file too, in order
> to keep the general logic flow between drivers/meson.build and
> lib/meson.build as similar as possible.
> 
> Example of use:
> 
> 	meson -Ddisable_drivers=mempool/dpaa,net/i40e build
> 
> Bruce Richardson (3):
>   build: align variable names between drivers and libs
>   build: process dependencies before main build check
>   build: support disabling drivers with meson
> 
>  drivers/meson.build | 45 +++++++++++++++++++++++++++------------------
>  lib/meson.build     | 23 +++++++++++++----------
>  meson_options.txt   |  2 ++
>  3 files changed, 42 insertions(+), 28 deletions(-)
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Thomas Monjalon Oct. 23, 2019, 9:24 p.m. UTC | #5 
25/09/2019 20:01, Luca Boccassi:
> On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote:
> > Bruce Richardson (3):
> >   build: align variable names between drivers and libs
> >   build: process dependencies before main build check
> >   build: support disabling drivers with meson
> 
> Series-grumbly-acked-by: Luca Boccassi <bluca@debian.org>

Applied, thanks for implementing a community request