mbox series

[v5,0/2] failsafe: add xstats

Message ID 20190919131729.28681-1-stephen@networkplumber.org (mailing list archive)
Headers
Series failsafe: add xstats |

Message

Stephen Hemminger Sept. 19, 2019, 1:17 p.m. UTC 
  A useful feature of netvsc PMD is the ability to see how many
packets
were processed through the VF device. This patch set adds a similar
(but more limited) capability to failsafe driver.

Since failsafe doesn't have top level xstats, this set uses the generic
xstats that exist already as a base then adds the sub-device xstats
to that.

v5 - fix ethdev map file
v4 - rebase to 19.11
v3 - rebase to 19.08

Stephen Hemminger (2):
  ethdev: expose basic xstats for driver use
  net/failsafe: implement xstats

 drivers/net/failsafe/failsafe_ops.c      | 135 +++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev.c           |  17 ++-
 lib/librte_ethdev/rte_ethdev_driver.h    |  65 +++++++++++
 lib/librte_ethdev/rte_ethdev_version.map |   5 +
 4 files changed, 213 insertions(+), 9 deletions(-)

Comments

Stephen Hemminger Oct. 14, 2019, 5:04 p.m. UTC | #1 
On Thu, 19 Sep 2019 15:17:27 +0200
Stephen Hemminger <stephen@networkplumber.org> wrote:

> A useful feature of netvsc PMD is the ability to see how many
> packets
> were processed through the VF device. This patch set adds a similar
> (but more limited) capability to failsafe driver.
> 
> Since failsafe doesn't have top level xstats, this set uses the generic
> xstats that exist already as a base then adds the sub-device xstats
> to that.
> 
> v5 - fix ethdev map file
> v4 - rebase to 19.11
> v3 - rebase to 19.08
> 
> Stephen Hemminger (2):
>   ethdev: expose basic xstats for driver use
>   net/failsafe: implement xstats
> 
>  drivers/net/failsafe/failsafe_ops.c      | 135 +++++++++++++++++++++++
>  lib/librte_ethdev/rte_ethdev.c           |  17 ++-
>  lib/librte_ethdev/rte_ethdev_driver.h    |  65 +++++++++++
>  lib/librte_ethdev/rte_ethdev_version.map |   5 +
>  4 files changed, 213 insertions(+), 9 deletions(-)
> 

Why are these patches still not merged?
Ferruh Yigit Oct. 15, 2019, 9:08 a.m. UTC | #2 
On 10/14/2019 6:04 PM, Stephen Hemminger wrote:
> On Thu, 19 Sep 2019 15:17:27 +0200
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
>> A useful feature of netvsc PMD is the ability to see how many
>> packets
>> were processed through the VF device. This patch set adds a similar
>> (but more limited) capability to failsafe driver.
>>
>> Since failsafe doesn't have top level xstats, this set uses the generic
>> xstats that exist already as a base then adds the sub-device xstats
>> to that.
>>
>> v5 - fix ethdev map file
>> v4 - rebase to 19.11
>> v3 - rebase to 19.08
>>
>> Stephen Hemminger (2):
>>   ethdev: expose basic xstats for driver use
>>   net/failsafe: implement xstats
>>
>>  drivers/net/failsafe/failsafe_ops.c      | 135 +++++++++++++++++++++++
>>  lib/librte_ethdev/rte_ethdev.c           |  17 ++-
>>  lib/librte_ethdev/rte_ethdev_driver.h    |  65 +++++++++++
>>  lib/librte_ethdev/rte_ethdev_version.map |   5 +
>>  4 files changed, 213 insertions(+), 9 deletions(-)
>>
> 
> Why are these patches still not merged?
> 

Because patches are not reviewed yet, specially ethdev one.