mbox series

[v3,0/3] improve MAC swap performance

Message ID 20181216005835.23679-1-qi.z.zhang@intel.com (mailing list archive)
Headers
Series improve MAC swap performance |

Message

Qi Zhang Dec. 16, 2018, 12:58 a.m. UTC
  Improved testpmd macswap performance for x86 by take advantage of SSE
instructions.
On a broadwell 1.6GHz sever with a i40e 25G NIC.
We abserve 17.7% performance improvement for testpmd's macswap test.

v3:
- fix wrong comment after #endif.
- fix EOF space line.
- add comment to explain shuffle mask.

v2:
- replace PKT_TX_VLAN_PKT/PKT_TX_QINQ_PKT with PKT_TX_VLAN/PKT_TX_QINQ
- only set vlan / outer_vlan when related ol_flags is set.
- fix coding style

*** BLURB HERE ***

Qi Zhang (3):
  app/testpmd: code refactory for macswap
  app/testpmd: improve MAC swap performance for x86
  app/testpmd: further improve MAC swap performance for x86

 app/test-pmd/macswap.c        | 36 +++---------------
 app/test-pmd/macswap.h        | 40 ++++++++++++++++++++
 app/test-pmd/macswap_common.h | 46 +++++++++++++++++++++++
 app/test-pmd/macswap_sse.h    | 87 +++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 179 insertions(+), 30 deletions(-)
 create mode 100644 app/test-pmd/macswap.h
 create mode 100644 app/test-pmd/macswap_common.h
 create mode 100644 app/test-pmd/macswap_sse.h
  

Comments

Ferruh Yigit Dec. 18, 2018, 12:15 a.m. UTC | #1
On 12/16/2018 12:58 AM, Qi Zhang wrote:
> Improved testpmd macswap performance for x86 by take advantage of SSE
> instructions.
> On a broadwell 1.6GHz sever with a i40e 25G NIC.
> We abserve 17.7% performance improvement for testpmd's macswap test.
> 
> v3:
> - fix wrong comment after #endif.
> - fix EOF space line.
> - add comment to explain shuffle mask.
> 
> v2:
> - replace PKT_TX_VLAN_PKT/PKT_TX_QINQ_PKT with PKT_TX_VLAN/PKT_TX_QINQ
> - only set vlan / outer_vlan when related ol_flags is set.
> - fix coding style
> 
> *** BLURB HERE ***
> 
> Qi Zhang (3):
>   app/testpmd: code refactory for macswap
>   app/testpmd: improve MAC swap performance for x86
>   app/testpmd: further improve MAC swap performance for x86

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Ferruh Yigit Dec. 18, 2018, 4:29 p.m. UTC | #2
On 12/18/2018 12:15 AM, Ferruh Yigit wrote:
> On 12/16/2018 12:58 AM, Qi Zhang wrote:
>> Improved testpmd macswap performance for x86 by take advantage of SSE
>> instructions.
>> On a broadwell 1.6GHz sever with a i40e 25G NIC.
>> We abserve 17.7% performance improvement for testpmd's macswap test.
>>
>> v3:
>> - fix wrong comment after #endif.
>> - fix EOF space line.
>> - add comment to explain shuffle mask.
>>
>> v2:
>> - replace PKT_TX_VLAN_PKT/PKT_TX_QINQ_PKT with PKT_TX_VLAN/PKT_TX_QINQ
>> - only set vlan / outer_vlan when related ol_flags is set.
>> - fix coding style
>>
>> *** BLURB HERE ***
>>
>> Qi Zhang (3):
>>   app/testpmd: code refactory for macswap
>>   app/testpmd: improve MAC swap performance for x86
>>   app/testpmd: further improve MAC swap performance for x86
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>


Series applied to dpdk-next-net/master, thanks.