mbox series

[v3,00/15] bnxt patchset

Message ID 20180929020006.71505-1-ajit.khaparde@broadcom.com (mailing list archive)
Headers
Series bnxt patchset |

Message

Ajit Khaparde Sept. 29, 2018, 1:59 a.m. UTC
  Patchset against dpdk-next-net.

v1->v2:
net/bnxt: get rid of ff pools array and use the vnic info array instead
- Fix access to uninitialized variable.
- Rectify the wrong 'Fixes' reference.

net/bnxt: update HWRM version
- Update from 1.9.2.45 to version 1.9.2.53

v2->v3:
net/bnxt: update HWRM version
- Tried to split into more than one patch.

- Updated commit logs and messages for rest based on review comments.

Please apply.

Ajit Khaparde (10):
  net/bnxt: fix MTU setting
  net/bnxt: update HWRM version
  net/bnxt: update HWRM version part 2
  net/bnxt: update HWRM version part 3
  net/bnxt: add support for extended port counters
  net/bnxt: add support to enable new mailbox channel
  net/bnxt: add support for trusted VF
  net/bnxt: set MAC filtering as outer for non tunnel frames
  net/bnxt: set a VNIC as default only once
  net/bnxt: remove excess log messages

Bei Sun (1):
  net/bnxt: set VLAN strip mode before default VNIC cfg

Somnath Kotur (2):
  net/bnxt: get rid of ff pools and use VNIC info array
  net/bnxt: fix uninitialized ptr access in transmit handler

Xiaoxin Peng (1):
  net/bnxt: reduce the polling interval for valid bit

Yongping Zhang (1):
  net/bnxt: fix registration of VF async event completion ring

 drivers/net/bnxt/bnxt.h                |    28 +-
 drivers/net/bnxt/bnxt_cpr.c            |     1 +
 drivers/net/bnxt/bnxt_ethdev.c         |   330 +-
 drivers/net/bnxt/bnxt_filter.c         |    28 +-
 drivers/net/bnxt/bnxt_flow.c           |    12 +-
 drivers/net/bnxt/bnxt_hwrm.c           |   418 +-
 drivers/net/bnxt/bnxt_hwrm.h           |     5 +
 drivers/net/bnxt/bnxt_rxq.c            |    19 +-
 drivers/net/bnxt/bnxt_stats.c          |   221 +-
 drivers/net/bnxt/bnxt_txr.c            |     5 +-
 drivers/net/bnxt/bnxt_vnic.c           |    43 +-
 drivers/net/bnxt/hsi_struct_def_dpdk.h | 24017 +++++++++++------------
 12 files changed, 12229 insertions(+), 12898 deletions(-)
  

Comments

Ferruh Yigit Oct. 2, 2018, 8:25 a.m. UTC | #1
On 9/29/2018 2:59 AM, Ajit Khaparde wrote:
> Patchset against dpdk-next-net.
> 
> v1->v2:
> net/bnxt: get rid of ff pools array and use the vnic info array instead
> - Fix access to uninitialized variable.
> - Rectify the wrong 'Fixes' reference.
> 
> net/bnxt: update HWRM version
> - Update from 1.9.2.45 to version 1.9.2.53
> 
> v2->v3:
> net/bnxt: update HWRM version
> - Tried to split into more than one patch.
> 
> - Updated commit logs and messages for rest based on review comments.
> 
> Please apply.
> 
> Ajit Khaparde (10):
>   net/bnxt: fix MTU setting
>   net/bnxt: update HWRM version
>   net/bnxt: update HWRM version part 2
>   net/bnxt: update HWRM version part 3

Is there a logical to separation of part 1,2 & 3?
Commit logs are empty and there is nothing distinctive from commits. If the
separation is not logical but just physically split into 3 pieces I am for
merging them back with the "Update the HWRM API to version 1.9.2.53" commit log.

Or if there is a logic please clarify it on patch subject and commit log.

I will wait your answer before moving on.

Thanks,
ferruh
  
Ajit Khaparde Oct. 2, 2018, 4:44 p.m. UTC | #2
>
>
> >   net/bnxt: update HWRM version
> >   net/bnxt: update HWRM version part 2
> >   net/bnxt: update HWRM version part 3
>
> Is there a logical to separation of part 1,2 & 3?
> Commit logs are empty and there is nothing distinctive from commits. If the
> separation is not logical but just physically split into 3 pieces I am for
> merging them back with the "Update the HWRM API to version 1.9.2.53"
> commit log.
>
Ferruh, It was a physical split into 3 patches.
So merging them into one is ok.

Thanks for checking.

Ajit


>
> Or if there is a logic please clarify it on patch subject and commit log.
>
> I will wait your answer before moving on.
>
> Thanks,
> ferruh
>
  
Ferruh Yigit Oct. 3, 2018, 9:48 a.m. UTC | #3
On 9/29/2018 2:59 AM, Ajit Khaparde wrote:
> Patchset against dpdk-next-net.
> 
> v1->v2:
> net/bnxt: get rid of ff pools array and use the vnic info array instead
> - Fix access to uninitialized variable.
> - Rectify the wrong 'Fixes' reference.
> 
> net/bnxt: update HWRM version
> - Update from 1.9.2.45 to version 1.9.2.53
> 
> v2->v3:
> net/bnxt: update HWRM version
> - Tried to split into more than one patch.
> 
> - Updated commit logs and messages for rest based on review comments.
> 
> Please apply.
> 
> Ajit Khaparde (10):
>   net/bnxt: fix MTU setting
>   net/bnxt: update HWRM version
>   net/bnxt: update HWRM version part 2
>   net/bnxt: update HWRM version part 3
>   net/bnxt: add support for extended port counters
>   net/bnxt: add support to enable new mailbox channel
>   net/bnxt: add support for trusted VF
>   net/bnxt: set MAC filtering as outer for non tunnel frames
>   net/bnxt: set a VNIC as default only once
>   net/bnxt: remove excess log messages
> 
> Bei Sun (1):
>   net/bnxt: set VLAN strip mode before default VNIC cfg
> 
> Somnath Kotur (2):
>   net/bnxt: get rid of ff pools and use VNIC info array
>   net/bnxt: fix uninitialized ptr access in transmit handler
> 
> Xiaoxin Peng (1):
>   net/bnxt: reduce the polling interval for valid bit
> 
> Yongping Zhang (1):
>   net/bnxt: fix registration of VF async event completion ring

Series applied to dpdk-next-net/master, thanks.

(patches 5/15 & 6/15 are squashed into 4/15)