mbox series

[v4,0/2] build and install only one library type on Windows

Message ID 1713199543-30038-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series build and install only one library type on Windows |

Message

Tyler Retzlaff April 15, 2024, 4:45 p.m. UTC 
  MSVC is the only compiler that can produce usable shared libraries for
DPDK on Windows because of the use of exported TLS variables.

Disable building of shared libraries with LLVM and MinGW so that
remaining __declspec macros needed for the functional libraries built by
MSVC can be used without triggering errors in LLVM and MinGW builds.

For Windows only install the default_library type to avoid confusion.
Windows builds cannot build both shared and static in a single pass so
install only the functional variant

MSVC does not guarantee any kind of compatibility for static libraries so
they should not be packaged and instead they should be rebuilt along with
the application using the same version of the compiler & linker.  Because
of this we have chosen to build only one library type at a time instead of
compiling twice to produce both types in a single pass.

v4:
  * use add_project_link_arguments() and move addition of linker and compiler
    arguments required only dynamic linking to block where it is determined
    is_shared_enabled=true and don't specify when is_shared_enabled=false.
  * unconditionally initialize shared_deps = {} and get rid of else leg of
    conditional evaluation in drivers/meson.build and lib/meson.build.
  * drop change to octeontx meson.build.

v3:
  * condense library, target and toolchain type logic determining values for
    is_shared_enabled,install_{static,shared} values.
  * define empty shared_dep object to allow unconditional evaluation of shared
    variables even when is_shared_enabled is false.
  * use default_library() string to determine deps for chkincs.

Tyler Retzlaff (2):
  build: build only one library type on Windows
  buildtools: when building static library use static deps

 app/meson.build                |  4 +++
 buildtools/chkincs/meson.build |  5 +--
 config/meson.build             | 21 +++++++++++++
 drivers/meson.build            | 62 +++++++++++++++++-------------------
 examples/meson.build           |  4 +++
 lib/meson.build                | 71 ++++++++++++++++++------------------------
 6 files changed, 90 insertions(+), 77 deletions(-)