mbox series

[v2,0/3] use rte macros instead of GCC __attribute

Message ID 1709146076-22254-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series use rte macros instead of GCC __attribute |

Message

Tyler Retzlaff Feb. 28, 2024, 6:47 p.m. UTC 
  Clean up direct uses of GCC __attribute__ in libs outside of EAL. A
checkpatch check already warns for new additions.

v2:
  * fix typo __rte_pure -> __rte_may_alias in rcu commit message

Tyler Retzlaff (3):
  eal: add rte pure attribute macro
  lpm: use rte macro instead of GCC attribute
  rcu: use rte macro instead of GCC attribute

 lib/eal/include/rte_common.h | 9 +++++++++
 lib/lpm/rte_lpm.c            | 4 ++--
 lib/lpm/rte_lpm6.c           | 2 +-
 lib/rcu/rcu_qsbr_pvt.h       | 2 +-
 4 files changed, 13 insertions(+), 4 deletions(-)

Comments

Tyler Retzlaff March 6, 2024, 7:36 p.m. UTC | #1 
ping.

Doesn't seem this series carries high risk, worth considering for
rc2/rc3?

On Wed, Feb 28, 2024 at 10:47:53AM -0800, Tyler Retzlaff wrote:
> Clean up direct uses of GCC __attribute__ in libs outside of EAL. A
> checkpatch check already warns for new additions.
> 
> v2:
>   * fix typo __rte_pure -> __rte_may_alias in rcu commit message
> 
> Tyler Retzlaff (3):
>   eal: add rte pure attribute macro
>   lpm: use rte macro instead of GCC attribute
>   rcu: use rte macro instead of GCC attribute
> 
>  lib/eal/include/rte_common.h | 9 +++++++++
>  lib/lpm/rte_lpm.c            | 4 ++--
>  lib/lpm/rte_lpm6.c           | 2 +-
>  lib/rcu/rcu_qsbr_pvt.h       | 2 +-
>  4 files changed, 13 insertions(+), 4 deletions(-)
> 
> -- 
> 1.8.3.1
David Marchand March 6, 2024, 8:49 p.m. UTC | #2 
On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Clean up direct uses of GCC __attribute__ in libs outside of EAL. A
> checkpatch check already warns for new additions.
>
> v2:
>   * fix typo __rte_pure -> __rte_may_alias in rcu commit message
>
> Tyler Retzlaff (3):
>   eal: add rte pure attribute macro
>   lpm: use rte macro instead of GCC attribute
>   rcu: use rte macro instead of GCC attribute
>
>  lib/eal/include/rte_common.h | 9 +++++++++
>  lib/lpm/rte_lpm.c            | 4 ++--
>  lib/lpm/rte_lpm6.c           | 2 +-
>  lib/rcu/rcu_qsbr_pvt.h       | 2 +-
>  4 files changed, 13 insertions(+), 4 deletions(-)

Introducing __rte_pure and converting lib/lpm looks fine.
But please finish the job for the other occurence in the tree as it is
a mechanical change.

Thanks.
Tyler Retzlaff March 6, 2024, 9:22 p.m. UTC | #3 
On Wed, Mar 06, 2024 at 09:49:31PM +0100, David Marchand wrote:
> On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A
> > checkpatch check already warns for new additions.
> >
> > v2:
> >   * fix typo __rte_pure -> __rte_may_alias in rcu commit message
> >
> > Tyler Retzlaff (3):
> >   eal: add rte pure attribute macro
> >   lpm: use rte macro instead of GCC attribute
> >   rcu: use rte macro instead of GCC attribute
> >
> >  lib/eal/include/rte_common.h | 9 +++++++++
> >  lib/lpm/rte_lpm.c            | 4 ++--
> >  lib/lpm/rte_lpm6.c           | 2 +-
> >  lib/rcu/rcu_qsbr_pvt.h       | 2 +-
> >  4 files changed, 13 insertions(+), 4 deletions(-)
> 
> Introducing __rte_pure and converting lib/lpm looks fine.
> But please finish the job for the other occurence in the tree as it is
> a mechanical change.

Sure, it's trivial that I don't have to burn it in on lib first.

Will submit an updated rev.

> 
> Thanks.
> 
> -- 
> David Marchand