[0/2] build eal & ring libraries with MSVC

Message ID 1709061720-4843-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series build eal & ring libraries with MSVC |

Message

Tyler Retzlaff Feb. 27, 2024, 7:21 p.m. UTC
  Enable build of eal & ring library when building with MSVC.

This series depends on 2 other series that seem to be near being
accepted for merge.

  https://patches.dpdk.org/project/dpdk/list/?series=31229
  https://patches.dpdk.org/project/dpdk/list/?series=31230

Since the rc2 deadline is soon this series is being submitted now
to solicit feedback.  The CI is expected to fail without the above
series being merged.

Tyler Retzlaff (2):
  build: build eal library with MSVC
  build: build ring library with MSVC

 config/meson.build           | 10 +++++++++-
 lib/eal/include/rte_common.h |  2 ++
 lib/meson.build              |  2 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
  

Comments

Bruce Richardson Feb. 28, 2024, 9:07 a.m. UTC | #1
On Tue, Feb 27, 2024 at 11:21:58AM -0800, Tyler Retzlaff wrote:
> Enable build of eal & ring library when building with MSVC.
> 
> This series depends on 2 other series that seem to be near being
> accepted for merge.
> 
>   https://patches.dpdk.org/project/dpdk/list/?series=31229
>   https://patches.dpdk.org/project/dpdk/list/?series=31230
> 
> Since the rc2 deadline is soon this series is being submitted now
> to solicit feedback.  The CI is expected to fail without the above
> series being merged.
> 
> Tyler Retzlaff (2):
>   build: build eal library with MSVC
>   build: build ring library with MSVC
> 
>  config/meson.build           | 10 +++++++++-
>  lib/eal/include/rte_common.h |  2 ++
>  lib/meson.build              |  2 ++
>  3 files changed, 13 insertions(+), 1 deletion(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
David Marchand March 6, 2024, 10 a.m. UTC | #2
On Tue, Feb 27, 2024 at 8:22 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Enable build of eal & ring library when building with MSVC.
>
> This series depends on 2 other series that seem to be near being
> accepted for merge.
>
>   https://patches.dpdk.org/project/dpdk/list/?series=31229
>   https://patches.dpdk.org/project/dpdk/list/?series=31230
>
> Since the rc2 deadline is soon this series is being submitted now
> to solicit feedback.  The CI is expected to fail without the above
> series being merged.
>

Series applied, thanks Tyler.

Btw, I noticed a failure in UNH for MSVC, but it is not reported as
such in patchwork.
https://lab.dpdk.org/results/dashboard/patchsets/29302/
https://patchwork.dpdk.org/project/dpdk/patch/1709061720-4843-3-git-send-email-roretzla@linux.microsoft.com/

Is there something to change in how UNH reports for the MSVC job?
  
Patrick Robb March 6, 2024, 2:48 p.m. UTC | #3
On Wed, Mar 6, 2024 at 5:00 AM David Marchand <david.marchand@redhat.com> wrote:
>
> On Tue, Feb 27, 2024 at 8:22 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Enable build of eal & ring library when building with MSVC.
> >
> > This series depends on 2 other series that seem to be near being
> > accepted for merge.
> >
> >   https://patches.dpdk.org/project/dpdk/list/?series=31229
> >   https://patches.dpdk.org/project/dpdk/list/?series=31230
> >
> > Since the rc2 deadline is soon this series is being submitted now
> > to solicit feedback.  The CI is expected to fail without the above
> > series being merged.
> >
>
> Series applied, thanks Tyler.
>
> Btw, I noticed a failure in UNH for MSVC, but it is not reported as
> such in patchwork.
> https://lab.dpdk.org/results/dashboard/patchsets/29302/
> https://patchwork.dpdk.org/project/dpdk/patch/1709061720-4843-3-git-send-email-roretzla@linux.microsoft.com/
>
> Is there something to change in how UNH reports for the MSVC job?

Hi David,

There was a discussion about this on Slack in the infra-issues space.
You can see the correct test report here:
https://inbox.dpdk.org/test-report/65deb584.d40a0220.71354.9933SMTPIN_ADDED_MISSING@mx.google.com/

Which at the time of the discussion was the latest update for the
iol-compile-amd64-testing context sent to patchwork. So this appears
to be an anomaly.
>
>
> --
> David Marchand
>