[v3,0/7] use abstracted bit count functions

Message ID 1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series use abstracted bit count functions |

Message

Tyler Retzlaff Nov. 7, 2023, 11:38 p.m. UTC
  The first set of conversions missed the long 'l' versions of the
builtins that were being used. This series completes the conversion
of remaining libraries from __builtin_ctzl, __builtin_clzl and
__builtin_popcountl.

v3:
  * add missing include of rte_bitops.h
  * add 2 patches to cover use of __builtin_popcountl

v2:
  * be explicit and use appropriate 32-bit and 64-bit leading
    and trailing counting functions depending on the type of the
    expression passed as an argument to the builtin.


Tyler Retzlaff (7):
  distributor: use abstracted bit count functions
  hash: use abstracted bit count functions
  member: use abstracted bit count functions
  rcu: use abstracted bit count functions
  table: use abstracted bit count functions
  distributor: use abstracted bit count functions
  hash: use abstracted bit count functions

 lib/distributor/rte_distributor_single.c |  4 ++--
 lib/hash/rte_cuckoo_hash.c               | 20 ++++++++++----------
 lib/member/rte_member_vbf.c              | 12 ++++++------
 lib/member/rte_member_x86.h              |  6 +++---
 lib/rcu/rte_rcu_qsbr.c                   |  4 ++--
 lib/rcu/rte_rcu_qsbr.h                   |  2 +-
 lib/table/rte_lru_arm64.h                |  3 ++-
 lib/table/rte_swx_table_em.c             |  4 ++--
 lib/table/rte_table_hash_ext.c           |  4 ++--
 lib/table/rte_table_hash_lru.c           |  4 ++--
 10 files changed, 32 insertions(+), 31 deletions(-)
  

Comments

Morten Brørup Nov. 8, 2023, 8:34 a.m. UTC | #1
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Wednesday, 8 November 2023 00.38
> 
> The first set of conversions missed the long 'l' versions of the
> builtins that were being used. This series completes the conversion
> of remaining libraries from __builtin_ctzl, __builtin_clzl and
> __builtin_popcountl.
> 
> v3:
>   * add missing include of rte_bitops.h
>   * add 2 patches to cover use of __builtin_popcountl
> 
> v2:
>   * be explicit and use appropriate 32-bit and 64-bit leading
>     and trailing counting functions depending on the type of the
>     expression passed as an argument to the builtin.

Didn't notice v3 before ack'ing v2.

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
  
Thomas Monjalon Nov. 8, 2023, 4:57 p.m. UTC | #2
08/11/2023 09:34, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Wednesday, 8 November 2023 00.38
> > 
> > The first set of conversions missed the long 'l' versions of the
> > builtins that were being used. This series completes the conversion
> > of remaining libraries from __builtin_ctzl, __builtin_clzl and
> > __builtin_popcountl.
> > 
> > v3:
> >   * add missing include of rte_bitops.h
> >   * add 2 patches to cover use of __builtin_popcountl
> > 
> > v2:
> >   * be explicit and use appropriate 32-bit and 64-bit leading
> >     and trailing counting functions depending on the type of the
> >     expression passed as an argument to the builtin.
> 
> Didn't notice v3 before ack'ing v2.
> 
> Series-acked-by: Morten Brørup <mb@smartsharesystems.com>

Squashed and applied, thanks.

Note: there are few builtin occurences in drivers.
  
Tyler Retzlaff Nov. 8, 2023, 6:42 p.m. UTC | #3
On Wed, Nov 08, 2023 at 05:57:01PM +0100, Thomas Monjalon wrote:
> 08/11/2023 09:34, Morten Brørup:
> > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > > Sent: Wednesday, 8 November 2023 00.38
> > > 
> > > The first set of conversions missed the long 'l' versions of the
> > > builtins that were being used. This series completes the conversion
> > > of remaining libraries from __builtin_ctzl, __builtin_clzl and
> > > __builtin_popcountl.
> > > 
> > > v3:
> > >   * add missing include of rte_bitops.h
> > >   * add 2 patches to cover use of __builtin_popcountl
> > > 
> > > v2:
> > >   * be explicit and use appropriate 32-bit and 64-bit leading
> > >     and trailing counting functions depending on the type of the
> > >     expression passed as an argument to the builtin.
> > 
> > Didn't notice v3 before ack'ing v2.
> > 
> > Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
> 
> Squashed and applied, thanks.
> 
> Note: there are few builtin occurences in drivers.

yes, tests and drivers are on my list. i'm mostly addressing conversions
in libs right now.

> 
>