Message ID | 1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51043432CC; Wed, 8 Nov 2023 00:38:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3D3040689; Wed, 8 Nov 2023 00:38:22 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6DCF740041 for <dev@dpdk.org>; Wed, 8 Nov 2023 00:38:22 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id AC66520B74C0; Tue, 7 Nov 2023 15:38:21 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AC66520B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699400301; bh=mYj3yyrlnxIsLTMN5xdz2NLql7xoEom0UqGf5BqIXLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dZSHPBPrSf/ah/usIRUNb3Eolnnta5asEYf6UXHiPIkNU74AOuYdDv40tQtgYqA78 q+6FVz07HMVb194FgGQhKZa5HREo8JItz442Ttcjp6YrcAVWEg/esKogd+/aFx2Ymd 2Qk46k+Ez94GGyTHKCJmzcTzqsctuKheL+Ctvcmw= From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, David Hunt <david.hunt@intel.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>, mb@smartsharesystems.com Subject: [PATCH v3 0/7] use abstracted bit count functions Date: Tue, 7 Nov 2023 15:38:13 -0800 Message-Id: <1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1698887132-5347-1-git-send-email-roretzla@linux.microsoft.com> References: <1698887132-5347-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
use abstracted bit count functions
|
|
Message
Tyler Retzlaff
Nov. 7, 2023, 11:38 p.m. UTC
The first set of conversions missed the long 'l' versions of the builtins that were being used. This series completes the conversion of remaining libraries from __builtin_ctzl, __builtin_clzl and __builtin_popcountl. v3: * add missing include of rte_bitops.h * add 2 patches to cover use of __builtin_popcountl v2: * be explicit and use appropriate 32-bit and 64-bit leading and trailing counting functions depending on the type of the expression passed as an argument to the builtin. Tyler Retzlaff (7): distributor: use abstracted bit count functions hash: use abstracted bit count functions member: use abstracted bit count functions rcu: use abstracted bit count functions table: use abstracted bit count functions distributor: use abstracted bit count functions hash: use abstracted bit count functions lib/distributor/rte_distributor_single.c | 4 ++-- lib/hash/rte_cuckoo_hash.c | 20 ++++++++++---------- lib/member/rte_member_vbf.c | 12 ++++++------ lib/member/rte_member_x86.h | 6 +++--- lib/rcu/rte_rcu_qsbr.c | 4 ++-- lib/rcu/rte_rcu_qsbr.h | 2 +- lib/table/rte_lru_arm64.h | 3 ++- lib/table/rte_swx_table_em.c | 4 ++-- lib/table/rte_table_hash_ext.c | 4 ++-- lib/table/rte_table_hash_lru.c | 4 ++-- 10 files changed, 32 insertions(+), 31 deletions(-)
Comments
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Wednesday, 8 November 2023 00.38 > > The first set of conversions missed the long 'l' versions of the > builtins that were being used. This series completes the conversion > of remaining libraries from __builtin_ctzl, __builtin_clzl and > __builtin_popcountl. > > v3: > * add missing include of rte_bitops.h > * add 2 patches to cover use of __builtin_popcountl > > v2: > * be explicit and use appropriate 32-bit and 64-bit leading > and trailing counting functions depending on the type of the > expression passed as an argument to the builtin. Didn't notice v3 before ack'ing v2. Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
08/11/2023 09:34, Morten Brørup: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Wednesday, 8 November 2023 00.38 > > > > The first set of conversions missed the long 'l' versions of the > > builtins that were being used. This series completes the conversion > > of remaining libraries from __builtin_ctzl, __builtin_clzl and > > __builtin_popcountl. > > > > v3: > > * add missing include of rte_bitops.h > > * add 2 patches to cover use of __builtin_popcountl > > > > v2: > > * be explicit and use appropriate 32-bit and 64-bit leading > > and trailing counting functions depending on the type of the > > expression passed as an argument to the builtin. > > Didn't notice v3 before ack'ing v2. > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> Squashed and applied, thanks. Note: there are few builtin occurences in drivers.
On Wed, Nov 08, 2023 at 05:57:01PM +0100, Thomas Monjalon wrote: > 08/11/2023 09:34, Morten Brørup: > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > Sent: Wednesday, 8 November 2023 00.38 > > > > > > The first set of conversions missed the long 'l' versions of the > > > builtins that were being used. This series completes the conversion > > > of remaining libraries from __builtin_ctzl, __builtin_clzl and > > > __builtin_popcountl. > > > > > > v3: > > > * add missing include of rte_bitops.h > > > * add 2 patches to cover use of __builtin_popcountl > > > > > > v2: > > > * be explicit and use appropriate 32-bit and 64-bit leading > > > and trailing counting functions depending on the type of the > > > expression passed as an argument to the builtin. > > > > Didn't notice v3 before ack'ing v2. > > > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> > > Squashed and applied, thanks. > > Note: there are few builtin occurences in drivers. yes, tests and drivers are on my list. i'm mostly addressing conversions in libs right now. > >