mbox series

[v2,0/4] add rte_thread_set_name API for rte_thread_t

Message ID 1671036441-10234-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series add rte_thread_set_name API for rte_thread_t |

Message

Tyler Retzlaff Dec. 14, 2022, 4:47 p.m. UTC 
  Replace the rte_thread_setname API which operates on pthread_t with
rte_thread_set_name that operates on rte_thread_t.

v2:
  * initial series provided get/set for lcore thread id, those
    additions have been removed as per discussion. including
    unit test.
  * add a single api rte_thread_set_name does not fail but emits
    debug logging if the internal implementation is aware of
    in-exact use of the name or failure to set the name.
  * adapt mlx5 driver to avoid use of deprecated API.

Tyler Retzlaff (4):
  eal: add thread set name API operating on rte thread
  eal: remove thread getname API
  eal: deprecate rte thread setname API
  drivers: mlx5 use rte thread set name

 doc/guides/rel_notes/deprecation.rst |  4 ++++
 drivers/net/mlx5/mlx5_hws_cnt.c      |  4 +++-
 drivers/vdpa/mlx5/mlx5_vdpa_event.c  |  3 +--
 lib/eal/common/eal_common_thread.c   |  9 +++----
 lib/eal/common/eal_common_trace.c    |  2 --
 lib/eal/freebsd/eal.c                |  4 +++-
 lib/eal/freebsd/eal_thread.c         | 20 +++++++++-------
 lib/eal/include/rte_lcore.h          | 19 ++-------------
 lib/eal/include/rte_thread.h         | 17 +++++++++++++
 lib/eal/linux/eal.c                  |  8 +++----
 lib/eal/linux/eal_thread.c           | 29 ++++++++++++++---------
 lib/eal/version.map                  |  4 +++-
 lib/eal/windows/rte_thread.c         | 46 ++++++++++++++++++++++++++++++++++++
 13 files changed, 114 insertions(+), 55 deletions(-)

Comments

Tyler Retzlaff Jan. 10, 2023, 8:53 p.m. UTC | #1 
anymore feedback here folks?

would like to clear this so i can rebase the rte_control_thread_create
series.

thanks!

On Wed, Dec 14, 2022 at 08:47:17AM -0800, Tyler Retzlaff wrote:
> Replace the rte_thread_setname API which operates on pthread_t with
> rte_thread_set_name that operates on rte_thread_t.
> 
> v2:
>   * initial series provided get/set for lcore thread id, those
>     additions have been removed as per discussion. including
>     unit test.
>   * add a single api rte_thread_set_name does not fail but emits
>     debug logging if the internal implementation is aware of
>     in-exact use of the name or failure to set the name.
>   * adapt mlx5 driver to avoid use of deprecated API.
> 
> Tyler Retzlaff (4):
>   eal: add thread set name API operating on rte thread
>   eal: remove thread getname API
>   eal: deprecate rte thread setname API
>   drivers: mlx5 use rte thread set name
> 
>  doc/guides/rel_notes/deprecation.rst |  4 ++++
>  drivers/net/mlx5/mlx5_hws_cnt.c      |  4 +++-
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c  |  3 +--
>  lib/eal/common/eal_common_thread.c   |  9 +++----
>  lib/eal/common/eal_common_trace.c    |  2 --
>  lib/eal/freebsd/eal.c                |  4 +++-
>  lib/eal/freebsd/eal_thread.c         | 20 +++++++++-------
>  lib/eal/include/rte_lcore.h          | 19 ++-------------
>  lib/eal/include/rte_thread.h         | 17 +++++++++++++
>  lib/eal/linux/eal.c                  |  8 +++----
>  lib/eal/linux/eal_thread.c           | 29 ++++++++++++++---------
>  lib/eal/version.map                  |  4 +++-
>  lib/eal/windows/rte_thread.c         | 46 ++++++++++++++++++++++++++++++++++++
>  13 files changed, 114 insertions(+), 55 deletions(-)
> 
> -- 
> 1.8.3.1
Morten Brørup Jan. 11, 2023, 7:55 a.m. UTC | #2 
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Tuesday, 10 January 2023 21.53
> 
> anymore feedback here folks?
> 
> would like to clear this so i can rebase the rte_control_thread_create
> series.
> 
> thanks!
> 
> On Wed, Dec 14, 2022 at 08:47:17AM -0800, Tyler Retzlaff wrote:
> > Replace the rte_thread_setname API which operates on pthread_t with
> > rte_thread_set_name that operates on rte_thread_t.
> >
> > v2:
> >   * initial series provided get/set for lcore thread id, those
> >     additions have been removed as per discussion. including
> >     unit test.
> >   * add a single api rte_thread_set_name does not fail but emits
> >     debug logging if the internal implementation is aware of
> >     in-exact use of the name or failure to set the name.
> >   * adapt mlx5 driver to avoid use of deprecated API.
> >
> > Tyler Retzlaff (4):
> >   eal: add thread set name API operating on rte thread
> >   eal: remove thread getname API
> >   eal: deprecate rte thread setname API
> >   drivers: mlx5 use rte thread set name

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>