mbox series

[00/17] bugfixes and small functionality for hns3

Message ID 1612338382-3253-1-git-send-email-oulijun@huawei.com (mailing list archive)
Headers
Series bugfixes and small functionality for hns3 |

Message

Lijun Ou Feb. 3, 2021, 7:46 a.m. UTC
  This patch series add some bugfixes and some small
functions. In order to fix some bugfixes, we had to
do some code rework, for example patch[13/17].

Chengchang Tang (6):
  net/hns3: support module EEPROM dump
  net/hns3: add more registers to dump
  net/hns3: fix stats flip overflow
  net/hns3: replace all atomic type with C11 atomic builtins
  net/hns3: fix cmdq cleared during firmware process
  net/hns3: fix VF reset after MBX failed

Chengwen Feng (4):
  net/hns3: implement cleanup for Tx done
  net/hns3: constraint TM peak rate
  net/hns3: remove MPLS type from supported flow items
  net/hns3: fix FD rule residue in hardware when malloc fail

Huisong Li (5):
  net/hns3: fix query order of link status and link info
  net/hns3: fix link status change from firmware
  net/hns3: encapsulate a port shaping interface
  net/hns3: support PF on electrical net device
  net/hns3: add check for max pkt length of Rx

Lijun Ou (1):
  net/hns3: fix RSS indirection table size

Min Hu (Connor) (1):
  net/hns3: add enhance stats function

 doc/guides/nics/features/hns3.ini      |   2 +
 doc/guides/nics/features/hns3_vf.ini   |   1 +
 doc/guides/rel_notes/release_21_02.rst |   1 +
 drivers/net/hns3/hns3_cmd.c            |  36 ++-
 drivers/net/hns3/hns3_cmd.h            |  91 +++++++-
 drivers/net/hns3/hns3_dcb.c            |  24 +-
 drivers/net/hns3/hns3_dcb.h            |   2 +-
 drivers/net/hns3/hns3_ethdev.c         | 406 ++++++++++++++++++++++++++++++---
 drivers/net/hns3/hns3_ethdev.h         |  10 +-
 drivers/net/hns3/hns3_ethdev_vf.c      |  63 +++--
 drivers/net/hns3/hns3_flow.c           |  36 ++-
 drivers/net/hns3/hns3_intr.c           |  22 +-
 drivers/net/hns3/hns3_mbx.c            |   4 +-
 drivers/net/hns3/hns3_regs.c           | 171 +++++++++++++-
 drivers/net/hns3/hns3_rss.c            |  28 +--
 drivers/net/hns3/hns3_rss.h            |   5 +-
 drivers/net/hns3/hns3_rxtx.c           |  83 +++++++
 drivers/net/hns3/hns3_rxtx.h           |   1 +
 drivers/net/hns3/hns3_rxtx_vec_neon.h  |  15 ++
 drivers/net/hns3/hns3_rxtx_vec_sve.c   |  11 +
 drivers/net/hns3/hns3_stats.c          | 156 ++++++++++++-
 drivers/net/hns3/hns3_stats.h          |   8 +
 drivers/net/hns3/hns3_tm.c             |   6 +
 23 files changed, 1050 insertions(+), 132 deletions(-)
  

Comments

Ferruh Yigit Feb. 3, 2021, 9:24 a.m. UTC | #1
On 2/3/2021 7:46 AM, Lijun Ou wrote:
> This patch series add some bugfixes and some small
> functions. In order to fix some bugfixes, we had to
> do some code rework, for example patch[13/17].
> 
> Chengchang Tang (6):
>    net/hns3: support module EEPROM dump
>    net/hns3: add more registers to dump
>    net/hns3: fix stats flip overflow
>    net/hns3: replace all atomic type with C11 atomic builtins
>    net/hns3: fix cmdq cleared during firmware process
>    net/hns3: fix VF reset after MBX failed
> 
> Chengwen Feng (4):
>    net/hns3: implement cleanup for Tx done
>    net/hns3: constraint TM peak rate
>    net/hns3: remove MPLS type from supported flow items
>    net/hns3: fix FD rule residue in hardware when malloc fail
> 
> Huisong Li (5):
>    net/hns3: fix query order of link status and link info
>    net/hns3: fix link status change from firmware
>    net/hns3: encapsulate a port shaping interface
>    net/hns3: support PF on electrical net device
>    net/hns3: add check for max pkt length of Rx
> 
> Lijun Ou (1):
>    net/hns3: fix RSS indirection table size
> 
> Min Hu (Connor) (1):
>    net/hns3: add enhance stats function
> 

Hi Lijun,

Is this for next release or current release?
We are a day away from the -rc3 and a week (almost) away from the actual 
release, it is safer to limit the patches to fixes at this stage.

If above set is for this release, can you please make a new version to have only 
fixes, and leave the new supports and refactoring and not important fixes to 
next release?

Thanks,
ferruh
  
Lijun Ou Feb. 3, 2021, 11:05 a.m. UTC | #2
在 2021/2/3 17:24, Ferruh Yigit 写道:
> On 2/3/2021 7:46 AM, Lijun Ou wrote:
>> This patch series add some bugfixes and some small
>> functions. In order to fix some bugfixes, we had to
>> do some code rework, for example patch[13/17].
>>
>> Chengchang Tang (6):
>>    net/hns3: support module EEPROM dump
>>    net/hns3: add more registers to dump
>>    net/hns3: fix stats flip overflow
>>    net/hns3: replace all atomic type with C11 atomic builtins
>>    net/hns3: fix cmdq cleared during firmware process
>>    net/hns3: fix VF reset after MBX failed
>>
>> Chengwen Feng (4):
>>    net/hns3: implement cleanup for Tx done
>>    net/hns3: constraint TM peak rate
>>    net/hns3: remove MPLS type from supported flow items
>>    net/hns3: fix FD rule residue in hardware when malloc fail
>>
>> Huisong Li (5):
>>    net/hns3: fix query order of link status and link info
>>    net/hns3: fix link status change from firmware
>>    net/hns3: encapsulate a port shaping interface
>>    net/hns3: support PF on electrical net device
>>    net/hns3: add check for max pkt length of Rx
>>
>> Lijun Ou (1):
>>    net/hns3: fix RSS indirection table size
>>
>> Min Hu (Connor) (1):
>>    net/hns3: add enhance stats function
>>
> 
> Hi Lijun,
> 
> Is this for next release or current release?
> We are a day away from the -rc3 and a week (almost) away from the actual 
> release, it is safer to limit the patches to fixes at this stage.
> 
> If above set is for this release, can you please make a new version to 
> have only fixes, and leave the new supports and refactoring and not 
> important fixes to next release?
> 
Yes, I've been aware of our expectations and requirements of each rc. 
Therefore, we have selected some new support items that have been 
developed and tested in the roadmap and hope to integrate them in the 
rc3. Some key bug fixes are expected to be fixed in the current version 
as soon as possible.
> Thanks,
> ferruh
> 
> .
>
  
Ferruh Yigit Feb. 3, 2021, 11:46 a.m. UTC | #3
On 2/3/2021 11:05 AM, oulijun wrote:
> 
> 
> 在 2021/2/3 17:24, Ferruh Yigit 写道:
>> On 2/3/2021 7:46 AM, Lijun Ou wrote:
>>> This patch series add some bugfixes and some small
>>> functions. In order to fix some bugfixes, we had to
>>> do some code rework, for example patch[13/17].
>>>
>>> Chengchang Tang (6):
>>>    net/hns3: support module EEPROM dump
>>>    net/hns3: add more registers to dump
>>>    net/hns3: fix stats flip overflow
>>>    net/hns3: replace all atomic type with C11 atomic builtins
>>>    net/hns3: fix cmdq cleared during firmware process
>>>    net/hns3: fix VF reset after MBX failed
>>>
>>> Chengwen Feng (4):
>>>    net/hns3: implement cleanup for Tx done
>>>    net/hns3: constraint TM peak rate
>>>    net/hns3: remove MPLS type from supported flow items
>>>    net/hns3: fix FD rule residue in hardware when malloc fail
>>>
>>> Huisong Li (5):
>>>    net/hns3: fix query order of link status and link info
>>>    net/hns3: fix link status change from firmware
>>>    net/hns3: encapsulate a port shaping interface
>>>    net/hns3: support PF on electrical net device
>>>    net/hns3: add check for max pkt length of Rx
>>>
>>> Lijun Ou (1):
>>>    net/hns3: fix RSS indirection table size
>>>
>>> Min Hu (Connor) (1):
>>>    net/hns3: add enhance stats function
>>>
>>
>> Hi Lijun,
>>
>> Is this for next release or current release?
>> We are a day away from the -rc3 and a week (almost) away from the actual 
>> release, it is safer to limit the patches to fixes at this stage.
>>
>> If above set is for this release, can you please make a new version to have 
>> only fixes, and leave the new supports and refactoring and not important fixes 
>> to next release?
>>
> Yes, I've been aware of our expectations and requirements of each rc. Therefore, 
> we have selected some new support items that have been developed and tested in 
> the roadmap and hope to integrate them in the rc3. Some key bug fixes are 
> expected to be fixed in the current version as soon as possible.

Still not sure about getting new small functionality in the last day of the 
-rc3, what do you think get the fixes and push the new functionality to next 
release?

Technically new features should be sent _before_ the proposal deadline, December 
20, and we are more flexible for the drivers but there should be a deadline 
eventually.
  
Lijun Ou Feb. 3, 2021, 12:18 p.m. UTC | #4
在 2021/2/3 19:46, Ferruh Yigit 写道:
> On 2/3/2021 11:05 AM, oulijun wrote:
>>
>>
>> 在 2021/2/3 17:24, Ferruh Yigit 写道:
>>> On 2/3/2021 7:46 AM, Lijun Ou wrote:
>>>> This patch series add some bugfixes and some small
>>>> functions. In order to fix some bugfixes, we had to
>>>> do some code rework, for example patch[13/17].
>>>>
>>>> Chengchang Tang (6):
>>>>    net/hns3: support module EEPROM dump
>>>>    net/hns3: add more registers to dump
>>>>    net/hns3: fix stats flip overflow
>>>>    net/hns3: replace all atomic type with C11 atomic builtins
>>>>    net/hns3: fix cmdq cleared during firmware process
>>>>    net/hns3: fix VF reset after MBX failed
>>>>
>>>> Chengwen Feng (4):
>>>>    net/hns3: implement cleanup for Tx done
>>>>    net/hns3: constraint TM peak rate
>>>>    net/hns3: remove MPLS type from supported flow items
>>>>    net/hns3: fix FD rule residue in hardware when malloc fail
>>>>
>>>> Huisong Li (5):
>>>>    net/hns3: fix query order of link status and link info
>>>>    net/hns3: fix link status change from firmware
>>>>    net/hns3: encapsulate a port shaping interface
>>>>    net/hns3: support PF on electrical net device
>>>>    net/hns3: add check for max pkt length of Rx
>>>>
>>>> Lijun Ou (1):
>>>>    net/hns3: fix RSS indirection table size
>>>>
>>>> Min Hu (Connor) (1):
>>>>    net/hns3: add enhance stats function
>>>>
>>>
>>> Hi Lijun,
>>>
>>> Is this for next release or current release?
>>> We are a day away from the -rc3 and a week (almost) away from the 
>>> actual release, it is safer to limit the patches to fixes at this stage.
>>>
>>> If above set is for this release, can you please make a new version 
>>> to have only fixes, and leave the new supports and refactoring and 
>>> not important fixes to next release?
>>>
>> Yes, I've been aware of our expectations and requirements of each rc. 
>> Therefore, we have selected some new support items that have been 
>> developed and tested in the roadmap and hope to integrate them in the 
>> rc3. Some key bug fixes are expected to be fixed in the current 
>> version as soon as possible.
> 
> Still not sure about getting new small functionality in the last day of 
> the -rc3, what do you think get the fixes and push the new functionality 
> to next release?
> 
Thanks, I see.
> Technically new features should be sent _before_ the proposal deadline, 
> December 20, and we are more flexible for the drivers but there should 
> be a deadline eventually.
> .
>