mbox series

[v12,00/10] bbdev PMD ACC100

Message ID 1601935969-206757-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series bbdev PMD ACC100 |

Message

Chautru, Nicolas Oct. 5, 2020, 10:12 p.m. UTC
  v12: Correcting 1 spelling error and 1 code clean up.
v11: Further updates based on Tom + Maxime review comments on v9 and v10.  Variable renaming
v10: Updates based on Tom Rix valuable review comments. Notably doc clarifiction, #define names updates, few magic numbers left, stricter error handling and few valuable coding suggestions. Thanks
v9: moved the release notes update to the last commit
v8: integrated the doc feature table in previous commit as suggested. 
v7: Fingers trouble. Previous one sent mid-rebase. My bad. 
v6: removed a legacy makefile no longer required
v5: rebase based on latest on main. The legacy makefiles are removed. 
v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive of maybe-undeclared. 
http://mails.dpdk.org/archives/test-report/2020-August/148936.html
Still forcing a dummy declare to remove this CI warning I will check with ci@dpdk.org in parallel.  
v3: missed a change during rebase
v2: includes clean up from latest CI checks.

Nicolas Chautru (10):
  drivers/baseband: add PMD for ACC100
  baseband/acc100: add register definition file
  baseband/acc100: add info get function
  baseband/acc100: add queue configuration
  baseband/acc100: add LDPC processing functions
  baseband/acc100: add HARQ loopback support
  baseband/acc100: add support for 4G processing
  baseband/acc100: add interrupt support to PMD
  baseband/acc100: add debug function to validate input
  baseband/acc100: add configure function

 app/test-bbdev/meson.build                         |    3 +
 app/test-bbdev/test_bbdev_perf.c                   |   71 +
 doc/guides/bbdevs/acc100.rst                       |  228 +
 doc/guides/bbdevs/features/acc100.ini              |   14 +
 doc/guides/bbdevs/index.rst                        |    1 +
 doc/guides/rel_notes/release_20_11.rst             |    5 +
 drivers/baseband/acc100/acc100_pf_enum.h           | 1068 +++++
 drivers/baseband/acc100/acc100_vf_enum.h           |   73 +
 drivers/baseband/acc100/meson.build                |    8 +
 drivers/baseband/acc100/rte_acc100_cfg.h           |  113 +
 drivers/baseband/acc100/rte_acc100_pmd.c           | 4727 ++++++++++++++++++++
 drivers/baseband/acc100/rte_acc100_pmd.h           |  602 +++
 .../acc100/rte_pmd_bbdev_acc100_version.map        |   10 +
 drivers/baseband/meson.build                       |    2 +-
 14 files changed, 6924 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/bbdevs/acc100.rst
 create mode 100644 doc/guides/bbdevs/features/acc100.ini
 create mode 100644 drivers/baseband/acc100/acc100_pf_enum.h
 create mode 100644 drivers/baseband/acc100/acc100_vf_enum.h
 create mode 100644 drivers/baseband/acc100/meson.build
 create mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h
 create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c
 create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.h
 create mode 100644 drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map
  

Comments

Maxime Coquelin Oct. 6, 2020, 1:20 p.m. UTC | #1
Hi Nicolas,

The series looks overall good to me now. Thanks for implementing the
suggested changes.

For what it's worth:

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

On 10/6/20 12:12 AM, Nicolas Chautru wrote:
> v12: Correcting 1 spelling error and 1 code clean up.
> v11: Further updates based on Tom + Maxime review comments on v9 and v10.  Variable renaming
> v10: Updates based on Tom Rix valuable review comments. Notably doc clarifiction, #define names updates, few magic numbers left, stricter error handling and few valuable coding suggestions. Thanks
> v9: moved the release notes update to the last commit
> v8: integrated the doc feature table in previous commit as suggested. 
> v7: Fingers trouble. Previous one sent mid-rebase. My bad. 
> v6: removed a legacy makefile no longer required
> v5: rebase based on latest on main. The legacy makefiles are removed. 
> v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive of maybe-undeclared. 
> http://mails.dpdk.org/archives/test-report/2020-August/148936.html
> Still forcing a dummy declare to remove this CI warning I will check with ci@dpdk.org in parallel.  
> v3: missed a change during rebase
> v2: includes clean up from latest CI checks.
> 
> Nicolas Chautru (10):
>   drivers/baseband: add PMD for ACC100
>   baseband/acc100: add register definition file
>   baseband/acc100: add info get function
>   baseband/acc100: add queue configuration
>   baseband/acc100: add LDPC processing functions
>   baseband/acc100: add HARQ loopback support
>   baseband/acc100: add support for 4G processing
>   baseband/acc100: add interrupt support to PMD
>   baseband/acc100: add debug function to validate input
>   baseband/acc100: add configure function
> 
>  app/test-bbdev/meson.build                         |    3 +
>  app/test-bbdev/test_bbdev_perf.c                   |   71 +
>  doc/guides/bbdevs/acc100.rst                       |  228 +
>  doc/guides/bbdevs/features/acc100.ini              |   14 +
>  doc/guides/bbdevs/index.rst                        |    1 +
>  doc/guides/rel_notes/release_20_11.rst             |    5 +
>  drivers/baseband/acc100/acc100_pf_enum.h           | 1068 +++++
>  drivers/baseband/acc100/acc100_vf_enum.h           |   73 +
>  drivers/baseband/acc100/meson.build                |    8 +
>  drivers/baseband/acc100/rte_acc100_cfg.h           |  113 +
>  drivers/baseband/acc100/rte_acc100_pmd.c           | 4727 ++++++++++++++++++++
>  drivers/baseband/acc100/rte_acc100_pmd.h           |  602 +++
>  .../acc100/rte_pmd_bbdev_acc100_version.map        |   10 +
>  drivers/baseband/meson.build                       |    2 +-
>  14 files changed, 6924 insertions(+), 1 deletion(-)
>  create mode 100644 doc/guides/bbdevs/acc100.rst
>  create mode 100644 doc/guides/bbdevs/features/acc100.ini
>  create mode 100644 drivers/baseband/acc100/acc100_pf_enum.h
>  create mode 100644 drivers/baseband/acc100/acc100_vf_enum.h
>  create mode 100644 drivers/baseband/acc100/meson.build
>  create mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h
>  create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c
>  create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.h
>  create mode 100644 drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map
>
  
Akhil Goyal Oct. 6, 2020, 7:43 p.m. UTC | #2
> 
> Hi Nicolas,
> 
> The series looks overall good to me now. Thanks for implementing the
> suggested changes.
> 
> For what it's worth:
> 
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 

Series applied to dpdk-next-crypto

Thanks.