[RFC,v2,0/3] add rx buffer size for rte_eth_rxq_info

  In common practice, PMD configure the rx buffer size which indicate the
buffer length could be used for hw in receiving packts according to the
data room size of the object in mempool. But in fact the final value is
related to the specifications of hw, and its values will affect the number
of fragments in recieving pkts when scatter is enabled. By the way, some
PMDs may force to enable scatter when the MTU is bigger than the hw rx
buffer size.

At present, we seem to have no way to expose relevant information to upper
layer users.

So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
buffer size used in recieving pkts for hw. And this patchset also add hns3
PMD implementation and update the testpmd to clarify intention.

v2:
Add hns3 implementation and update testpmd.

Chengchang Tang (2):
  ethdev: add a field for rte_eth_rxq_info
  app/testpmd: Add RX buffer size dispaly in queue info querry

Huisong Li (1):
  net/hns3: add support for query of rx/tx queue info

 app/test-pmd/config.c             |  1 +
 drivers/net/hns3/hns3_ethdev.c    |  2 ++
 drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
 drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
 drivers/net/hns3/hns3_rxtx.h      |  4 ++++
 lib/librte_ethdev/rte_ethdev.h    |  2 ++
 6 files changed, 59 insertions(+)

--
2.7.4
  

Friendly ping

On 2020/7/22 14:38, Chengchang Tang wrote:
> In common practice, PMD configure the rx buffer size which indicate the
> buffer length could be used for hw in receiving packts according to the
> data room size of the object in mempool. But in fact the final value is
> related to the specifications of hw, and its values will affect the number
> of fragments in recieving pkts when scatter is enabled. By the way, some
> PMDs may force to enable scatter when the MTU is bigger than the hw rx
> buffer size.
> 
> At present, we seem to have no way to expose relevant information to upper
> layer users.
> 
> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
> buffer size used in recieving pkts for hw. And this patchset also add hns3
> PMD implementation and update the testpmd to clarify intention.
> 
> v2:
> Add hns3 implementation and update testpmd.
> 
> Chengchang Tang (2):
>   ethdev: add a field for rte_eth_rxq_info
>   app/testpmd: Add RX buffer size dispaly in queue info querry
> 
> Huisong Li (1):
>   net/hns3: add support for query of rx/tx queue info
> 
>  app/test-pmd/config.c             |  1 +
>  drivers/net/hns3/hns3_ethdev.c    |  2 ++
>  drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
>  drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/hns3/hns3_rxtx.h      |  4 ++++
>  lib/librte_ethdev/rte_ethdev.h    |  2 ++
>  6 files changed, 59 insertions(+)
> 
> --
> 2.7.4
> 
> _______________________________________________
> Linuxarm mailing list
> Linuxarm@huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
> 
> .
>
  

On 7/28/2020 7:29 AM, Chengchang Tang wrote:
> Friendly ping

Hi Tang,

Sorry for not making it clear, since it is a library change, the change is
already late for this release (20.08), and it will be considered for next
release. As current release out, we can continue the discussions.

> 
> On 2020/7/22 14:38, Chengchang Tang wrote:
>> In common practice, PMD configure the rx buffer size which indicate the
>> buffer length could be used for hw in receiving packts according to the
>> data room size of the object in mempool. But in fact the final value is
>> related to the specifications of hw, and its values will affect the number
>> of fragments in recieving pkts when scatter is enabled. By the way, some
>> PMDs may force to enable scatter when the MTU is bigger than the hw rx
>> buffer size.
>>
>> At present, we seem to have no way to expose relevant information to upper
>> layer users.
>>
>> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
>> buffer size used in recieving pkts for hw. And this patchset also add hns3
>> PMD implementation and update the testpmd to clarify intention.
>>
>> v2:
>> Add hns3 implementation and update testpmd.
>>
>> Chengchang Tang (2):
>>   ethdev: add a field for rte_eth_rxq_info
>>   app/testpmd: Add RX buffer size dispaly in queue info querry
>>
>> Huisong Li (1):
>>   net/hns3: add support for query of rx/tx queue info
>>
>>  app/test-pmd/config.c             |  1 +
>>  drivers/net/hns3/hns3_ethdev.c    |  2 ++
>>  drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
>>  drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
>>  drivers/net/hns3/hns3_rxtx.h      |  4 ++++
>>  lib/librte_ethdev/rte_ethdev.h    |  2 ++
>>  6 files changed, 59 insertions(+)
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> Linuxarm mailing list
>> Linuxarm@huawei.com
>> http://hulk.huawei.com/mailman/listinfo/linuxarm
>>
>> .
>>
>
  

Hi Ferruh,

Thank you for your reply. I'm sorry to bother you while you are busy with
the release. I know this change may only be accepted in the next release.
I'd like to know what the community thinks about it. If there is no
objection, I will send the patch after current release out.

On 2020/7/28 17:30, Ferruh Yigit wrote:
> On 7/28/2020 7:29 AM, Chengchang Tang wrote:
>> Friendly ping
> 
> Hi Tang,
> 
> Sorry for not making it clear, since it is a library change, the change is
> already late for this release (20.08), and it will be considered for next
> release. As current release out, we can continue the discussions.
> 
>>
>> On 2020/7/22 14:38, Chengchang Tang wrote:
>>> In common practice, PMD configure the rx buffer size which indicate the
>>> buffer length could be used for hw in receiving packts according to the
>>> data room size of the object in mempool. But in fact the final value is
>>> related to the specifications of hw, and its values will affect the number
>>> of fragments in recieving pkts when scatter is enabled. By the way, some
>>> PMDs may force to enable scatter when the MTU is bigger than the hw rx
>>> buffer size.
>>>
>>> At present, we seem to have no way to expose relevant information to upper
>>> layer users.
>>>
>>> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
>>> buffer size used in recieving pkts for hw. And this patchset also add hns3
>>> PMD implementation and update the testpmd to clarify intention.
>>>
>>> v2:
>>> Add hns3 implementation and update testpmd.
>>>
>>> Chengchang Tang (2):
>>>   ethdev: add a field for rte_eth_rxq_info
>>>   app/testpmd: Add RX buffer size dispaly in queue info querry
>>>
>>> Huisong Li (1):
>>>   net/hns3: add support for query of rx/tx queue info
>>>
>>>  app/test-pmd/config.c             |  1 +
>>>  drivers/net/hns3/hns3_ethdev.c    |  2 ++
>>>  drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
>>>  drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
>>>  drivers/net/hns3/hns3_rxtx.h      |  4 ++++
>>>  lib/librte_ethdev/rte_ethdev.h    |  2 ++
>>>  6 files changed, 59 insertions(+)
>>>
>>> --
>>> 2.7.4
>>>
>>> _______________________________________________
>>> Linuxarm mailing list
>>> Linuxarm@huawei.com
>>> http://hulk.huawei.com/mailman/listinfo/linuxarm
>>>
>>> .
>>>
>>
> 
> 
> .
>
  

You're right pinging for reviews. That's the right time to look at
next features for those who have completed their 20.08 tasks.

Feel free to review other pending patches in the meantime.
Some of the next features are classified as "Deferred" in patchwork:
	https://patches.dpdk.org/project/dpdk/list/?state=10


28/07/2020 13:39, Chengchang Tang:
> Hi Ferruh,
> 
> Thank you for your reply. I'm sorry to bother you while you are busy with
> the release. I know this change may only be accepted in the next release.
> I'd like to know what the community thinks about it. If there is no
> objection, I will send the patch after current release out.
> 
> On 2020/7/28 17:30, Ferruh Yigit wrote:
> > On 7/28/2020 7:29 AM, Chengchang Tang wrote:
> >> Friendly ping
> > 
> > Hi Tang,
> > 
> > Sorry for not making it clear, since it is a library change, the change is
> > already late for this release (20.08), and it will be considered for next
> > release. As current release out, we can continue the discussions.
> > 
> >>
> >> On 2020/7/22 14:38, Chengchang Tang wrote:
> >>> In common practice, PMD configure the rx buffer size which indicate the
> >>> buffer length could be used for hw in receiving packts according to the
> >>> data room size of the object in mempool. But in fact the final value is
> >>> related to the specifications of hw, and its values will affect the number
> >>> of fragments in recieving pkts when scatter is enabled. By the way, some
> >>> PMDs may force to enable scatter when the MTU is bigger than the hw rx
> >>> buffer size.
> >>>
> >>> At present, we seem to have no way to expose relevant information to upper
> >>> layer users.
> >>>
> >>> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
> >>> buffer size used in recieving pkts for hw. And this patchset also add hns3
> >>> PMD implementation and update the testpmd to clarify intention.
> >>>
> >>> v2:
> >>> Add hns3 implementation and update testpmd.
> >>>
> >>> Chengchang Tang (2):
> >>>   ethdev: add a field for rte_eth_rxq_info
> >>>   app/testpmd: Add RX buffer size dispaly in queue info querry
> >>>
> >>> Huisong Li (1):
> >>>   net/hns3: add support for query of rx/tx queue info
> >>>
> >>>  app/test-pmd/config.c             |  1 +
> >>>  drivers/net/hns3/hns3_ethdev.c    |  2 ++
> >>>  drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
> >>>  drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
> >>>  drivers/net/hns3/hns3_rxtx.h      |  4 ++++
> >>>  lib/librte_ethdev/rte_ethdev.h    |  2 ++
> >>>  6 files changed, 59 insertions(+)
> >>>
> >>> --
> >>> 2.7.4
> >>>
> >>> _______________________________________________
> >>> Linuxarm mailing list
> >>> Linuxarm@huawei.com
> >>> http://hulk.huawei.com/mailman/listinfo/linuxarm
> >>>
> >>> .
> >>>
> >>
> > 
> > 
> > .
> > 
> 
>