mbox series

[v3,00/11] drivers/baseband: PMD for FPGA 5GNR FEC

Message ID 1587098436-7493-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series drivers/baseband: PMD for FPGA 5GNR FEC |

Message

Chautru, Nicolas April 17, 2020, 4:40 a.m. UTC
  v3: Incremental changes from reviews : file name change, 
moving few inline function to .h, adding missing inline, 
doxygen markup fix. 

Adding new baseband PMD for FPGA 5GNR FEC implementation. 

Nicolas Chautru (11):
  drivers/baseband: add PMD for FPGA 5GNR FEC
  baseband/fpga_5gnr_fec: add register definition file
  baseband/fpga_5gnr_fec: add device info_get function
  baseband/fpga_5gnr_fec: add queue configuration
  baseband/fpga_5gnr_fec: add LDPC processing functions
  baseband/fpga_5gnr_fec: add HW error capture
  baseband/fpga_5gnr_fec: add debug functionality
  baseband/fpga_5gnr_fec: add configure function
  baseband/fpga_5gnr_fec: add harq loopback capability
  baseband/fpga_5gnr_fec: add interrupt support
  doc: add feature matrix table for bbdev devices

 .gitignore                                         |    1 +
 app/test-bbdev/Makefile                            |    3 +
 app/test-bbdev/meson.build                         |    3 +
 app/test-bbdev/test_bbdev_perf.c                   |   57 +
 config/common_base                                 |    5 +
 doc/guides/bbdevs/features/default.ini             |   16 +
 doc/guides/bbdevs/features/fpga_5gnr_fec.ini       |   11 +
 doc/guides/bbdevs/features/fpga_lte_fec.ini        |   10 +
 doc/guides/bbdevs/features/mbc.ini                 |   14 +
 doc/guides/bbdevs/features/null.ini                |    7 +
 doc/guides/bbdevs/features/turbo_sw.ini            |   11 +
 doc/guides/bbdevs/fpga_5gnr_fec.rst                |  297 +++
 doc/guides/bbdevs/index.rst                        |    2 +
 doc/guides/bbdevs/overview.rst                     |   15 +
 doc/guides/conf.py                                 |    5 +
 doc/guides/rel_notes/release_20_05.rst             |    5 +
 drivers/baseband/Makefile                          |    2 +
 drivers/baseband/fpga_5gnr_fec/Makefile            |   29 +
 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h     |  388 ++++
 drivers/baseband/fpga_5gnr_fec/meson.build         |    6 +
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2187 ++++++++++++++++++++
 .../rte_pmd_bbdev_fpga_5gnr_fec_version.map        |   10 +
 .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |   74 +
 drivers/baseband/meson.build                       |    2 +-
 mk/rte.app.mk                                      |    1 +
 25 files changed, 3160 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/bbdevs/features/default.ini
 create mode 100644 doc/guides/bbdevs/features/fpga_5gnr_fec.ini
 create mode 100644 doc/guides/bbdevs/features/fpga_lte_fec.ini
 create mode 100644 doc/guides/bbdevs/features/mbc.ini
 create mode 100644 doc/guides/bbdevs/features/null.ini
 create mode 100644 doc/guides/bbdevs/features/turbo_sw.ini
 create mode 100644 doc/guides/bbdevs/fpga_5gnr_fec.rst
 create mode 100644 doc/guides/bbdevs/overview.rst
 create mode 100644 drivers/baseband/fpga_5gnr_fec/Makefile
 create mode 100644 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
 create mode 100644 drivers/baseband/fpga_5gnr_fec/meson.build
 create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
 create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map
 create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
  

Comments

Akhil Goyal April 17, 2020, 3:16 p.m. UTC | #1
Hi Nicolas,

It seems you missed a couple of patches in the series which were doing changes in BBDEV.
Should I take those from v2?

Series 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Regards,
Akhil
> 
> v3: Incremental changes from reviews : file name change,
> moving few inline function to .h, adding missing inline,
> doxygen markup fix.
> 
> Adding new baseband PMD for FPGA 5GNR FEC implementation.
> 
> Nicolas Chautru (11):
>   drivers/baseband: add PMD for FPGA 5GNR FEC
>   baseband/fpga_5gnr_fec: add register definition file
>   baseband/fpga_5gnr_fec: add device info_get function
>   baseband/fpga_5gnr_fec: add queue configuration
>   baseband/fpga_5gnr_fec: add LDPC processing functions
>   baseband/fpga_5gnr_fec: add HW error capture
>   baseband/fpga_5gnr_fec: add debug functionality
>   baseband/fpga_5gnr_fec: add configure function
>   baseband/fpga_5gnr_fec: add harq loopback capability
>   baseband/fpga_5gnr_fec: add interrupt support
>   doc: add feature matrix table for bbdev devices
>
  
Chautru, Nicolas April 17, 2020, 4:49 p.m. UTC | #2
Hi Akhil, 

You already have applied these 2 from thr other serie. So when I rebased on latest these are no longer required.
If you remember we split the initial serie into 2 separate series, but then I kept the same first 2 patches on both serie are they are required as a dependency (to make sure it builds in CI). 
Since you have now applied the first serie the other week, then these 2 commits are already applied and are no longer required on the v3.
Let me know if unclear
Nic

> 
> Hi Nicolas,
> 
> It seems you missed a couple of patches in the series which were doing changes
> in BBDEV.
> Should I take those from v2?
> 
> Series
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Regards,
> Akhil
> >
> > v3: Incremental changes from reviews : file name change, moving few
> > inline function to .h, adding missing inline, doxygen markup fix.
> >
> > Adding new baseband PMD for FPGA 5GNR FEC implementation.
> >
> > Nicolas Chautru (11):
> >   drivers/baseband: add PMD for FPGA 5GNR FEC
> >   baseband/fpga_5gnr_fec: add register definition file
> >   baseband/fpga_5gnr_fec: add device info_get function
> >   baseband/fpga_5gnr_fec: add queue configuration
> >   baseband/fpga_5gnr_fec: add LDPC processing functions
> >   baseband/fpga_5gnr_fec: add HW error capture
> >   baseband/fpga_5gnr_fec: add debug functionality
> >   baseband/fpga_5gnr_fec: add configure function
> >   baseband/fpga_5gnr_fec: add harq loopback capability
> >   baseband/fpga_5gnr_fec: add interrupt support
> >   doc: add feature matrix table for bbdev devices
> >
  
Akhil Goyal April 17, 2020, 4:51 p.m. UTC | #3
> Hi Akhil,
> 
> You already have applied these 2 from thr other serie. So when I rebased on
> latest these are no longer required.
> If you remember we split the initial serie into 2 separate series, but then I kept
> the same first 2 patches on both serie are they are required as a dependency (to
> make sure it builds in CI).
> Since you have now applied the first serie the other week, then these 2 commits
> are already applied and are no longer required on the v3.
> Let me know if unclear
> Nic
> 
OK my bad.. Thanks for clarifying.
  
Akhil Goyal April 17, 2020, 8 p.m. UTC | #4
> 
> v3: Incremental changes from reviews : file name change,
> moving few inline function to .h, adding missing inline,
> doxygen markup fix.
> 
> Adding new baseband PMD for FPGA 5GNR FEC implementation.
> 
> Nicolas Chautru (11):
>   drivers/baseband: add PMD for FPGA 5GNR FEC
>   baseband/fpga_5gnr_fec: add register definition file
>   baseband/fpga_5gnr_fec: add device info_get function
>   baseband/fpga_5gnr_fec: add queue configuration
>   baseband/fpga_5gnr_fec: add LDPC processing functions
>   baseband/fpga_5gnr_fec: add HW error capture
>   baseband/fpga_5gnr_fec: add debug functionality
>   baseband/fpga_5gnr_fec: add configure function
>   baseband/fpga_5gnr_fec: add harq loopback capability
>   baseband/fpga_5gnr_fec: add interrupt support
>   doc: add feature matrix table for bbdev devices
> 
>  .gitignore                                         |    1 +
>  app/test-bbdev/Makefile                            |    3 +
>  app/test-bbdev/meson.build                         |    3 +
>  app/test-bbdev/test_bbdev_perf.c                   |   57 +
>  config/common_base                                 |    5 +
>  doc/guides/bbdevs/features/default.ini             |   16 +
>  doc/guides/bbdevs/features/fpga_5gnr_fec.ini       |   11 +
>  doc/guides/bbdevs/features/fpga_lte_fec.ini        |   10 +
>  doc/guides/bbdevs/features/mbc.ini                 |   14 +
>  doc/guides/bbdevs/features/null.ini                |    7 +
>  doc/guides/bbdevs/features/turbo_sw.ini            |   11 +
>  doc/guides/bbdevs/fpga_5gnr_fec.rst                |  297 +++
>  doc/guides/bbdevs/index.rst                        |    2 +
>  doc/guides/bbdevs/overview.rst                     |   15 +
>  doc/guides/conf.py                                 |    5 +
>  doc/guides/rel_notes/release_20_05.rst             |    5 +
>  drivers/baseband/Makefile                          |    2 +
>  drivers/baseband/fpga_5gnr_fec/Makefile            |   29 +
>  drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h     |  388 ++++
>  drivers/baseband/fpga_5gnr_fec/meson.build         |    6 +
>  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2187
> ++++++++++++++++++++
>  .../rte_pmd_bbdev_fpga_5gnr_fec_version.map        |   10 +
>  .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |   74 +
>  drivers/baseband/meson.build                       |    2 +-
>  mk/rte.app.mk                                      |    1 +
>  25 files changed, 3160 insertions(+), 1 deletion(-)
>  create mode 100644 doc/guides/bbdevs/features/default.ini
>  create mode 100644 doc/guides/bbdevs/features/fpga_5gnr_fec.ini
>  create mode 100644 doc/guides/bbdevs/features/fpga_lte_fec.ini
>  create mode 100644 doc/guides/bbdevs/features/mbc.ini
>  create mode 100644 doc/guides/bbdevs/features/null.ini
>  create mode 100644 doc/guides/bbdevs/features/turbo_sw.ini
>  create mode 100644 doc/guides/bbdevs/fpga_5gnr_fec.rst
>  create mode 100644 doc/guides/bbdevs/overview.rst
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/Makefile
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/meson.build
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
>  create mode 100644
> drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map
>  create mode 100644
> drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
> 
> --
Please also update the MAINTAINERS for the newly added files.
  
Akhil Goyal April 17, 2020, 8:06 p.m. UTC | #5
> > --
> Please also update the MAINTAINERS for the newly added files.

Please ignore this. There is a blanket update in MAINTAINERS for all
The bbdev drivers.