mbox series

[0/3] net definitions fixes

Message ID 1571820718-7021-1-git-send-email-david.marchand@redhat.com (mailing list archive)
Headers
Series net definitions fixes |

Message

David Marchand Oct. 23, 2019, 8:51 a.m. UTC 
  Small patchset with fixes after inspecting the librte_net.
I copied stable@dpdk.org in the 2nd patch for information only.

Comments

Ferruh Yigit Oct. 23, 2019, 12:12 p.m. UTC | #1 
On 10/23/2019 9:51 AM, David Marchand wrote:
> Small patchset with fixes after inspecting the librte_net.
> I copied stable@dpdk.org in the 2nd patch for information only.
> 

Overall lgtm. And this release seems the one to make these changes, and we
already break the API for net library on this release BUT should we update the
ABIVER for net library?
David Marchand Oct. 23, 2019, 12:57 p.m. UTC | #2 
On Wed, Oct 23, 2019 at 2:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/23/2019 9:51 AM, David Marchand wrote:
> > Small patchset with fixes after inspecting the librte_net.
> > I copied stable@dpdk.org in the 2nd patch for information only.
> >
>
> Overall lgtm. And this release seems the one to make these changes, and we
> already break the API for net library on this release BUT should we update the
> ABIVER for net library?

This patchset breaks API by renaming structures/defines and remove
some constant defines.
ABI should be the same ?
David Marchand Oct. 23, 2019, 1 p.m. UTC | #3 
On Wed, Oct 23, 2019 at 2:57 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Oct 23, 2019 at 2:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > On 10/23/2019 9:51 AM, David Marchand wrote:
> > > Small patchset with fixes after inspecting the librte_net.
> > > I copied stable@dpdk.org in the 2nd patch for information only.
> > >
> >
> > Overall lgtm. And this release seems the one to make these changes, and we
> > already break the API for net library on this release BUT should we update the
> > ABIVER for net library?
>
> This patchset breaks API by renaming structures/defines and remove
> some constant defines.
> ABI should be the same ?

But I suppose adding some words in the release notes can't be wrong.
Ferruh Yigit Oct. 23, 2019, 1:19 p.m. UTC | #4 
On 10/23/2019 2:00 PM, David Marchand wrote:
> On Wed, Oct 23, 2019 at 2:57 PM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On Wed, Oct 23, 2019 at 2:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 10/23/2019 9:51 AM, David Marchand wrote:
>>>> Small patchset with fixes after inspecting the librte_net.
>>>> I copied stable@dpdk.org in the 2nd patch for information only.
>>>>
>>>
>>> Overall lgtm. And this release seems the one to make these changes, and we
>>> already break the API for net library on this release BUT should we update the
>>> ABIVER for net library?
>>
>> This patchset breaks API by renaming structures/defines and remove
>> some constant defines.
>> ABI should be the same ?
> 
> But I suppose adding some words in the release notes can't be wrong.
> 

You are right, there is not point on increasing ABIVER since only API is
changing, +1 to document change in release notes. (also for previous rte_esp change)

Thanks,