| Message ID | 20201126160837.1385842-1-thomas@monjalon.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/travis-robot | success | Travis build: passed |
| ci/checkpatch | success | coding style OK |
On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote: > The compilation of the kernel module KNI is optional. > The kernel headers should be required for DPDK compilation. > > Fixes: 91a861e54164 ("config: disable Linux kernel modules by default") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- If someone does want to build kni, we actually have a check in meson.build for kernel build headers, giving a suitable error if they are missed. Therefore I think this can go. Acked-by: Bruce Richardson <bruce.richardson@intel.com>
26/11/2020 17:21, Bruce Richardson: > On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote: > > The compilation of the kernel module KNI is optional. > > The kernel headers should be required for DPDK compilation. not, should not :) > > Fixes: 91a861e54164 ("config: disable Linux kernel modules by default") > > Cc: stable@dpdk.org > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > If someone does want to build kni, we actually have a check in meson.build > for kernel build headers, giving a suitable error if they are missed. > Therefore I think this can go. > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied with fixed typo.
diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index ab38284950..87f7c9aa8c 100644 --- a/doc/guides/linux_gsg/sys_reqs.rst +++ b/doc/guides/linux_gsg/sys_reqs.rst @@ -58,8 +58,6 @@ Compilation of the DPDK * ``libnuma-dev`` in Debian/Ubuntu; -* Linux kernel headers or sources required to build kernel modules. - .. note:: Please ensure that the latest patches are applied to third party libraries
The compilation of the kernel module KNI is optional. The kernel headers should be required for DPDK compilation. Fixes: 91a861e54164 ("config: disable Linux kernel modules by default") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- doc/guides/linux_gsg/sys_reqs.rst | 2 -- 1 file changed, 2 deletions(-)