eal/windows: revert definition of ETOOMANYREFS
diff mbox series

Message ID 20201119154310.16824-1-talshn@nvidia.com
State Accepted, archived
Delegated to: David Marchand
Headers show
Series
  • eal/windows: revert definition of ETOOMANYREFS
Related show

Checks

Context Check Description
ci/iol-testing warning Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Tal Shnaiderman Nov. 19, 2020, 3:43 p.m. UTC
This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of
external applications already defining it.

Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 lib/librte_eal/windows/include/rte_os.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Nick Connolly Nov. 19, 2020, 4:03 p.m. UTC | #1
Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>

On 19/11/2020 15:43, Tal Shnaiderman wrote:
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>   lib/librte_eal/windows/include/rte_os.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
> index 8300ea483a..569ed92d51 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -51,8 +51,6 @@ extern "C" {
>   /* as in <windows.h> */
>   typedef long long ssize_t;
>   
> -#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
> -
>   #ifndef RTE_TOOLCHAIN_GCC
>   
>   static inline int
David Marchand Nov. 20, 2020, 9:12 a.m. UTC | #2
On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

No need to copy stable, the reverted commit is only in the current release.

> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>

Applied, thanks.
David Marchand Nov. 20, 2020, 9:17 a.m. UTC | #3
On Fri, Nov 20, 2020 at 10:12 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
> >
> > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> >
> > The definition of ETOOMANYREFS is reverted as it breaks build of
> > external applications already defining it.
> >
> > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
>
> No need to copy stable, the reverted commit is only in the current release.
>
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>
>
> Applied, thanks.

Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion.
Can I get some acks please ?
Dmitry Kozlyuk Nov. 20, 2020, 9:25 a.m. UTC | #4
On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote:
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> 
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
> 
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>


On Fri, Nov 20, 2020 at 10:12 AM David Marchand
> <david.marchand@redhat.com> wrote:
>
> Hum, pulling back on this.
> I did not see any Windows maintainer opine in the discussion.
> Can I get some acks please ?

Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html
David Marchand Nov. 20, 2020, 3:01 p.m. UTC | #5
On Fri, Nov 20, 2020 at 10:26 AM Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com> wrote:
>
> On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote:
> > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> >
> > The definition of ETOOMANYREFS is reverted as it breaks build of
> > external applications already defining it.
> >
> > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Thank you Dmitry.
Applied for real this time.


> On Fri, Nov 20, 2020 at 10:12 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> >
> > Hum, pulling back on this.
> > I did not see any Windows maintainer opine in the discussion.
> > Can I get some acks please ?
>
> Discussion thread, for the reference:
> https://mails.dpdk.org/archives/dev/2020-November/192842.html

And a patch was just merged in next-net for rte_flow.h + mlx5 driver.
http://patchwork.dpdk.org/patch/84411/

Patch
diff mbox series

diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
index 8300ea483a..569ed92d51 100644
--- a/lib/librte_eal/windows/include/rte_os.h
+++ b/lib/librte_eal/windows/include/rte_os.h
@@ -51,8 +51,6 @@  extern "C" {
 /* as in <windows.h> */
 typedef long long ssize_t;
 
-#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
-
 #ifndef RTE_TOOLCHAIN_GCC
 
 static inline int