diff mbox series

[1/3] test/eal: remove unneeded command

Message ID 20201116100618.2894-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [1/3] test/eal: remove unneeded command |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

David Marchand Nov. 16, 2020, 10:06 a.m. UTC 
  All EAL flags tests are run by calling the "eal_flags_autotest" command.
There is no compatibility to maintain for sub commands only called by
meson.

Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/meson.build      | 2 +-
 app/test/test_eal_flags.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Thomas Monjalon Nov. 19, 2020, 6:50 p.m. UTC | #1 
16/11/2020 11:06, David Marchand:
> All EAL flags tests are run by calling the "eal_flags_autotest" command.
> There is no compatibility to maintain for sub commands only called by
> meson.
> 
> Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>
David Marchand Nov. 20, 2020, 9 a.m. UTC | #2 
On Thu, Nov 19, 2020 at 7:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 16/11/2020 11:06, David Marchand:
> > All EAL flags tests are run by calling the "eal_flags_autotest" command.
> > There is no compatibility to maintain for sub commands only called by
> > meson.
> >
> > Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Series applied.
diff mbox series

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 88c831a92e..94fd39fecb 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -195,7 +195,7 @@  fast_tests = [
         ['eal_flags_n_opt_autotest', false],
         ['eal_flags_hpet_autotest', false],
         ['eal_flags_no_huge_autotest', false],
-        ['eal_flags_w_opt_autotest', false],
+        ['eal_flags_a_opt_autotest', false],
         ['eal_flags_b_opt_autotest', false],
         ['eal_flags_vdev_opt_autotest', false],
         ['eal_flags_r_opt_autotest', false],
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 85b6c6d7c7..932fbe3d08 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1546,7 +1546,6 @@  REGISTER_TEST_COMMAND(eal_flags_main_opt_autotest, test_main_lcore_flag);
 REGISTER_TEST_COMMAND(eal_flags_n_opt_autotest, test_invalid_n_flag);
 REGISTER_TEST_COMMAND(eal_flags_hpet_autotest, test_no_hpet_flag);
 REGISTER_TEST_COMMAND(eal_flags_no_huge_autotest, test_no_huge_flag);
-REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_allow_flag); /* for legacy CI */
 REGISTER_TEST_COMMAND(eal_flags_a_opt_autotest, test_allow_flag);
 REGISTER_TEST_COMMAND(eal_flags_b_opt_autotest, test_invalid_b_flag);
 REGISTER_TEST_COMMAND(eal_flags_vdev_opt_autotest, test_invalid_vdev_flag);