net/mlx4: fix glue library name
diff mbox series

Message ID 20201026092035.11461-1-alialnu@nvidia.com
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series
  • net/mlx4: fix glue library name
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Ali Alnubani Oct. 26, 2020, 9:20 a.m. UTC
The MLX4 library wasn't being successfully initialized with
-Dibverbs_link=dlopen because it expected a shared object file
with a different name.

Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
Cc: bruce.richardson@intel.com

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
 drivers/net/mlx4/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matan Azrad Oct. 28, 2020, 7:42 a.m. UTC | #1
From: Ali Alnubani
> The MLX4 library wasn't being successfully initialized with -
> Dibverbs_link=dlopen because it expected a shared object file with a
> different name.
> 
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Raslan Darawsheh Nov. 1, 2020, 11:49 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Monday, October 26, 2020 11:21 AM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com
> Subject: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
> 
> The MLX4 library wasn't being successfully initialized with
> -Dibverbs_link=dlopen because it expected a shared object file
> with a different name.
> 
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
>  drivers/net/mlx4/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
Ferruh Yigit Nov. 2, 2020, 1:01 p.m. UTC | #3
On 10/26/2020 9:20 AM, Ali Alnubani wrote:
> The MLX4 library wasn't being successfully initialized with
> -Dibverbs_link=dlopen because it expected a shared object file
> with a different name.
> 

The mlx4 glue library name seems changed in the patch pointed by Fixes line, but 
mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you 
please fix that too in a separate patch?

> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
>   drivers/net/mlx4/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
> index 404006515..c22a88875 100644
> --- a/drivers/net/mlx4/meson.build
> +++ b/drivers/net/mlx4/meson.build
> @@ -10,7 +10,7 @@ endif
>   
>   static_ibverbs = (get_option('ibverbs_link') == 'static')
>   dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
>   LIB_GLUE_VERSION = '18.02.0'
>   LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
>   if dlopen_ibverbs
>
Ferruh Yigit Nov. 2, 2020, 1:04 p.m. UTC | #4
On 11/2/2020 1:01 PM, Ferruh Yigit wrote:
> On 10/26/2020 9:20 AM, Ali Alnubani wrote:
>> The MLX4 library wasn't being successfully initialized with
>> -Dibverbs_link=dlopen because it expected a shared object file
>> with a different name.
>>
> 
> The mlx4 glue library name seems changed in the patch pointed by Fixes line, but 
> mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you 
> please fix that too in a separate patch?
> 

I should be a little more patient, the fix is already in the same thread ;) Thanks.

https://patches.dpdk.org/patch/82174/


>> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>> Cc: bruce.richardson@intel.com
>>
>> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
>> ---
>>   drivers/net/mlx4/meson.build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
>> index 404006515..c22a88875 100644
>> --- a/drivers/net/mlx4/meson.build
>> +++ b/drivers/net/mlx4/meson.build
>> @@ -10,7 +10,7 @@ endif
>>   static_ibverbs = (get_option('ibverbs_link') == 'static')
>>   dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
>> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
>> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
>>   LIB_GLUE_VERSION = '18.02.0'
>>   LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
>>   if dlopen_ibverbs
>>
>
Ali Alnubani Nov. 2, 2020, 1:04 p.m. UTC | #5
Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 2, 2020 3:01 PM
> To: Ali Alnubani <alialnu@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; Matan Azrad
> <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
> 
> On 10/26/2020 9:20 AM, Ali Alnubani wrote:
> > The MLX4 library wasn't being successfully initialized with
> > -Dibverbs_link=dlopen because it expected a shared object file with a
> > different name.
> >
> 
> The mlx4 glue library name seems changed in the patch pointed by Fixes line,
> but
> mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you
> please fix that too in a separate patch?
>

This was done in http://patches.dpdk.org/patch/82174/. Is it what you meant?

Thanks,
Ali

Patch
diff mbox series

diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index 404006515..c22a88875 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -10,7 +10,7 @@  endif
 
 static_ibverbs = (get_option('ibverbs_link') == 'static')
 dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
+LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
 LIB_GLUE_VERSION = '18.02.0'
 LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
 if dlopen_ibverbs