[1/2] pipeline: fix jump instruction population
Checks
Commit Message
From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
This patch fixes jump next instruction pointer
population
Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
Cc: cristian.dumitrescu@intel.com
Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/librte_pipeline/rte_swx_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Thanks a lot Cristian for sending the patches for review.
I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.
Thanks & Regards,
Suresh.
-----Original Message-----
From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Sent: Friday, October 16, 2020 7:28 PM
To: dev@dpdk.org
Cc: P, Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Subject: [PATCH 1/2] pipeline: fix jump instruction population
From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
This patch fixes jump next instruction pointer population
Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
Cc: cristian.dumitrescu@intel.com
Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/librte_pipeline/rte_swx_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pipeline/rte_swx_pipeline.c b/lib/librte_pipeline/rte_swx_pipeline.c
index d5b4a1c..2c9fbf4 100644
--- a/lib/librte_pipeline/rte_swx_pipeline.c
+++ b/lib/librte_pipeline/rte_swx_pipeline.c
@@ -5647,7 +5647,7 @@ struct_field_parse(struct rte_swx_pipeline *p,
data->jmp_label);
CHECK(found, EINVAL);
- instr->jmp.ip = &instr[found - instruction_data];
+ instr->jmp.ip = &instructions[found - instruction_data];
}
return 0;
--
1.8.3.1
On Fri, Oct 16, 2020 at 4:12 PM P, Venkata Suresh Kumar
<venkata.suresh.kumar.p@intel.com> wrote:
>
> Thanks a lot Cristian for sending the patches for review.
> I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.
I just checked the dev ml moderation queue, but could only find spam,
and nothing from you.
SMTP issue?
On Fri, Oct 16, 2020 at 4:17 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Oct 16, 2020 at 4:12 PM P, Venkata Suresh Kumar
> <venkata.suresh.kumar.p@intel.com> wrote:
> >
> > Thanks a lot Cristian for sending the patches for review.
> > I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.
>
> I just checked the dev ml moderation queue, but could only find spam,
> and nothing from you.
> SMTP issue?
And please, do not top post.
Those patches got duplicate tokens in patchwork because of it.
On Fri, Oct 16, 2020 at 3:58 PM Cristian Dumitrescu
<cristian.dumitrescu@intel.com> wrote:
>
> From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
>
> This patch fixes jump next instruction pointer
> population
>
> Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
> Cc: cristian.dumitrescu@intel.com
>
> Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Series applied, thanks.
@@ -5647,7 +5647,7 @@ struct_field_parse(struct rte_swx_pipeline *p,
data->jmp_label);
CHECK(found, EINVAL);
- instr->jmp.ip = &instr[found - instruction_data];
+ instr->jmp.ip = &instructions[found - instruction_data];
}
return 0;