test/event_crypto_adapter: fix conf issue
diff mbox series

Message ID 1600305275-95991-1-git-send-email-abhinandan.gujjar@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • test/event_crypto_adapter: fix conf issue
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Gujjar, Abhinandan S Sept. 17, 2020, 1:14 a.m. UTC
This patch updates the xform with right configuration.
For session based ops, sym session pool is created with
valid userdata size.

Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
---
 app/test/test_event_crypto_adapter.c | 24 +++++-------------------
 1 file changed, 5 insertions(+), 19 deletions(-)

Comments

Akhil Goyal Sept. 22, 2020, 7:29 p.m. UTC | #1
Hi Abhinandan,

> This patch updates the xform with right configuration.
> For session based ops, sym session pool is created with
> valid userdata size.
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> ---
The patch description do not match with the patch.
I can see that you are changing the cipher algo from AES-CBC to NULL
Without explaining the reason.
Could you please clarify the need of this patch.

Regards,
Akhil
Gujjar, Abhinandan S Sept. 23, 2020, 7:10 a.m. UTC | #2
Hi Akhil,

Recently, I observed that test was failing with sw adapter.
I noticed that, it was because of some changes went in related to crypto in the past releases.
One of the tests, configures a session in turn calls null_crypto_set_session_parameters()
which checks for params was failing. As part of fixing & updating the xforms to address this issue,
thought of getting rid of algo as well, to make the test simpler. The test continues to use null cryptodev
and does not deal with any encryption or auth.

Regards
Abhinandan

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, September 23, 2020 12:59 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Abhinandan,
> 
> > This patch updates the xform with right configuration.
> > For session based ops, sym session pool is created with valid userdata
> > size.
> >
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > ---
> The patch description do not match with the patch.
> I can see that you are changing the cipher algo from AES-CBC to NULL
> Without explaining the reason.
> Could you please clarify the need of this patch.
> 
> Regards,
> Akhil
Gujjar, Abhinandan S Oct. 6, 2020, 10:25 a.m. UTC | #3
Hi Akhil,

If the patch is ok, could you please ack it?

Regards
Abhinandan

> -----Original Message-----
> From: Gujjar, Abhinandan S
> Sent: Wednesday, September 23, 2020 12:41 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Akhil,
> 
> Recently, I observed that test was failing with sw adapter.
> I noticed that, it was because of some changes went in related to crypto in
> the past releases.
> One of the tests, configures a session in turn calls
> null_crypto_set_session_parameters()
> which checks for params was failing. As part of fixing & updating the xforms
> to address this issue, thought of getting rid of algo as well, to make the test
> simpler. The test continues to use null cryptodev and does not deal with any
> encryption or auth.
> 
> Regards
> Abhinandan
> 
> > -----Original Message-----
> > From: Akhil Goyal <akhil.goyal@nxp.com>
> > Sent: Wednesday, September 23, 2020 12:59 AM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> > jerinj@marvell.com
> > Cc: Vangati, Narender <narender.vangati@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > issue
> >
> > Hi Abhinandan,
> >
> > > This patch updates the xform with right configuration.
> > > For session based ops, sym session pool is created with valid
> > > userdata size.
> > >
> > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > ---
> > The patch description do not match with the patch.
> > I can see that you are changing the cipher algo from AES-CBC to NULL
> > Without explaining the reason.
> > Could you please clarify the need of this patch.
> >
> > Regards,
> > Akhil
Akhil Goyal Oct. 9, 2020, 7:01 p.m. UTC | #4
Hi Abhinandan,

> Hi Akhil,
> 
> If the patch is ok, could you please ack it?
> 
Could you please send the Fixes tag for the original patch which introduced this
Issue? I will add it while applying the patch.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>


> >
> > Hi Akhil,
> >
> > Recently, I observed that test was failing with sw adapter.
> > I noticed that, it was because of some changes went in related to crypto in
> > the past releases.
> > One of the tests, configures a session in turn calls
> > null_crypto_set_session_parameters()
> > which checks for params was failing. As part of fixing & updating the xforms
> > to address this issue, thought of getting rid of algo as well, to make the test
> > simpler. The test continues to use null cryptodev and does not deal with any
> > encryption or auth.
> >
> > Regards
> > Abhinandan
> >
> > > -----Original Message-----
> > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> > > jerinj@marvell.com
> > > Cc: Vangati, Narender <narender.vangati@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > > issue
> > >
> > > Hi Abhinandan,
> > >
> > > > This patch updates the xform with right configuration.
> > > > For session based ops, sym session pool is created with valid
> > > > userdata size.
> > > >
> > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > ---
> > > The patch description do not match with the patch.
> > > I can see that you are changing the cipher algo from AES-CBC to NULL
> > > Without explaining the reason.
> > > Could you please clarify the need of this patch.
> > >
> > > Regards,
> > > Akhil
Gujjar, Abhinandan S Oct. 12, 2020, 6:24 a.m. UTC | #5
Hi Akhil,

This was introduced in patch (24054e3640a2).

Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")

Thanks
Abhinandan

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Saturday, October 10, 2020 12:32 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Abhinandan,
> 
> > Hi Akhil,
> >
> > If the patch is ok, could you please ack it?
> >
> Could you please send the Fixes tag for the original patch which introduced this
> Issue? I will add it while applying the patch.
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> 
> > >
> > > Hi Akhil,
> > >
> > > Recently, I observed that test was failing with sw adapter.
> > > I noticed that, it was because of some changes went in related to
> > > crypto in the past releases.
> > > One of the tests, configures a session in turn calls
> > > null_crypto_set_session_parameters()
> > > which checks for params was failing. As part of fixing & updating
> > > the xforms to address this issue, thought of getting rid of algo as
> > > well, to make the test simpler. The test continues to use null
> > > cryptodev and does not deal with any encryption or auth.
> > >
> > > Regards
> > > Abhinandan
> > >
> > > > -----Original Message-----
> > > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > > > dev@dpdk.org; jerinj@marvell.com
> > > > Cc: Vangati, Narender <narender.vangati@intel.com>
> > > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix
> > > > conf issue
> > > >
> > > > Hi Abhinandan,
> > > >
> > > > > This patch updates the xform with right configuration.
> > > > > For session based ops, sym session pool is created with valid
> > > > > userdata size.
> > > > >
> > > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > > ---
> > > > The patch description do not match with the patch.
> > > > I can see that you are changing the cipher algo from AES-CBC to
> > > > NULL Without explaining the reason.
> > > > Could you please clarify the need of this patch.
> > > >
> > > > Regards,
> > > > Akhil
Akhil Goyal Oct. 12, 2020, 7:29 p.m. UTC | #6
> Hi Akhil,
> 
> This was introduced in patch (24054e3640a2).
> 
> Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")
> 
Applied to dpdk-next-crypto

Cc: stable@dpdk.org

Thanks.

Patch
diff mbox series

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 8d42462..530ce96 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -171,7 +171,6 @@  struct rte_event_crypto_request request_info = {
 	struct rte_event ev;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -183,14 +182,7 @@  struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -378,7 +370,6 @@  struct rte_event_crypto_request request_info = {
 	struct rte_mbuf *m;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -390,14 +381,7 @@  struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -564,7 +548,9 @@  struct rte_event_crypto_request request_info = {
 
 	params.session_mpool = rte_cryptodev_sym_session_pool_create(
 			"CRYPTO_ADAPTER_SESSION_MP",
-			MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
+			MAX_NB_SESSIONS, 0, 0,
+			sizeof(union rte_event_crypto_metadata),
+			SOCKET_ID_ANY);
 	TEST_ASSERT_NOT_NULL(params.session_mpool,
 			"session mempool allocation failed\n");