| Message ID | 20200825175106.1614124-1-ferruh.yigit@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/travis-robot | success | Travis build: passed |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Tuesday, August 25, 2020 11:21 PM > To: dev@dpdk.org; Ray Kinsella <mdr@ashroe.eu>; Neil Horman > <nhorman@tuxdriver.com>; John McNamara <john.mcnamara@intel.com>; > Marko Kovacevic <marko.kovacevic@intel.com>; Hemant Agrawal > <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com> > Cc: Ferruh Yigit <ferruh.yigit@intel.com>; stable@dpdk.org > Subject: [PATCH v2] net/dpaa: fix public API port ID type > > Updating the type for 'port' variable from 'uint8_t' to 'uint16_t'. > > Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > v2: > * Remove deprecation notice > --- > doc/guides/rel_notes/deprecation.rst | 3 --- > drivers/net/dpaa/dpaa_ethdev.c | 2 +- > drivers/net/dpaa/rte_pmd_dpaa.h | 2 +- > 3 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 345c38d5b6..249d4c50a1 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -254,9 +254,6 @@ Deprecation Notices > experimental in v20.11 DPDK release. For more details, please see `the > thread > > <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail > s.dpdk.org%2Farchives%2Fdev%2F2020- > April%2F164970.html&data=02%7C01%7Chemant.agrawal%40nxp.com > %7C7277661bfed84b6efd8e08d8491f754a%7C686ea1d3bc2b4c6fa92cd99c5c3 > 01635%7C0%7C0%7C637339746748499018&sdata=zhi6GXeFItNrWhst3L1 > TTOPqTG47kthyyYHBe8Sn7Mw%3D&reserved=0>`_. > > -* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have > extended > - ``port_id`` definition from ``uint8_t`` to ``uint16_t``. > - > * vhost: Vhost-user dequeue zero-copy support will be removed in 20.11. > The only known user is OVS where the feature is still experimental, > and has not received any update for 2.5 years. > diff --git a/drivers/net/dpaa/dpaa_ethdev.c > b/drivers/net/dpaa/dpaa_ethdev.c index c15e2b5462..e84f904071 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c > @@ -1354,7 +1354,7 @@ is_dpaa_supported(struct rte_eth_dev *dev) } > > int > -rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on) > +rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on) > { > struct rte_eth_dev *dev; > > diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h > b/drivers/net/dpaa/rte_pmd_dpaa.h index 8d244bb491..ec45633ba2 100644 > --- a/drivers/net/dpaa/rte_pmd_dpaa.h > +++ b/drivers/net/dpaa/rte_pmd_dpaa.h > @@ -29,6 +29,6 @@ > * - (-EINVAL) if bad parameter. > */ > int > -rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on); > +rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on); > > #endif /* _PMD_DPAA_H_ */ > -- > 2.25.4
On 8/26/2020 6:15 AM, Hemant Agrawal wrote: >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Tuesday, August 25, 2020 11:21 PM >> To: dev@dpdk.org; Ray Kinsella <mdr@ashroe.eu>; Neil Horman >> <nhorman@tuxdriver.com>; John McNamara <john.mcnamara@intel.com>; >> Marko Kovacevic <marko.kovacevic@intel.com>; Hemant Agrawal >> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com> >> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; stable@dpdk.org >> Subject: [PATCH v2] net/dpaa: fix public API port ID type >> >> Updating the type for 'port' variable from 'uint8_t' to 'uint16_t'. >> >> Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > Applied to dpdk-next-net/main, thanks.
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 345c38d5b6..249d4c50a1 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -254,9 +254,6 @@ Deprecation Notices experimental in v20.11 DPDK release. For more details, please see `the thread <https://mails.dpdk.org/archives/dev/2020-April/164970.html>`_. -* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended - ``port_id`` definition from ``uint8_t`` to ``uint16_t``. - * vhost: Vhost-user dequeue zero-copy support will be removed in 20.11. The only known user is OVS where the feature is still experimental, and has not received any update for 2.5 years. diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index c15e2b5462..e84f904071 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1354,7 +1354,7 @@ is_dpaa_supported(struct rte_eth_dev *dev) } int -rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on) +rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on) { struct rte_eth_dev *dev; diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd_dpaa.h index 8d244bb491..ec45633ba2 100644 --- a/drivers/net/dpaa/rte_pmd_dpaa.h +++ b/drivers/net/dpaa/rte_pmd_dpaa.h @@ -29,6 +29,6 @@ * - (-EINVAL) if bad parameter. */ int -rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on); +rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on); #endif /* _PMD_DPAA_H_ */
Updating the type for 'port' variable from 'uint8_t' to 'uint16_t'. Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- v2: * Remove deprecation notice --- doc/guides/rel_notes/deprecation.rst | 3 --- drivers/net/dpaa/dpaa_ethdev.c | 2 +- drivers/net/dpaa/rte_pmd_dpaa.h | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-)