diff mbox series

[v3,4/7] doc: update sample app with unknown speed

Message ID 20200615090158.18912-5-i.dyukov@samsung.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: allow unknown link speed |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Ivan Dyukov June 15, 2020, 9:01 a.m. UTC 
  Add usage of rte_eth_link_format function to example
applications

Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
---
 doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Ferruh Yigit June 17, 2020, 4:50 p.m. UTC | #1 
On 6/15/2020 10:01 AM, Ivan Dyukov wrote:
> Add usage of rte_eth_link_format function to example
> applications
> 
> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
> ---
>  doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst
> index 04c40f285..d1ac35be8 100644
> --- a/doc/guides/sample_app_ug/link_status_intr.rst
> +++ b/doc/guides/sample_app_ug/link_status_intr.rst
> @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below.
>      {
>          struct rte_eth_link link;
>          int ret;
> +        char text[200];

similarly, better to say something like 'link_status' instead of just 'text'.
diff mbox series

Patch

diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst
index 04c40f285..d1ac35be8 100644
--- a/doc/guides/sample_app_ug/link_status_intr.rst
+++ b/doc/guides/sample_app_ug/link_status_intr.rst
@@ -158,6 +158,7 @@  An example callback function that has been written as indicated below.
     {
         struct rte_eth_link link;
         int ret;
+        char text[200];
 
         RTE_SET_USED(param);
 
@@ -169,11 +170,10 @@  An example callback function that has been written as indicated below.
         if (ret < 0) {
             printf("Failed to get port %d link status: %s\n\n",
                    port_id, rte_strerror(-ret));
-        } else if (link.link_status) {
-            printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed,
-                  (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex"));
-        } else
-            printf("Port %d Link Down\n\n", port_id);
+        } else {
+            rte_eth_link_format(text, 200, NULL, &link);
+            printf("Port %d %s\n\n", port_id, text);
+        }
     }
 
 This function is called when a link status interrupt is present for the right port.