diff mbox series

build: add note about make system deprecation

Message ID 20200409105746.26955-1-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series build: add note about make system deprecation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson April 9, 2020, 10:57 a.m. UTC 
  When anyone uses the make build system, they are to be informed
about upcoming plans to deprecate and subsequently remove that
system and to use meson and ninja instead.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 mk/rte.sdkbuild.mk  | 4 ++++
 mk/rte.sdkconfig.mk | 4 ++++
 2 files changed, 8 insertions(+)

Comments

Ferruh Yigit April 9, 2020, 11:09 a.m. UTC | #1 
On 4/9/2020 11:57 AM, Bruce Richardson wrote:
> When anyone uses the make build system, they are to be informed
> about upcoming plans to deprecate and subsequently remove that
> system and to use meson and ninja instead.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  mk/rte.sdkbuild.mk  | 4 ++++
>  mk/rte.sdkconfig.mk | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> index b512de1ec..67d07a7ed 100644
> --- a/mk/rte.sdkbuild.mk
> +++ b/mk/rte.sdkbuild.mk
> @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
>  .PHONY: build
>  build: $(ROOTDIRS-y)
>  	@echo "Build complete [$(RTE_TARGET)]"
> +	@echo "==== NOTE ===="
> +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> +	@echo "=============="
>  
>  .PHONY: clean
>  clean: $(CLEANDIRS)
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index f538649f2..9a7ffbe9a 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -62,6 +62,10 @@ else
>  config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
>  	@echo "Configuration done using" \
>  		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
> +	@echo "==== NOTE ===="
> +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> +	@echo "=============="

What do you think providing a link to meson documentation too?

>  endif
>  
>  $(RTE_OUTPUT):
>
Bruce Richardson April 9, 2020, 11:16 a.m. UTC | #2 
On Thu, Apr 09, 2020 at 12:09:57PM +0100, Ferruh Yigit wrote:
> On 4/9/2020 11:57 AM, Bruce Richardson wrote:
> > When anyone uses the make build system, they are to be informed
> > about upcoming plans to deprecate and subsequently remove that
> > system and to use meson and ninja instead.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  mk/rte.sdkbuild.mk  | 4 ++++
> >  mk/rte.sdkconfig.mk | 4 ++++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> > index b512de1ec..67d07a7ed 100644
> > --- a/mk/rte.sdkbuild.mk
> > +++ b/mk/rte.sdkbuild.mk
> > @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
> >  .PHONY: build
> >  build: $(ROOTDIRS-y)
> >  	@echo "Build complete [$(RTE_TARGET)]"
> > +	@echo "==== NOTE ===="
> > +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> > +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> > +	@echo "=============="
> >  
> >  .PHONY: clean
> >  clean: $(CLEANDIRS)
> > diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> > index f538649f2..9a7ffbe9a 100644
> > --- a/mk/rte.sdkconfig.mk
> > +++ b/mk/rte.sdkconfig.mk
> > @@ -62,6 +62,10 @@ else
> >  config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
> >  	@echo "Configuration done using" \
> >  		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
> > +	@echo "==== NOTE ===="
> > +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> > +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> > +	@echo "=============="
> 
> What do you think providing a link to meson documentation too?
> 
Not a bad idea - though it may need to wait until the instructions on the
website itself get updated. Currently the best link is probably,
http://doc.dpdk.org/guides/linux_gsg/build_dpdk.html#compiling-and-installing-dpdk-system-wide
but it's rather long and unwieldy.

/Bruce
diff mbox series

Patch

diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index b512de1ec..67d07a7ed 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -28,6 +28,10 @@  CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
 .PHONY: clean
 clean: $(CLEANDIRS)
diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index f538649f2..9a7ffbe9a 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -62,6 +62,10 @@  else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 endif
 
 $(RTE_OUTPUT):